[Release] Server Buffs based on Online Player Count

[campomanes25]

please help me with these errors [Imgur]()

[-Valor]

Originally Posted by campomanes25

please help me with these errors [Imgur]()

Check your code on User.cpp en User.h. Misplaced lines can cause this error.

[DerHeiligeJesus]

System does not work for me. Compiled without problems, but get no buff if i reach the count.

[TestUrSkillz]

Hey there.
Can anyone send one line for the propItem entries ?

[matonskie23]

Originally Posted by TestUrSkillz

Hey there.
Can anyone send one line for the propItem entries ?

BUFF_ITEM
II_SYS_SYS_LS_CHEERING

[aoyamananami]

Originally Posted by Naltalah

Edit: The consensus of the feedback so far is, that this code is very performance inefficient. If I have the time, I will rewrite the code and reupdate.

I coded this for a friend and thought why not share it with everyone.

Disclaimer: I'm still kind of new to coding, so if you have any suggestions on how to improve the code, let me know <3

I won't be adding a guide on how to create the items that are used as the a buff, there are enough guides on that out there.

ProjectCmn.cpp

 Spoiler

before

PHP Code:

BOOL CProject::LoadJobItem(LPCTSTR lpszFilename) 


add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS
BOOL CProject::LoadOnlineCountFile(LPCTSTR lpszFilename)
{
    CScript script;
    if (script.Load(lpszFilename) == FALSE)
        return FALSE;
    script.GetToken();
    int nOnlineCount;
    DWORD dwBuffId;
    while (script.tok != FINISHED)
    {
        dwBuffId = atoi(script.Token);
        nOnlineCount = script.GetNumber();
        script.GetToken();
        m_aOnlineCountBuffs.insert(make_pair(nOnlineCount, dwBuffId));
    }
    return TRUE;
}
#endif // __SYS_ONLINECOUNT_BUFFS 


Project.cpp

 Spoiler

after:

PHP Code:

CTitleManager::Instance()->LoadTitle("honorList.txt"); 


add

PHP Code:

#if defined(__WORLDSERVER) && defined(__SYS_ONLINECOUNT_BUFFS)
    LoadOnlineCountFile("onlinebuff.inc");
#endif 


Project.h

 Spoiler

after

PHP Code:

void LoadSkill(); 


add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS
#ifdef __WORLDSERVER
    BOOL    LoadOnlineCountFile(LPCSTR lpszFilename);
    map<int, DWORD>    m_aOnlineCountBuffs;
#endif // __WORLDSERVER
#endif // __SYS_ONLINECOUNT_BUFFS 


User.h

 Spoiler

after:

PHP Code:

    void    SendNewRandomOption( unsigned char id, DWORD dwSerialNumber, __int64 n64NewRandomOption ); 


add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS
    const int        GetClosestCount();
    vector<int>        GetValidCounts();
    void            RemoveOnlineBuffs();
    void            ApplyOnlineBuff();
#endif 


User.cpp

 Spoiler

in CUser::Process()

after

PHP Code:

    if( IsLive() )
    { 


add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS
        this->ApplyOnlineBuff();
#endif // __SYS_ONLINECOUNT_BUFFS 


at the end of the file add this:

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS
const int CUser::GetClosestCount()
{
    int nNum = 0;
    for (auto it : prj.m_aOnlineCountBuffs)
    {
        if (g_UserMng.GetCount() >= it.first)
            nNum = it.first;
    }
    return nNum;
}
vector<int> CUser::GetValidCounts()
{
    vector<int> nValidBuffs;
    for (auto it : prj.m_aOnlineCountBuffs)
    {
        if (g_UserMng.GetCount() >= it.first)
            nValidBuffs.push_back(it.second);
    }

    return nValidBuffs;
}
void CUser::RemoveOnlineBuffs()
{
    vector<int> nValidBuffs = GetValidCounts();
    for (auto it : prj.m_aOnlineCountBuffs)
    {
        if (__SYS_ONLINECOUNT_BUFFS_MODE == 1)
        {
            auto vec_it = std::find(nValidBuffs.begin(),nValidBuffs.end(),it.second);
            if (HasBuff(BUFF_ITEM, it.second) && vec_it == nValidBuffs.end())
                this->RemoveBuff(BUFF_ITEM, it.second);
        } 
        else 
        {
            if (this->HasBuff(BUFF_ITEM, it.second) && GetClosestCount() != it.first)
                this->RemoveBuff(BUFF_ITEM, it.second);
        }
    }
}
void CUser::ApplyOnlineBuff()
{
    this->RemoveOnlineBuffs();

    if (__SYS_ONLINECOUNT_BUFFS_MODE == 1)
    {
        vector<int> nValidBuffs = GetValidCounts();
        for (auto it : nValidBuffs)
        {
            ItemProp* pProp = prj.GetItemProp(it);
            if (pProp && !HasBuff(BUFF_ITEM, it))
                DoApplySkill(this, pProp, NULL);
        }
        
    }
    else {
        int nCount = GetClosestCount();
        if (prj.m_aOnlineCountBuffs.find(nCount) == prj.m_aOnlineCountBuffs.end())
            return;

        ItemProp* pProp = prj.GetItemProp(prj.m_aOnlineCountBuffs.at(nCount));
        if (pProp && !HasBuff(BUFF_ITEM, pProp->dwID))
            DoApplySkill(this, pProp, NULL);
    }

}
#endif // __SYS_ONLINECOUNT_BUFFS 


VersionCommon.h (WorldServer)

add this:

PHP Code:

#define        __SYS_ONLINECOUNT_BUFFS
#ifdef __SYS_ONLINECOUNT_BUFFS
#define        __SYS_ONLINECOUNT_BUFFS_MODE    1    // 0 = Only highest buff will be active, 1 = All buffs will be active
#endif // __SYS_ONLINECOUNT_BUFFS 


Resource

You will need to create a new file called onlinebuff.inc.

It has to look like this:

PHP Code:

// dwBuffID                     Online Count
II_ONLINEBUFF_LEVEL1            10
II_ONLINEBUFF_LEVEL2            20 


First comes the ID of the buff, after that the amount of users that have to be online to apply this buff.

Please note that this does not work for multiple channels.

I also added these instruction as an attachment if you want to save it for later.

i do have get error in user.cpp

 Spoiler

User.cpp
User.cpp(10140) : error C2059: syntax error : ':'
User.cpp(10141) : error C2143: syntax error : missing ';' before '{'
User.cpp(10142) : error C2228: left of '.first' must have class/struct/union type
type is 'int'
User.cpp(10143) : error C2228: left of '.first' must have class/struct/union type
type is 'int'
User.cpp(10150) : error C2143: syntax error : missing ',' before ':'
User.cpp(10151) : error C2143: syntax error : missing ';' before '{'
User.cpp(10152) : error C2228: left of '.first' must have class/struct/union type
type is 'int'
User.cpp(10153) : error C2228: left of '.second' must have class/struct/union type
type is 'int'
User.cpp(10161) : error C2143: syntax error : missing ',' before ':'
User.cpp(10162) : error C2143: syntax error : missing ';' before '{'
User.cpp(10165) : error C2228: left of '.second' must have class/struct/union type
type is 'int'
User.cpp(10165) : error C2665: 'std::find' : none of the 3 overloads can convert parameter 1 from type 'std::vector<_Ty>::iterator'
with
[
_Ty=int
]
C:\Program Files (x86)\Microsoft Visual Studio .NET 2003\Vc7\include\algorithm(36): could be 'const char *std::find(const char *,const char *,int)'
C:\Program Files (x86)\Microsoft Visual Studio .NET 2003\Vc7\include\algorithm(42): or 'const signed char *std::find(const signed char *,const signed char *,int)'
C:\Program Files (x86)\Microsoft Visual Studio .NET 2003\Vc7\include\algorithm(50): or 'const unsigned char *std::find(const unsigned char *,const unsigned char *,int)'
while trying to match the argument list '<Unknown>'
with
[
_Ty=int
]
and
[
_Ty=int
]
User.cpp(10166) : error C2228: left of '.second' must have class/struct/union type
type is 'int'
User.cpp(10166) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'int' (or there is no acceptable conversion)
User.cpp(10167) : error C2228: left of '.second' must have class/struct/union type
type is 'int'
User.cpp(10171) : error C2228: left of '.second' must have class/struct/union type
type is 'int'
User.cpp(10171) : error C2228: left of '.first' must have class/struct/union type
type is 'int'
User.cpp(10172) : error C2228: left of '.second' must have class/struct/union type
type is 'int'
User.cpp(10183) : error C2143: syntax error : missing ',' before ':'
User.cpp(10184) : error C2143: syntax error : missing ';' before '{'

please help.

[foreks73]

Hello everybody!Help.where to define EventDrop.lua so that the server reads it, except for LuaFunc

[foreks73]

help please fix
1> User.cpp (11189): Warning C4244: Argument: Convert "DWORD" to "WORD", possible data loss
1> User.cpp (11190): warning C4244: argument: convert "DWORD" to "WORD", possible data loss
1> User.cpp (11194): warning C4244: argument: convert "DWORD" to "WORD", possible data loss
1> User.cpp (11195): warning C4244: argument: convert "DWORD" to "WORD", possible data loss
1> User.cpp (11220): Warning C4244: Argument: Convert "DWORD" to "WORD", possible data loss