Tutorial : DoAddBuff function upgrade

[FlyServices]

Hi, this tutorial aims to modify the DoAddBuff function in order to be able to choose the buff time. So, just copy and past the snippet in Ctrl.cpp/Ctrl.h

#ifdef __DO_ADD_BUFF
void CCtrl::DoAddBuff( DWORD dwSkill, int nLevel, int nTime, CCtrl *pTarget )
{
	if( pTarget )
	{
		ItemProp* pSkillProp;
		AddSkillProp* pAddSkillProp;
		GetSkillProp( &pSkillProp, &pAddSkillProp, dwSkill, nLevel, "DoActiveSkill" );
		
		if( pAddSkillProp )
		{
			DWORD dwSkillTime2 = pAddSkillProp->dwSkillTime;
			if( nTime && nTime > 0 )
			{
				nTime *= 1000;
				pAddSkillProp->dwSkillTime = nTime;
			}
			DoApplySkill( pTarget, pSkillProp, pAddSkillProp, 0, 0, FALSE, 0 );
#ifdef __WORLDSERVER        
			g_UserMng.AddDoApplySkill( this, pTarget->GetId(), dwSkill, nLevel );
#endif // __WORLDSERVER
			pAddSkillProp->dwSkillTime = dwSkillTime2;
		}
	}
}
#endif // __DO_ADD_BUFF

#ifdef __DO_ADD_BUFF
	void			DoAddBuff( DWORD dwSkill, int nLevel, int nTime, CCtrl *pTarget );
#endif // __DO_ADD_BUFF

Format example :

pUserTarget->DoAddBuff( SI_ASS_CHEER_CANNONBALL, 20, 3600, pUserTarget );

[Rhyder`]

Makesure pTarget must not be NULL include target check to avoid server crash

[Sedrika]

Originally Posted by Rhyder`

Makesure pTarget must not be NULL include target check to avoid server crash

First line in function: if (pTarget)

Also checking for nTime && nTime > 0 is the same.

[FlyServices]

Originally Posted by Sedrika

First line in function: if (pTarget)

Also checking for nTime && nTime > 0 is the same.

Time > 0 => if you put 0, the buff time depend your INT

[Mognakor]

Nobody noticing the obvious bug?

You modify your resource props, but never reset the value to the original one.

So either copy the original value into a temporal variable and modify the temporary variable, or reset the modified resource to the original one.

[FlyffServices]

if( nTime && nTime > 0 )

If nTime higher than 0 then its always true (if(ntime)). Why you double check it lol

its like

if( variable && variable => 1 && isset(variable) && variable == true)

looooooooooooooooooooooooooooooooooooooooooooooooo ooooooool

[FlyServices]

Originally Posted by FlyffServices

if( nTime && nTime > 0 )

If nTime higher than 0 then its always true (if(ntime)). Why you double check it lol

its like

if( variable && variable => 1 && isset(variable) && variable == true)

looooooooooooooooooooooooooooooooooooooooooooooooo ooooooool

Thank's Sedrika's parrot