[Snippet] Team Chat Color

[-Venom']

Hallo,

hier ein kleines Snippet, die Idee kam ursprünglich von Primal Flyff

In:

void CDPClient::OnChat( OBJID objid, CAr & ar )

Das:

sprintf(szChat, "%s : %s", pMover->GetName(TRUE), szBuf);
g_WndMng.PutString((LPCTSTR)szChat, pMover, 0xffffffff, CHATSTY_GENERAL);

Durch:

			if (pMover->m_dwAuthorization == AUTH_ADMINISTRATOR)
			{
				sprintf(szChat, "[Admin] %s : %s", pMover->GetName(TRUE), szBuf);
				g_WndMng.PutString((LPCTSTR)szChat, pMover, COLOR_ADMINISTRATOR, CHATSTY_GENERAL);
			}
			else if (pMover->m_dwAuthorization >= AUTH_GAMEMASTER)
			{
				sprintf(szChat, "[Gamemaster] %s : %s", pMover->GetName(TRUE), szBuf);
				g_WndMng.PutString((LPCTSTR)szChat, pMover, COLOR_GAMEMASTER, CHATSTY_GENERAL);
			}
			else 
			{
				sprintf(szChat, "%s : %s", pMover->GetName(TRUE), szBuf);
				g_WndMng.PutString((LPCTSTR)szChat, pMover, COLOR_PLAYER, CHATSTY_GENERAL);
			}

ersetzen.


Ergebnis:

[Sammyz]

Or "Color Only" in shout.

BOOL TextCmd_shout( CScanner& scanner )

#if __VER >= 12 // __LORD
	DWORD dwColor	= 0xffff99cc;
	if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
		dwColor		= 0xff00ff00;
	if (pUser->IsAuthHigher(AUTH_GAMEMASTER))
		dwColor		= COLOR_GAMEMASTER;
	arBlock << dwColor;
#endif	// __LORD

[direktbottle]

Originally Posted by Sammyz

Or "Color Only" in shout.

BOOL TextCmd_shout( CScanner& scanner )

#if __VER >= 12 // __LORD
	DWORD dwColor	= 0xffff99cc;
	if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
		dwColor		= 0xff00ff00;
	if (pUser->IsAuthHigher(AUTH_GAMEMASTER))
		dwColor		= COLOR_GAMEMASTER;
	arBlock << dwColor;
#endif	// __LORD

That code for GM / Admin shout color never worked for me. I have it exactly like that and it does nothing. I also tried "else if" but no different results.

[-Venom']

Originally Posted by direktbottle

That code for GM / Admin shout color never worked for me. I have it exactly like that and it does nothing. I also tried "else if" but no different results.

In 30minutes i can release the code for that.

[direktbottle]

Originally Posted by Gentros'

In 30minutes i can release the code for that.

Great!!

[xMeher]

It's sexier when the text isnt color

[direktbottle]

Originally Posted by xMeher

It's sexier when the text isnt color

Then don't use it.

Originally Posted by Gentros'

Thanks!

[Avalion]

Originally Posted by Gentros'

In:

void CDPClient::OnShout( CAr & ar )

Change this:

str.Format("[%s] %s", lpszPlayer, lpString);
g_WndMng.PutString(str, NULL, dwColor, CHATSTY_SHOUT);

to:

		if (pMover->m_dwAuthorization == AUTH_ADMINISTRATOR)
		{
			str.Format("[Admin Shout][%s] %s", lpszPlayer, lpString);
			g_WndMng.PutString(str, NULL, COLOR_ADMINISTRATOR, CHATSTY_SHOUT);
		}
		else if (pMover->m_dwAuthorization >= AUTH_GAMEMASTER)
		{
			str.Format("[Gamemaster Shout][%s] %s", lpszPlayer, lpString);
			g_WndMng.PutString(str, NULL, COLOR_GAMEMASTER, CHATSTY_SHOUT);
		}
		else
		{
			str.Format("[%s] %s", lpszPlayer, lpString);
			g_WndMng.PutString(str, NULL, dwColor, CHATSTY_SHOUT);
		}

The color and text will not apply for users too far / different maps because they wouldn't be in the client's memory still (GetMover() will be null).

If that is the case, your example would crash for accessing a null pointer, and if you checked if the pointer wasn't null and the object was real, it would still be incorrect text during certain scenarios like I stated.


Edit:
Furthermore, the example provided by Sammyz should be working, as it sends a different color into the packet information, which is being read on the client. You can even detect to add a tag for auth based on sending another variable, preferably a byte and then handle the data on the client. But, if you're doing it that way, you can also remove sending a color and just use a numeric byte scale, which increases options. Whatever is more preferable to whoever is doing it for themselves.

[-Venom']

Originally Posted by Avalion

The color and text will not apply for users too far / different maps because they wouldn't be in the client's memory still (GetMover() will be null).

If that is the case, your example would crash for accessing a null pointer, and if you checked if the pointer wasn't null and the object was real, it would still be incorrect text during certain scenarios like I stated.


Edit:
Furthermore, the example provided by Sammyz should be working, as it sends a different color into the packet information, which is being read on the client. You can even detect to add a tag for auth based on sending another variable, preferably a byte and then handle the data on the client. But, if you're doing it that way, you can also remove sending a color and just use a numeric byte scale, which increases options. Whatever is more preferable to whoever is doing it for themselves.

Oh i have see it.
I will fix it in the next minutes.

Originally Posted by direktbottle

That code for GM / Admin shout color never worked for me. I have it exactly like that and it does nothing. I also tried "else if" but no different results.

Originally Posted by Sammyz

Or "Color Only" in shout.

BOOL TextCmd_shout( CScanner& scanner )

#if __VER >= 12 // __LORD
	DWORD dwColor	= 0xffff99cc;
	if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
		dwColor		= 0xff00ff00;
	if (pUser->IsAuthHigher(AUTH_GAMEMASTER))
		dwColor		= COLOR_GAMEMASTER;
	arBlock << dwColor;
#endif	// __LORD

I have make it so. It works

#if __VER >= 12 // __LORD
	DWORD dwColor = 0xffff99cc;
	if(pUser->m_dwAuthorization == AUTH_ADMINISTRATOR)
	{
		dwColor = COLOR_ADMINISTRATOR;
	}
	else if (pUser->m_dwAuthorization >= AUTH_GAMEMASTER)
	{
		dwColor = COLOR_GAMEMASTER;
	}
	

if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
		{
			dwColor		= 0xff00ff00;
		}
	arBlock << dwColor;
#endif	// __LORD

[direktbottle]

That works great, but now we don't have the [GM] tags in shout anymore, unless you use the other script which Avalion said could cause crashes.

#if __VER >= 12 //__LORD
	DWORD dwColor	= 0xffff99cc;
	if(pUser->m_dwAuthorization >= AUTH_GAMEMASTER)
	{
		dwColor = 0xff00ff00;
	}
	if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
	{
		dwColor = 0xff00ff00;
	}
#ifdef __PREMIUM_STATUS
	else if( pUser->IsSMMode( SM_PREMIUM) )
	{
		dwColor = COLOR_PREMIUM;
	}
#endif //__PREMIUM_STATUS
	arBlock << dwColor;
#endif	//__LORD

Can anyone help me modify this code so it will display the GAMEMASTER color if you are GAMEMASTER and PREMIUM? Right now it will always take premium color first even if you are GM.

[-Venom']

Tomorrow i will add the tags

[Avalion]

This is another way of doing it.
BOOL TextCmd_shout(CScanner &scanner)

	unsigned long dwColor = pUser->m_dwAuthorization;
	if (pUser->HasBuff(BUFF_ITEM, II_SYS_SYS_LS_SHOUT) && !pUser->m_dwAuthorization > AUTH_GENERAL)
		dwColor = 1;

	arBlock << dwColor;

void CDPClient::OnShout(CAr &ar)

	CString str;
	switch (dwColor)
	{
		case AUTH_ADMINISTRATOR:
			str.Format("[Admin][%s] : %s", lpszPlayer, lpString);
			dwColor = COLOR_ADMINISTRATOR;
			break;
		case AUTH_OPERATOR:
			str.Format("[GM][%s] : %s", lpszPlayer, lpString);
			dwColor = COLOR_GAMEMASTER;
			break;
		case AUTH_GAMEMASTER2:
		case AUTH_GAMEMASTER:
			str.Format("[Event GM][%s] : %s", lpszPlayer, lpString);
			dwColor = COLOR_EVENTGAMEMASTER;
			break;
		case 1:
			str.Format("[%s] : %s", lpszPlayer, lpString);
			dwColor = 0xff00ff00;
			break;
		default:
			str.Format("[%s] : %s", lpszPlayer, lpString);
			dwColor = 	0xffefab59;
			break;
		}
	}
	g_WndMng.PutString(str, NULL, COLOR_ADMINISTRATOR, CHATSTY_SHOUT);

You can even start doing some crazy stuff, like if you wanted the shout color to change with lordbuff but with the admin tag prepended, you can start using a binary flag inside the variable. Even though Auth levels are stored as a DWORD, they are stored using letters (ascii to dec), so they never really pass the size of a byte, nor would one have that many auth levels.

	unsigned long dwColor = pUser->m_dwAuthorization;
	if (pUser->HasBuff(BUFF_ITEM, II_SYS_SYS_LS_SHOUT))
		dwColor = 0x100 | dwColor;
	if (pUser->isVip() && !pUser->m_dwAuthorization > AUTH_GENERAL)
		dwColor = 0x200 | dwColor;
	
	arBlock << dwColor;

	bool hasLord = false, hasVip = false;
	if (dwColor & 0x100)
	{
		hasLord = true;
		dwColor = dwColor &~0x100;
	}
	if (dwColor & 0x200)
	{
		hasVip = true;
		dwColor = dwColor &~0x200;
	}
	
	switch (dwColor)
	{
		case AUTH_ADMINISTRATOR:
			str.Format("[Admin][%s] : %s", lpszPlayer, lpString);
			dwColor = hasLord ? 0xff00ff00 : COLOR_ADMINISTRATOR;
			break;
		case AUTH_OPERATOR:
			str.Format("[GM][%s] : %s", lpszPlayer, lpString);
			dwColor = hasLord ? 0xff00ff00 : COLOR_GAMEMASTER;
			break;
		case AUTH_GAMEMASTER2:
		case AUTH_GAMEMASTER:
			str.Format("[Event GM][%s] : %s", lpszPlayer, lpString);
			dwColor = hasLord ? 0xff00ff00 : COLOR_EVENTGAMEMASTER;
			break;
		default:
			if (hasVip)
			{
				str.Format("[%s] : %s", lpszPlayer, lpString);
				dwColor = 	hasLord ? 0xff00ff00 : COLOR_VIP;
			}
			else
			{
				str.Format("[%s] : %s", lpszPlayer, lpString);
				dwColor = 	hasLord ? 0xff00ff00 : 0xffefab59;
			}
			break;
		}
	}

These are all rough examples on what you can do. If you expect to have loads of Auths with the same information, would probably be better to use like if (auth >= admin) etc. Also, excuse me if I messed up the bitwise operations.




-------------------------------------------------------------------------

Originally Posted by direktbottle

That works great, but now we don't have the [GM] tags in shout anymore, unless you use the other script which Avalion said could cause crashes.

#if __VER >= 12 //__LORD
	DWORD dwColor	= 0xffff99cc;
	if(pUser->m_dwAuthorization >= AUTH_GAMEMASTER)
	{
		dwColor = 0xff00ff00;
	}
	if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
	{
		dwColor = 0xff00ff00;
	}
#ifdef __PREMIUM_STATUS
	else if( pUser->IsSMMode( SM_PREMIUM) )
	{
		dwColor = COLOR_PREMIUM;
	}
#endif //__PREMIUM_STATUS
	arBlock << dwColor;
#endif	//__LORD

Can anyone help me modify this code so it will display the GAMEMASTER color if you are GAMEMASTER and PREMIUM? Right now it will always take premium color first even if you are GM.

	ELSE if( pUser->HasBuff(  BUFF_ITEM, II_SYS_SYS_LS_SHOUT ) )
	{
		dwColor = 0xff00ff00;
	}

add this else and it should take the first if statement that applies to the user. IE: Auth Color > Lord Color > Premium color.

[direktbottle]

While we're working on shout, I figured I'd try this thing where premium and GMs+ have Full Shout automatically.

BOOL CMover::IsShoutFull( void )
{
	return	( IsSMMode( SM_SHOUT15 ) || IsSMMode( SM_SHOUT30 ) || IsSMMode( SM_SHOUT001 ) || IsSMMode( IsAuthHigher( AUTH_GAMEMASTER) )
#ifdef __PREMIUM_STATUS
	|| IsSMMode( SM_PREMIUM )
#endif //__PREMIUM_STATUS
	);
}

But it only works for Premium, not Gamemasters+. Something is missing I guess

[kevinkraus]

Originally Posted by direktbottle

While we're working on shout, I figured I'd try this thing where premium and GMs+ have Full Shout automatically.

BOOL CMover::IsShoutFull( void )
{
	return	( IsSMMode( SM_SHOUT15 ) || IsSMMode( SM_SHOUT30 ) || IsSMMode( SM_SHOUT001 ) || IsSMMode( IsAuthHigher( AUTH_GAMEMASTER) )
#ifdef __PREMIUM_STATUS
	|| IsSMMode( SM_PREMIUM )
#endif //__PREMIUM_STATUS
	);
}

But it only works for Premium, not Gamemasters+. Something is missing I guess

Change this:

BOOL CMover::IsShoutFull( void )
{
	return	( IsSMMode( SM_SHOUT15 ) || IsSMMode( SM_SHOUT30 ) || IsSMMode( SM_SHOUT001 ) || IsSMMode( IsAuthHigher( AUTH_GAMEMASTER) )
#ifdef __PREMIUM_STATUS
	|| IsSMMode( SM_PREMIUM )
#endif //__PREMIUM_STATUS
	);
}

to:

BOOL CMover::IsShoutFull( void )
{
	return	( IsSMMode( SM_SHOUT15 ) || IsSMMode( SM_SHOUT30 ) || IsSMMode( SM_SHOUT001 ) || IsAuthHigher( AUTH_GAMEMASTER )
#ifdef __PREMIUM_STATUS
	|| IsSMMode( SM_PREMIUM )
#endif //__PREMIUM_STATUS
	);
}

and it should work for Gamemasters+ too.

- Kevin

[direktbottle]

Oh yeah, you're right. I'll try!