[BugFix] Check Tax Display

[Pumaaa]

In function

CWndSecretRoomChangeTaxRate::SetDefaultTax

Replace

m_nDefaultPurchaseTax	= (int)( CTax::GetInstance()->GetSalesTaxRate( nCont ) * 100 );

with

m_nDefaultPurchaseTax	= (int)( CTax::GetInstance()->GetPurchaseTaxRate( nCont ) * 100 );

[Wanetrain]

Originally Posted by Pumaaa

In function

CWndSecretRoomChangeTaxRate::SetDefaultTax

Replace

m_nDefaultPurchaseTax	= (int)( CTax::GetInstance()->GetSalesTaxRate( nCont ) * 100 );

with

m_nDefaultPurchaseTax	= (int)( CTax::GetInstance()->GetPurchaseTaxRate( nCont ) * 100 );

Bittttttteeeeeee

m_nDefaultPurchaseTax = static_cast< int >( CTax::GetInstance()->GetPurchaseTaxRate( nCount ) * 100 );

#ThingsEpvpDoes

[死神先生]

Originally Posted by Wanetrain

Bittttttteeeeeee



#ThingsEpvpDoes

Kannst du das erklären?

M.E. ist ein C-Style Cast valides C++.

[Blouflash]

Originally Posted by 死神先生

Kannst du das erklären?

M.E. ist ein C-Style Cast valides C++.

• static_cast<>() gives you a compile time checking ability, C-Style cast doesn't.
• static_cast<>() is more readable and can be spotted easily anywhere inside a C++ source code, C_Style cast is'nt.
• Intentions are conveyed much better using C++ casts.

[死神先生]

Originally Posted by Blouflash

• static_cast<>() gives you a compile time checking ability, C-Style cast doesn't.
• static_cast<>() is more readable and can be spotted easily anywhere inside a C++ source code, C_Style cast is'nt.
• Intentions are conveyed much better using C++ casts.

Why do I need compile time checks for numeric casts? It won't cause runtime issues anyway.
That's a matter of opinion
That's a matter of opinion

[macboyem07]

after killing lucifer I change the tax but the tax not saving and also the occupied guild..

[Sedrika]

Your title says you're a developer so look for yourself

[Pumaaa]

Originally Posted by macboyem07

after killing lucifer I change the tax but the tax not saving and also the occupied guild..

Taxes are applied only when the LUA function succeeds the time check or a GM executes /tan. Which is only available if you enabled commands beyond /open for all languages not only korean.

[Pumaaa]

Originally Posted by Wanetrain

Bittttttteeeeeee



#ThingsEpvpDoes

The return value and the tax value itself is a float and shouldn't be displayed as integer anyway. So best practice would be to rewrite the window to display the correct value.

But for a matter of simplicity i just included the basic "fix" so people can implement it without having to worry about further aspects.

Wether you use a C-Style cast or static is quite irrelevant here, the code design is still bad.

EDIT:
FML double post

[Mognakor]

Originally Posted by Pumaaa

The return value and the tax value itself is a float and shouldn't be displayed as integer anyway. So best practice would be to rewrite the window to display the correct value.

Unless you can set the tax rate to the fraction of a percent, it doesn't matter if it's integer or float.