Upgrade System :(

[khemomo]

I'am having a problem with my Pierce or Upgrade system
every time So I've tried to Upgrade my weapons and Earings/Rings

but I've done using a lot of moonstone but the success rate is so low
Here's the capture image.

 Spoiler

Here's my s.txt from my resorce

 Spoiler

Accessory_Probability
{
10000 // 0 - 1
10000 // 1 - 2
10000 // 2 - 3
10000 // 3 - 4
10000 // 4 - 5
10000 // 5 - 6
10000 // 6 - 7
10000 // 7 - 8
10000 // 8 - 9
10000 // 9 - 10
10000 // 10 - 11
10000 // 11 - 12
10000 // 12 - 13
10000 // 13 - 14
10000 // 14 - 15
10000 // 15 - 16
10000 // 16 - 17
10000 // 17 - 18
10000 // 18 - 19
10000 // 19 - 20
}

Collecting_Enchant
{
1000 // 0
1000 // 1
750 // 2
500 // 3
250 // 4
}
Collecting_Item
{
II_SYS_SYS_SCR_MACARONINDIGO 100000000
II_SYS_SYS_SCR_MACARONAZALEA 100000000
II_SYS_SYS_SCR_MACARONYGREEN 100000000
II_SYS_SYS_SCR_MACARONREDBEAN 100000000
II_SYS_SYS_SCR_MACARONGOLD 100000000
}

// pet.inc
Pet_LevelupAvail // ·¹º§¾÷¿¡ ÀÇÇÑ ´É·ÂÄ¡ »ó½Â È®·ü
{
// 1 2 3 4 5 6 7 8 9
10000 0 0 0 0 0 0 0 0
0 0 10000 0 0 0 0 0 0
0 0 0 0 10000 0 0 0 0
0 0 0 0 0 0 10000 0 0
0 0 0 0 0 0 0 0 10000
}

Pet_AddLifeProbability // ¼ö¸í ȸº¹¾× È®·ü // Ãß°¡ µÉ °æ¿ì ÇÕÀÌ 100ÀÌ µÇµµ·Ï È®Àå
{
0 // +1
0 // +2
0 // +3
0 // +4
100 // +5
}

And about the Jewel Setting so Im Done upgrading my Ultimate weapon to +10 then I tried to put a jewel on it but the available jewel can be put is only 1 and We know that should be 5 jewel because the item is alread +10.

here's the picture

 Spoiler

please help me how to fix this

[raventh1984]

1. Did you added the s.txt to your resource files client sided?
2. What source are you using.

I have tried several sources that i have and none of them are having those bugs!.

[khemomo]

Originally Posted by raventh1984

1. Did you added the s.txt to your resource files client sided?
2. What source are you using.

I have tried several sources that i have and none of them are having those bugs!.

what do you mean by adding the s.txt in the client side should i copy the s.txt to my client or you mean Merge it then copy the datas to the client? if merge yes I'am sure that I merge the resource and put it in my client.

I think this source is GOH?

[raventh1984]

Yes you need to merge the data.
However you also can copy the s.txt file directly into your Client dir. So it loads that first instead of the one in the .res file.

Ok i have tested the Goh files my self i dont have any problems with upgrading accessory.

Do you have v19 params? if so show me these snippets

BYTE	CItemUpgrade::OnSmeltSafety( CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr, CItemElem* pItemSmeltScr )

And

BYTE	CItemUpgrade::SmeltSafetyAccessory(CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr )

Also from your spec_item the row of the moonstone.
II_GEN_MAT_MOONSTONE

[Nortix]

Tell me one reason why s.txt should be in the client

[raventh1984]

Cause i thought it should be in Client.
But its not haha. I just woke up when i wrote that.

[khemomo]

Originally Posted by raventh1984

Yes you need to merge the data.
However you also can copy the s.txt file directly into your Client dir. So it loads that first instead of the one in the .res file.

Ok i have tested the Goh files my self i dont have any problems with upgrading accessory.

Do you have v19 params? if so show me these snippets

BYTE	CItemUpgrade::OnSmeltSafety( CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr, CItemElem* pItemSmeltScr )

And

BYTE	CItemUpgrade::SmeltSafetyAccessory(CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr )

Also from your spec_item the row of the moonstone.
II_GEN_MAT_MOONSTONE

Yup I think i have a v19 param.

I think this is what you need from the ItemUpgrade.cpp?

 Spoiler

#if __VER >= 14 // __SMELT_SAFETY
BYTE CItemUpgrade::OnSmeltSafety( CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr, CItemElem* pItemSmeltScr )
{
#ifdef __NEW_ITEM_VARUNA
if( pItemMain->GetProp()->dwReferStat1 >= BARUNA_D && pItemMain->GetProp()->dwReferStat1 <= BARUNA_S )
{
return 0;
}
#endif // __NEW_ITEM_VARUNA
// 재료에 따라 분기
switch( pItemMaterial->GetProp()->dwItemKind3 )
{
// 오리칼쿰일때
case IK3_ENCHANT:

#if __VER >= 19
case IK3_SMELT_ULTIMATE_MATERIAL:
case IK3_SMELT_GENERAL_MATERIAL:
#endif

// 일반제련(일반 or 얼터멋웨폰인지 재검사)
return SmeltSafetyNormal( pUser, pItemMain, pItemMaterial, pItemProtScr, pItemSmeltScr );

// 문스톤일때
case IK3_PIERDICE:

#if __VER >= 19
case IK3_SMELT_ACCESSORY_MATERIAL:
#endif

// 악세서리인가
if( pItemMain->IsAccessory() )
return SmeltSafetyAccessory( pUser, pItemMain, pItemMaterial, pItemProtScr );
// 피어싱인가
else if( pItemMain->IsPierceAble( NULL_ID, TRUE ) )
return SmeltSafetyPiercingSize( pUser, pItemMain, pItemMaterial, pItemProtScr );

#if __VER >= 15 // __15_5TH_ELEMENTAL_SMELT_SAFETY
// 속성카드 일때
case IK3_ELECARD:
return SmeltSafetyAttribute( pUser, pItemMain, pItemMaterial, pItemProtScr, pItemSmeltScr );
#endif // __15_5TH_ELEMENTAL_SMELT_SAFETY

default:
break;
}
return 0;
}

BYTE CItemUpgrade::SmeltSafetyNormal( CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr, CItemElem* pItemSmeltScr )
{

// 오리칼쿰인가, 빛나는 오리칼쿰인가
switch( pItemMaterial->GetProp()->dwID )
{
// 오리칼쿰일때 일반제련
case II_GEN_MAT_ORICHALCUM01:
case II_GEN_MAT_ORICHALCUM01_1:
return SmeltSafetyGeneral( pUser, pItemMain, pItemMaterial, pItemProtScr, pItemSmeltScr );

// 빛나는 오리칼쿰일때 얼터멋웨폰 제련
case II_GEN_MAT_ORICHALCUM02:
return prj.m_UltimateWeapon.SmeltSafetyUltimate( pUser, pItemMain, pItemMaterial, pItemProtScr );

default:
break;
}
return 0;
}

BYTE CItemUpgrade::SmeltSafetyGeneral( CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr, CItemElem* pItemSmeltScr )
{
// 제련가능한 아이템이 아닐경우 리턴
if( !CItemElem::IsDiceRefineryAble(pItemMain->GetProp()) )
{
//pUser->AddDefinedText( TID_GAME_NOTEQUALITEM );
return 0;
}

// 얼터멋웨폰 이거나 일반보호의 두루마리가 아닐경우 리턴
if( pItemMain->GetProp()->dwReferStat1 == WEAPON_ULTIMATE || pItemProtScr->GetProp()->dwID != II_SYS_SYS_SCR_SMELPROT )
{
//pUser->AddDefinedText( TID_GAME_NOTEQUALITEM );
return 0;
}

#ifdef __NEW_ITEM_VARUNA
if( pItemMain->GetProp()->dwReferStat1 >= BARUNA_D && pItemMain->GetProp()->dwReferStat1 <= BARUNA_S )
{
return 0;
}
#endif // __NEW_ITEM_VARUNA

 Spoiler

BYTE CItemUpgrade::SmeltSafetyAccessory(CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr )
{
// 재료가 문스톤인가?
if( pItemMaterial->GetProp()->dwID != II_GEN_MAT_MOONSTONE && pItemMaterial->GetProp()->dwID != II_GEN_MAT_MOONSTONE_1 )
{
//pUser->AddDefinedText( TID_GAME_NOTEQUALITEM );
return 0;
}
// 악세서리 보호의 두루마리가 아닐경우 리턴
if( pItemProtScr->GetProp()->dwID != II_SYS_SYS_SCR_SMELPROT4 )
{
//pUser->AddDefinedText( TID_GAME_NOTEQUALITEM );
return 0;
}
// 제련수치가 max치를 넘었을때 리턴
if( pItemMain->GetAbilityOption() >= MAX_AAO ) // 20
{
//pUser->AddDefinedText( TID_GAME_ACCESSORY_MAX_AAO );
return 3;
}

// log
LogItemInfo aLogItem;
aLogItem.SendName = pUser->GetName();
aLogItem.RecvName = "UPGRADEITEM_SMELTSAFETY";
aLogItem.WorldId = pUser->GetWorld()->GetID();
aLogItem.Gold = pUser->GetGold();
aLogItem.Gold2 = pUser->GetGold();

aLogItem.Action = "N";
g_DPSrvr.OnLogItem( aLogItem, pItemMaterial, pItemMaterial->m_nItemNum );
pUser->RemoveItem( (BYTE)( pItemMaterial->m_dwObjId ), 1 );
// 액세서리 보호의 두루마리 로그 남길것
ItemProp* pItemProp = pItemProtScr->GetProp();
if( pItemProp )
{
g_dpDBClient.SendLogSMItemUse( "1", pUser, pItemProtScr, pItemProp );
g_dpDBClient.SendLogSMItemUse( "2", pUser, NULL, pItemProp );
}
pUser->RemoveItem( (BYTE)( pItemProtScr->m_dwObjId ), 1 );

// 제련 확률
DWORD dwProbability = CAccessoryProperty::GetInstance()->GetProbability( pItemMain->GetAbilityOption() );

if( xRandom( 10000 ) > dwProbability ) // 실패
{
pUser->AddPlaySound( SND_INF_UPGRADEFAIL );
if( pUser->IsMode( TRANSPARENT_MODE ) == 0 )
g_UserMng.AddCreateSfxObj( (CMover *)pUser, XI_INT_FAIL, pUser->GetPos().x, pUser->GetPos().y, pUser->GetPos().z );

aLogItem.Action = "L";
g_DPSrvr.OnLogItem( aLogItem, pItemMain, pItemMain->m_nItemNum );

return 2;
}
else // 성공
{
pUser->AddPlaySound( SND_INF_UPGRADESUCCESS );

if( pUser->IsMode( TRANSPARENT_MODE ) == 0)
g_UserMng.AddCreateSfxObj( (CMover *)pUser, XI_INT_SUCCESS, pUser->GetPos().x, pUser->GetPos().y, pUser->GetPos().z);

pUser->UpdateItem( (BYTE)pItemMain->m_dwObjId, UI_AO, pItemMain->GetAbilityOption()+1 );

aLogItem.Action = "H";
g_DPSrvr.OnLogItem( aLogItem, pItemMain, pItemMain->m_nItemNum );

return 1;
}
return 0;
}

BYTE CItemUpgrade::SmeltSafetyPiercingSize(CUser* pUser, CItemElem* pItemMain, CItemElem* pItemMaterial, CItemElem* pItemProtScr )
{
// 재료가 문스톤인가?
if( pItemMaterial->GetProp()->dwID != II_GEN_MAT_MOONSTONE && pItemMaterial->GetProp()->dwID != II_GEN_MAT_MOONSTONE_1 )
{
//pUser->AddDefinedText( TID_GAME_NOTEQUALITEM );
return 0;
}
// 피어싱 보호의 두루마리인가
if( pItemProtScr->m_dwItemId != II_SYS_SYS_SCR_PIEPROT )
{
//pUser->AddDefinedText( TID_SBEVE_NOTUSEITEM ); // 상용아이템이 아니면 불가능
return 0;
}
#ifdef __NEW_ITEM_VARUNA
if( pItemMain->GetProp()->dwReferStat1 >= BARUNA_D && pItemMain->GetProp()->dwReferStat1 <= BARUNA_S )
{
return 0;
}
#endif // __NEW_ITEM_VARUNA

Spec_item

 Spoiler

7 II_GEN_MAT_MOONSTONE IDS_PROPITEM_TXT_008066 1 9999 IK1_GENERAL IK2_MATERIAL IK3_PIERDICE = TRUE = = 1000000 = = = = = = = 0 = = 4 50 = 4 = = = = = _NONE = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = 0 0 0 0 0 = = = SND_ITEM_DROPDING1 = = = = = = = = = 1 = = = """Itm_GenMatMoonstone.dds""" 0 """""" IDS_PROPITEM_TXT_008067 1 300 0 0 1 0 0 0 0 0 2 = = = = = = = = = = 1 1 1 1 1 0

Mdlyna

 Spoiler

"GenMatMoonstone" II_GEN_MAT_MOONSTONE MODELTYPE_MESH "" 0 MD_NEAR 0 1.0f 0 1 ATEX_NONE 1

I noticed that some of "#if __VER >= 19" has been close by putting
" /* " so I've tried to search for more " #if __VER >= 19 " then open it I got the problem Undeclared Identifier for " IK3_SMELT_ULTIMATE_MATERIAL " and " IK3_SMELT_ULTIMATE_MATERIAL " and " IK3_SMELT_ACCESSORY_MATERIAL" but when I'am done compiling with no errors then now I will going to merge it and put it in my Client but when I enter in the world My neuz close automatically.

hope you can help me with this problem. thank you for your reply I really appreciate it

[khemomo]

bump please help me