Fashion Combination Success rate

[raventh1984]

Hi elitepvpers,

I am currently working an the Fashion Combination system and i want the success rate to be low. How ever if i change the

nFashionCombineChance = 10000 //100%
to
nFashionCombineChange = 100 //1%

It doesnt work every combination i do is an success.
Is there something inside the source that i have to change?

Cause i have also seen this

PHP Code:

if( xRandom( 10000 ) < 10000 )
        {        
            int nResult = 0;
            nResult = g_xRandomOptionProperty->MergeRandomOption( pItemElem[0], pItemElem[1] );
            nResult += g_xRandomOptionProperty->MergeRandomOption( pItemElem[2], pItemElem[3] );
            nResult += g_xRandomOptionProperty->MergeRandomOption( pItemElem[4], pItemElem[5] );
            nResult += g_xRandomOptionProperty->MergeRandomOption( pItemElem[6], pItemElem[7] );
            if( nResult > 0 )
            {
                Error( "packet editor detected. tried to combine more then 3 awakening on one item. User: %s", pUser->GetName() );
            }
            for( int i = 1; i < 8; i += 2 )
            {
                pUser->UpdateItem( (BYTE)pItemElem[i]->m_dwObjId, UI_NUM, 0 );
            }
            for( int i = 0; i < 8; i += 2 )
            {
                pUser->UpdateItemEx( (BYTE)( pItemElem[i]->m_dwObjId ), UI_RANDOMOPTITEMID, pItemElem[i]->GetRandomOptItemId() );
            }

            pUser->AddDefinedText( TID_COSTUME_COSTUMEMIXCOMPLETE );
        }
                else
                {
                   //FAIL CODE
                } 


It looks to me that it will always succeed cause its an 100% and if its lower then 10000 it still succeeds in this am i correct and do i need to change the xRandom?

With kind regards

[Mognakor]

xRandom returns a random number between 1 (or mby 0) and the given number.

In your case it is 10000.

1% of 10000 is 10.

if(xRandom(10000)<10)
...

[Velmore]

Originally Posted by Mognakor

xRandom returns a random number between 1 (or mby 0) and the given number.

In your case it is 10000.

1% of 10000 is 10.

if(xRandom(10000)<10)
...

Use my ItemUpgrade.cpp then you can change the chance in ItemUpgrade.lua

nFashionCombineChance = 2500

[raventh1984]

With you ItemUpgrade.cpp i have more an lot of more fixes to do then with my own itemupgrade. You are reffering to your topic for the fixes of the itemupgrade however i never had errors in my itemupgrade.

However i have fixed it on an other way that is also good for my.

So i will thank you both and this can be closed.

[Reavern]

#closed