[Help] register.php

Knight^Hawk · 04/04/2010, 23:55

why would my register script not insert the ip of the registured user. this and one more thing stats.php is preventing me from opening =/

Spoiler

Code:

<? 
require("config.php");
?>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<script type="text/javascript" src="./inc/md5.js"></script>
<style type="text/css">
</style></head>
<DIV align="center"><b class="h2">
</b>
<br />
<table width="299" height="22" border="0" align="center">
  <tr>

  </tr>
</table>
<br />
<form method='post' action='register.php?act=register'>
      <TABLE width="312">
        <TBODY>
        <TR>
          <TD id=GoodStuff style="PADDING-LEFT: 0px; MARGIN-LEFT: 0px">
            <DIV id=theform style="PADDING-LEFT: 0px">
            <TABLE class=body width="323" height="229">
              <TBODY>
              <TR>
                <TD align="left" height="32">UserID:</TD>
                <TD class=it3 height="32">
				<INPUT class=it style="FONT-SIZE: 9pt" name="id" id="id">				</TR>
              <TR>
                <TD align="left" height="37">Password:</TD>
                <TD class=it3 height="37">
				<INPUT class=it id="ipassword" style="FONT-SIZE: 9pt" type=password maxLength=12 name=pass></TD>
                </TR>
              <TR>
                <TD align="left" height="32">Retype Password:</TD>
                <TD class=it3 height="32">
				<input class=it1 id="ipassword" style="FONT-SIZE: 9pt" type=password maxlength=12 name=retpass></TD>
                </TR>
              <TR>
                <TD align="left" height="32">Type Check Code:</TD>
                <TD class=it3 height="32">
					<input name='CheckCode' size='20' maxlength='6'class=it style="FONT-SIZE: 9pt"></TD>
                </TR>
              <TR>
                <TD height="25" align="left">Check Code:</TD>
                <TD height="25"><span style="font-size: 9pt"><img src='./inc/img.php' width='200' height='60' alt='Visual CAPTCHA' 
  style='border: 1px solid #000000; padding: 2px;' /></TD></TR>
              <TR>
                <TD></TD>
                <TD style="FONT-SIZE: 14px; VERTICAL-ALIGN: middle">
				<span style="font-size: 9pt"><input type="hidden" name="hash"><input class=Butt type=submit onclick="hash.value = login(pass.value)" value='Register' name=B1></span></TD>
                </TR></TBODY></TABLE>
            </DIV></TD></TR></TBODY></TABLE></FORM>
			<center>
			<?php
			if($_GET['act'] == "register")
			{
				if(PhpCaptcha::Validate($_POST['CheckCode']))
				{
					mysql_select_db($mydbacc);
					$userid = trim($_POST['id']);
					$password=trim($_POST['pass']);
					$passretype=trim($_POST['retpass']);
					$hash=$_POST['hash'];
					if(!ereg("^[0-9a-z]{4,12}$",$userid))
					{
						echo "Only letters from \"a\" to \"z\" and numbers, lenght of 4 to 12 characters";
					}
					else
					{
						if($password == $passretype)
						{
							if(!ereg("^[0-9a-zA-Z]{4,12}$",$password))
							{
								echo "Only letters or numbers, lenght of 4 to 12 characters";
							}
							else
							{
								$res = mysql_query("select * from account where name = '".$userid."' order by id desc");
								if(mysql_num_rows($res) == 0)
								{
									mysql_query("insert into account (name,Password,Reg_date) values ('".$userid."','".$hash."','".date("y-m-d H:i:s", time())."')");
									echo "Account registered successfully.";
								}
								else
								{
									echo "Account Already exists in database.";
								}
							}
						}
						else
						{
							echo "Password not equal to Retyped Password.";
						}
					}
				}
				else
				{
					echo "Check Code is Wrong";
				}
			}
			?>
			</center>

.Ash · 04/05/2010, 01:04

i thought you got someone to help you...?

PraDevil[ELITE] · 04/05/2010, 01:12

that was nothing to do with main register page

go to register.php in pages folder..edit from there..

if i remember this the code to get the ip..

Code:

$SERVER[REMOTE_HOST]

Knight^Hawk · 04/05/2010, 04:27

Quote:

Originally Posted by SpongeBox

i thought you got someone to help you...?

i did but he only knew how to set it up. hes learning himself.

Quote:
Originally Posted by PraDevil
that was nothing to do with main register page
go to register.php in pages folder..edit from there..

if i remember this the code to get the ip..
Code:
$SERVER[REMOTE_HOST]

where do i put this? on what line?

Knight^Hawk · 04/05/2010, 08:01

i get this error when i put $SERVER[REMOTE_HOST]

Code:

Parse error: syntax error, unexpected T_IF in /home/knight/public_html/pages/register.php  on line 69

fixed first post aswell...

PraDevil[ELITE] · 04/05/2010, 08:04

put your register.php in pages folder here..

King_Arthur · 04/05/2010, 16:01

@Knight^Hawk I can see you know how to use the edit button. So I must ask you to discontinue double posting. If no one makes a reply to your post you must edit it to add additional information, not make a post after it.

Quote:

Originally Posted by Knight^Hawk

why would my register script not insert the ip of the registured user.

Your register script would not insert the ip of the registered user if your register script never asks for the ip or passes it along to mysql.

Quote:
Originally Posted by Knight^Hawk
i get this error when i put $SERVER[REMOTE_HOST]
Code:
Parse error: syntax error, unexpected T_IF in /home/knight/public_html/pages/register.php  on line 69
fixed first post aswell...

I don't see "$SERVER[REMOTE_HOST]" in the first post spoiler.

It's been a long time since I've done anything in PHP but I assume it would look something like below.
FOR REFERENCE ONLY!

Spoiler

PraDevil[ELITE] · 04/05/2010, 17:15

huhu..im not sure if u like register page without capcha..u can take my register.php then put in pages folder..u can see what are im modified here..learn with it how to add email..php is fun

after u put the new register.php then u will need to design your database account table..go to netbar_ip column then set default to EMPTY STRING

Code:

<?php
include('config.php');
?>
<script type="text/javascript" src="./inc/md5.js"></script>
<form method='post' action='register.php?act=register'>
<b><strong>Please make sure you remember your Account ID and Password</strong></b><hr>
<tr><td><table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr><td width="64" valign="top"></td>
<td valign="top">
<table width="100%" border="0" cellspacing="10" cellpadding="0">
<tr><td><strong>Account ID:</strong></td>
<td width="66%"><input type="text" size="30" maxlength="15" name="id" id="id" title="* Only 4-15 Words/number"></td></tr>
<tr><td><strong>Password:</strong></td>
<td><input class=it id="ipassword" type="password" size="30" maxlength="15" name=pass title="* Only 4-15 Words/number"></td></tr>
<tr><td><strong>Retype Password:</strong></td>
<td><input class=it1 id="ipassword" type="password" size="30" maxlength="15" name=retpass title="* Only 4-15 Words/number"></td></tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<br /><br />
<TABLE align="center">
<tr><td align="center"><input type="hidden" name="hash"><input class=Butt type=submit onclick="hash.value = login(pass.value)" value='register' name=B1></td></tr>
</table>
</td>
</tr>
</table>
</form>
</td>
</tr>
</table>
<?php
                        if($_GET['act'] == "register")
                                {
                                        mysql_select_db($mydbacc);
                                        $userid = trim($_POST['id']);
                                        $password=trim($_POST['pass']);
                                        $passretype=trim($_POST['retpass']);
                                        $hash=$_POST['hash'];
					[COLOR="Red"]$_SERVER['REMOTE_ADDR'];[/COLOR]
                                         if($userid=="" || $password=="" || $passretype=="" )
                                         {
                                                echo "<center>You must fill all information in the Required Field!</center>";
                                         }
                                         else
                                         {
                                             if($password == $passretype)
                                                 {
                                                  if(!ereg("^[0-9a-z]{4,15}$",$userid))
                                                  {
                                                        echo "<center>Only letters and numbers only are allowed.Long 4 to 15 words</center>";
                                                        }
                                                        else
                                                        {
                                                                $res = mysql_query("select * from account where name = '".$userid."' order by id desc");
                                                                if(mysql_num_rows($res) == 0)
                                                                {
                                                                        mysql_query("insert into account (name,Password,Reg_date,[COLOR="Red"]netbar_ip[/COLOR]) values ('".$userid."','".$hash."','".date("y-m-d H:i:s", time())."',[COLOR="Red"]'".$_SERVER['REMOTE_ADDR']."'[/COLOR])");
									echo "<center>Account successfully registered!</center>";
                                                                }
                                                                else
                                                                {
                                                                        echo "<center>This account has been registered, please select another!</center>";
                                                                }
                                                        }
                                                }
                                                else
                                                {
                                                        echo "<center>Password authentication is not the same as your Password</center>";
                                                }
                                        }
                                }
                        ?>

.Ash · 04/05/2010, 17:25

Do you have IP column in your Account table?

PraDevil[ELITE] · 04/05/2010, 17:31

no

~WARNING~ · 04/05/2010, 18:47

you should make one :P i have one in mine so that's extremely weird that you don't