[Tutorial] Netty Based Server

[-=Flavio=-]

haha I had not noticed it :P anyway I will test soon

[mustafagrlyn]

Hello

Packet.cs -> Send(Commands.StringPacket("")); ^_^


I Love You Shock <3

Netty Emulator: Shock[DEV]
Edited and Updated: ΉΛDΣS_PЯO[DΣV]

NOTE: This emulator (NeetyBase) created by Shock and edited by ΉΛDΣS_PЯO[DΣV].

 
 
  using NettyBase.Net

namespace Server
{

    static class Commands
    {
        public static byte[] StringPacket(string n)
        {
            ByteArray enc = new ByteArray(29052);
            enc.UTF(n);
            return enc.ToByteArray();
        }
    }
}

[ItsTequila]

To the one who is trying his emulator, I'm very sorry maps.php got fixed.

[olitis1]

You should use locks to make sure that your code won't be doing ugly things when an action is called simultaneously and the action before hasn't finished.
For example in Utils.Out.cs it should be like:

 Spoiler

using System;

namespace NettyBase
{
    class Out
    {
        private static object WriteLock = new object();
        /// <summary>
        /// That should replace the Console.WriteLine with a little more ordered version.
        /// </summary>
        /// <param name="message">That's where the input text goes</param>
        /// <param name="header">This parameter is optional and it stands for the [header] before the text</param>
        /// <param name="color">This parameter is optional and it is chosing the color you would like the text to be</param>
        public static void WriteLine(string message, string header = "", ConsoleColor color = ConsoleColor.Gray)
        {
            lock(WriteLock)
            {
                Console.ForegroundColor = ConsoleColor.Gray;
                Console.Write("[" + DateTime.Now + "]");

                if (header != "")
                {
                    Console.Write("[");
                    Console.ForegroundColor = ConsoleColor.DarkGray;
                    Console.Write(header);
                    Console.ForegroundColor = ConsoleColor.Gray;
                    Console.Write("]");
                }

                Console.Write(" - ");
                Console.ForegroundColor = color;
                Console.WriteLine(message);
                Console.ForegroundColor = ConsoleColor.Gray;
            }
        }
    }
}

[Requi]

Originally Posted by olitis1

You should use locks to make sure that your code won't be doing ugly things when an action is called simultaneously and the action before hasn't finished.
For example in Utils.Out.cs it should be like:

 Spoiler

using System;

namespace NettyBase
{
    class Out
    {
        private static object WriteLock = new object();
        /// <summary>
        /// That should replace the Console.WriteLine with a little more ordered version.
        /// </summary>
        /// <param name="message">That's where the input text goes</param>
        /// <param name="header">This parameter is optional and it stands for the [header] before the text</param>
        /// <param name="color">This parameter is optional and it is chosing the color you would like the text to be</param>
        public static void WriteLine(string message, string header = "", ConsoleColor color = ConsoleColor.Gray)
        {
            lock(WriteLock)
            {
                Console.ForegroundColor = ConsoleColor.Gray;
                Console.Write("[" + DateTime.Now + "]");

                if (header != "")
                {
                    Console.Write("[");
                    Console.ForegroundColor = ConsoleColor.DarkGray;
                    Console.Write(header);
                    Console.ForegroundColor = ConsoleColor.Gray;
                    Console.Write("]");
                }

                Console.Write(" - ");
                Console.ForegroundColor = color;
                Console.WriteLine(message);
                Console.ForegroundColor = ConsoleColor.Gray;
            }
        }
    }
}

As far as I know, locks are only necessary when using lists/dictionaries/arrays which could be changed while they are being used. I might be wrong though.

[olitis1]

Originally Posted by Requi

As far as I know, locks are only necessary when using lists/dictionaries/arrays which could be changed while they are being used. I might be wrong though.

Locks can be used when you know that an action could take some time (to write some lines) and it can be called concurrently.

While the action is performing some text color changes and writing, the action is again called.
With a lock, you make sure that the lines will be full written (thread-safe).

That's a possible scenario:
Without a Lock ->

 Spoiler

With a Lock->

 Spoiler

[Requi]

Originally Posted by olitis1

Locks can be used when you know that an action could take some time (to write some lines) and it can be called concurrently.

While the action is performing some text color changes and writing, the action is again called.
With a lock, you make sure that the lines will be full written (thread-safe).

That's a possible scenario:
Without a Lock ->

 Spoiler

With a Lock->

 Spoiler

You gotta do something horribly wrong that this happens. I've never had it happened that the streamio got corrupted.

[olitis1]

Originally Posted by Requi

You gotta do something horribly wrong that this happens. I've never had it happened that the streamio got corrupted.

It's not writting 1 time, it's writting 3 times (to change colour and add header and that...) for each single line.

[Requi]

Originally Posted by olitis1

It's not writting 1 time, it's writting 3 times for each single line.

then it would be better to concat the string and then write it, instead of abusing the stream so much.

[olitis1]

Originally Posted by Requi

then it would be better to concat the string and then write it, instead of abusing the stream so much.

You can't change the colour in the same string. (or atleast I think so)

[Requi]

Originally Posted by olitis1

You can't change the colour in the same string. (or atleast I think so)

using System;

namespace NettyBase
{
	class Out
	{
		/// <summary>
		/// That should replace the Console.WriteLine with a little more ordered version.
		/// </summary>
		/// <param name="message">That's where the input text goes</param>
		/// <param name="header">This parameter is optional and it stands for the [header] before the text</param>
		/// <param name="color">This parameter is optional and it is chosing the color you would like the text to be</param>
		public static void WriteLine(string message, string header = "", ConsoleColor color = ConsoleColor.Gray)
		{
			Console.ForegroundColor = ConsoleColor.Gray;
			Console.Write("[" + DateTime.Now + "]");
			Console.ForegroundColor = ConsoleColor.DarkGray;
			header = header == "" ? header : "[" + header + "]";
			Console.Write(header);
			Console.ForegroundColor = ConsoleColor.Gray;
			Console.Write(" - ");
			Console.ForegroundColor = color;
			Console.WriteLine(message);
			//Console.ForegroundColor = ConsoleColor.Gray; // u'll reset the color at the start anyways.
		}
	}
}

Oh look. 2 less stream writings.

[th0rex]

Originally Posted by Requi

using System;

namespace NettyBase
{
    class Out
    {
        private static object WriteLock = new object();
        /// <summary>
        /// That should replace the Console.WriteLine with a little more ordered version.
        /// </summary>
        /// <param name="message">That's where the input text goes</param>
        /// <param name="header">This parameter is optional and it stands for the [header] before the text</param>
        /// <param name="color">This parameter is optional and it is chosing the color you would like the text to be</param>
        public static void WriteLine(string message, string header = "", ConsoleColor color = ConsoleColor.Gray)
        {
			Console.ForegroundColor = ConsoleColor.Gray;
			Console.Write("[" + DateTime.Now + "]");
			Console.ForegroundColor = ConsoleColor.DarkGray;
			header = header == "" ? header : "[" + header + "]";
			Console.Write(header);
			Console.ForegroundColor = ConsoleColor.Gray;
			Console.Write(" - ");
			Console.ForegroundColor = color;
			Console.WriteLine(message);
			//Console.ForegroundColor = ConsoleColor.Gray; // u'll reset the color at the start anyways.
        }
    }
}

Oh look. 2 less stream writings.

That code is still not thread safe and locks are indeed needed if your application uses more than one thread (which it will if it's a server, because single threaded servers are slow as fuck).

[Requi]

Originally Posted by C0untLizzi

That code is still not thread safe and locks are indeed needed if your application uses more than one thread (which it will if it's a server, because single threaded servers are slow as ****).

And if you want a fast server which is threadsafe then don't write every ******* bullshit in the console. Try to prevent using the console that much.

[ItsTequila]

@olitis Thank you a lot for the lock I was wondering why when I start the chat server's task it writes on top of itself.

Is anyone able to make packet / socket redirect code on PHP in order to get all the packets from the emulator and handle them there instead of inventory.php.

[manulaiko3.0]

Originally Posted by NUMANDERBUHMAN

@olitis Thank you a lot for the lock I was wondering why when I start the chat server's task it writes on top of itself.

Is anyone able to make packet / socket redirect code on PHP in order to get all the packets from the emulator and handle them there instead of inventory.php.

But I'll move it to along this week...