[FIX] HP Bar doesnt fill up 100%

[.Beatz]

Hey guys I know a few people around this forum are having some trouble with their HP bars not filling up properly when you put something on like a Gold Cup or Trophy or something. This is a very easy fix as I will show you below.
Hit the thanks if you like this or use it.
100% coded by me.... Not leeched from anywhere.

 Spoiler

Search for

if (I.ID == 137310 || I.ID == 137410 || I.ID == 137410 || I.ID == 137610 || I.ID == 137710 || I.ID == 137810 || I.ID == 137910)

In character.cs

Under that there should be code that looks like this

{
                        E.MaxHP += 30000;
                        E.defense += 30000;
                        E.MDef1 += 30000;
                    }

Under that place this

if (I.ID == 2100095) //GoldCup
                    {
                        E.MaxHP += 1500;
                        E.MaxMP += 1500;
                        E.defense += 1000;
                        E.MagicDamageIncrease += 1000;
                        E.minatk = 1000;
                        E.maxatk = 1000;
                    }
                    if (I.ID == 2100085) //Gold Trophy
                    {
                        E.MaxHP += 1500;
                        E.MaxMP += 1500;
                    }
                    if (I.ID == 2100075) //Gold Prize
                    {
                        E.MaxHP += 1500;
                        E.MaxMP += 1500;
                        E.defense += 1000;
                        E.MagicDamageIncrease += 1000;
                        E.minatk = 1000;
                        E.maxatk = 1000;
                    }
                    if (I.ID == 2100065) //Silver Prize
                    {
                        E.MaxHP += 1200;
                        E.MaxMP += 1200;
                    }
                    if (I.ID == 2100055) //Bronze Prize
                    {
                        E.MaxHP += 900;
                        E.MaxMP += 900;
                    }

Done all of them will now work

[kinshi88]

Why not just read the itemtype.dat file? It contains all the item's info, including hp bonuses.

[.Beatz]

Originally Posted by kinshi88

Why not just read the itemtype.dat file? It contains all the item's info, including hp bonuses.

Yes but I added this for people to help them. I have had alot of people ask me how to fix this and I have explained it many many times and I am bored of explaining so I released this.
I know the Itemtype.dat file holds all that information thats how I done this code.

[kinshi88]

You don't need to hard-code anything.

Get the info from the itemtype.txt (decrypted itemtype.dat)

            StreamReader sr = new StreamReader("./Database/itemtype.txt");
            while (!sr.EndOfStream)
            {
                string[] data = sr.ReadLine().Split(' ');
                BaseItem i = new BaseItem();
                i.ID = uint.Parse(data[0]);
                i.Name = data[1];
                i.ReqJob = byte.Parse(data[2]);
                i.ReqProfLvl = byte.Parse(data[3]);
                i.ReqLvl = byte.Parse(data[4]);
                i.ReqSex = byte.Parse(data[5]);
                i.ReqStr = ushort.Parse(data[6]);
                i.ReqAgi = ushort.Parse(data[7]);
                i.ReqVit = ushort.Parse(data[8]);
                i.ReqSpi = ushort.Parse(data[9]);
                i.Tradability = byte.Parse(data[10]);
                i.Weight = ushort.Parse(data[11]);
                i.ShopBuyPrice = uint.Parse(data[12]);
                i.Action = uint.Parse(data[13]);
                i.MaxPhysAtk = uint.Parse(data[14]);
                i.MinPhysAtk = uint.Parse(data[15]);
                i.PhysDefence = uint.Parse(data[16]);
                i.Dexerity = uint.Parse(data[17]);
                i.Dodge = uint.Parse(data[18]);
                i.PotAddHP = ushort.Parse(data[19]);
                i.PotAddMP = ushort.Parse(data[20]);
                i.Durability = ushort.Parse(data[21]);
                i.Arrows = ushort.Parse(data[22]);
                i.MAttack = uint.Parse(data[30]);
                i.Range = ushort.Parse(data[32]);
                i.Frequency = uint.Parse(data[33]);
                i.ShopCPPrice = uint.Parse(data[37]);
                i.Description = data[53];

                Kernel.BaseItems.ThreadSafeAdd<uint, BaseItem>(i.ID, i);
            }

Then when you're calculating hp, or attacking, take into account the BaseItem info.

Hitpoints += BaseItem[id].PotAddHP;

Then EVERY item ever is taken into account.

[.Beatz]

Originally Posted by kinshi88

You don't need to hard-code anything.

Get the info from the itemtype.txt (decrypted itemtype.dat)

            StreamReader sr = new StreamReader("./Database/itemtype.txt");
            while (!sr.EndOfStream)
            {
                string[] data = sr.ReadLine().Split(' ');
                BaseItem i = new BaseItem();
                i.ID = uint.Parse(data[0]);
                i.Name = data[1];
                i.ReqJob = byte.Parse(data[2]);
                i.ReqProfLvl = byte.Parse(data[3]);
                i.ReqLvl = byte.Parse(data[4]);
                i.ReqSex = byte.Parse(data[5]);
                i.ReqStr = ushort.Parse(data[6]);
                i.ReqAgi = ushort.Parse(data[7]);
                i.ReqVit = ushort.Parse(data[8]);
                i.ReqSpi = ushort.Parse(data[9]);
                i.Tradability = byte.Parse(data[10]);
                i.Weight = ushort.Parse(data[11]);
                i.ShopBuyPrice = uint.Parse(data[12]);
                i.Action = uint.Parse(data[13]);
                i.MaxPhysAtk = uint.Parse(data[14]);
                i.MinPhysAtk = uint.Parse(data[15]);
                i.PhysDefence = uint.Parse(data[16]);
                i.Dexerity = uint.Parse(data[17]);
                i.Dodge = uint.Parse(data[18]);
                i.PotAddHP = ushort.Parse(data[19]);
                i.PotAddMP = ushort.Parse(data[20]);
                i.Durability = ushort.Parse(data[21]);
                i.Arrows = ushort.Parse(data[22]);
                i.MAttack = uint.Parse(data[30]);
                i.Range = ushort.Parse(data[32]);
                i.Frequency = uint.Parse(data[33]);
                i.ShopCPPrice = uint.Parse(data[37]);
                i.Description = data[53];

                Kernel.BaseItems.ThreadSafeAdd<uint, BaseItem>(i.ID, i);
            }

Then when you're calculating hp, or attacking, take into account the BaseItem info.

Hitpoints += BaseItem[id].PotAddHP;

Then EVERY item ever is taken into account.

Oh didn't understand what you were saying
Yeah thats a better way of doing it. I am still learning C# though

[kinshi88]

Originally Posted by mattyc2580

Oh didn't understand what you were saying
Yeah thats a better way of doing it. I am still learning C# though

Yup, just trying to help

[~Yuki~]

nice kinshi

[flex30]

Originally Posted by kinshi88

You don't need to hard-code anything.

Get the info from the itemtype.txt (decrypted itemtype.dat)

            StreamReader sr = new StreamReader("./Database/itemtype.txt");
            while (!sr.EndOfStream)
            {
                string[] data = sr.ReadLine().Split(' ');
                BaseItem i = new BaseItem();
                i.ID = uint.Parse(data[0]);
                i.Name = data[1];
                i.ReqJob = byte.Parse(data[2]);
                i.ReqProfLvl = byte.Parse(data[3]);
                i.ReqLvl = byte.Parse(data[4]);
                i.ReqSex = byte.Parse(data[5]);
                i.ReqStr = ushort.Parse(data[6]);
                i.ReqAgi = ushort.Parse(data[7]);
                i.ReqVit = ushort.Parse(data[8]);
                i.ReqSpi = ushort.Parse(data[9]);
                i.Tradability = byte.Parse(data[10]);
                i.Weight = ushort.Parse(data[11]);
                i.ShopBuyPrice = uint.Parse(data[12]);
                i.Action = uint.Parse(data[13]);
                i.MaxPhysAtk = uint.Parse(data[14]);
                i.MinPhysAtk = uint.Parse(data[15]);
                i.PhysDefence = uint.Parse(data[16]);
                i.Dexerity = uint.Parse(data[17]);
                i.Dodge = uint.Parse(data[18]);
                i.PotAddHP = ushort.Parse(data[19]);
                i.PotAddMP = ushort.Parse(data[20]);
                i.Durability = ushort.Parse(data[21]);
                i.Arrows = ushort.Parse(data[22]);
                i.MAttack = uint.Parse(data[30]);
                i.Range = ushort.Parse(data[32]);
                i.Frequency = uint.Parse(data[33]);
                i.ShopCPPrice = uint.Parse(data[37]);
                i.Description = data[53];

                Kernel.BaseItems.ThreadSafeAdd<uint, BaseItem>(i.ID, i);
            }

Then when you're calculating hp, or attacking, take into account the BaseItem info.

Hitpoints += BaseItem[id].PotAddHP;

Then EVERY item ever is taken into account.

It's not for 5165 LOTF?
Becose 5165 read Items.txt and don't use the same names ID.

[~Yuki~]

no its not for NewestCoServer Source. its an example. and **** its not called LOTF when do ppl learn that finally

[flex30]

Originally Posted by ~Yuki~

no its not for NewestCoServer Source. its an example. and **** its not called LOTF when do ppl learn that finally

You don't need to get angry for that, we're not all pro of Conquer PS..

[.Beatz]

Mine is for NewestCoServer Source. But the other one is just an example for people to work off.

[MonstersAbroad]

Few things,

1. Good work Kinishi.
2. Yuki your very right.
3.

It's not for 5165 LOTF?
Becose 5165 read Items.txt and don't use the same names ID.

Of course thats not for "lotf" but can very easily be converted or the original to be changed.

Mattyc2580 - Just if every coder for newestcoserver source had common sence like you. :P

[Sp!!ke]

thanks kinishi I finish to convert read of itemtype

[~Yuki~]

Same here but for my 5017 Lotfie^^