5095 PServer Incorrect char mesh/model 'Wrong Target' 'Green Name' - Char As NPC

[Cmcada]

Hey,

So I'm in the middle of a bit of a research project, building a 5095 server from andyd123's C# base, I'm a C dev irl (embedded) and wanted to expand my language repo to include C#.

Anyways, no issues getting the server running, implemented loads of features already, PK system, Items, upgrading, spells, drop mechanics, just generally tidying up the base source as its a bit messy and fixing some appalling bugs, no offence to Andy.

But I've hit a bit of a head scratcher that I can't seem the figure out.

I'm implementing Pray (revive), and client side I'm not able to target another character with revive, client side simply says 'Wrong target' as if the char I'm targeting is an NPC.

I've got Char targeting working fine with attack spells, white magic, AOF magic (Fire circle, scatter etc), but for some reason Pray won't send any packets (1022'21....0x3FE'0x15) to the server.

Any experienced guys around know what the issue may be? - I presume its some sort of mesh issue/model issue in my handshake.

[Spirited]

Originally Posted by Cmcada

Hey,

So I'm in the middle of a bit of a research project, building a 5095 server from andyd123's C# base, I'm a C dev irl (embedded) and wanted to expand my language repo to include C#.

Anyways, no issues getting the server running, implemented loads of features already, PK system, Items, upgrading, spells, drop mechanics, just generally tidying up the base source as its a bit messy and fixing some appalling bugs, no offence to Andy.

But I've hit a bit of a head scratcher that I can't seem the figure out.

I'm implementing Pray (revive), and client side I'm not able to target another character with revive, client side simply says 'Wrong target' as if the char I'm targeting is an NPC.

I've got Char targeting working fine with attack spells, white magic, AOF magic (Fire circle, scatter etc), but for some reason Pray won't send any packets (1022'21....0x3FE'0x15) to the server.

Any experienced guys around know what the issue may be? - I presume its some sort of mesh issue/model issue in my handshake.

Hey Cmcada, sounds like you've been hard at work. It's been ten years, so I don't think Andy will mind that comment. If you're easily able, can you post a hex dump of the pray packet you're sending to the client? My guess is that your target character's unique identifier might be outside of the range the client knows is a character. Maybe your auto-increment in the database was reset below 1000000 or your packet is malformed?

[Cmcada]

Hey Cmcada, sounds like you've been hard at work. It's been ten years, so I don't think Andy will mind that comment. If you're easily able, can you post a hex dump of the pray packet you're sending to the client? My guess is that your target character's unique identifier might be outside of the range the client knows is a character. Maybe your auto-increment in the database was reset below 1000000 or your packet is malformed?

Major derp, that explains a lot, it was database side, yes Character IDs were below 1000000 as you quite rightly said! - Amusing the number of minor issues that has just resolved.

I'm re-writing the create char code after that.

Thank-you kindly, I shall go continue to butcher C# coding standards until such time as I can recognise so! Never thought I would miss code reviews, maybe I'll write all my code blindingly drunk and review it when I'm sober huh? Thats peer review right?

[Latyos]

Originally Posted by Cmcada

Major derp, that explains a lot, it was database side, yes Character IDs were below 1000000 as you quite rightly said! - Amusing the number of minor issues that has just resolved.

I'm re-writing the create char code after that.

Thank-you kindly, I shall go continue to butcher C# coding standards until such time as I can recognise so! Never thought I would miss code reviews, maybe I'll write all my code blindingly drunk and review it when I'm sober huh? Thats peer review right?

It's mentioned in the topic as well

Something VERY important I forgot to mention.
The first character you create, you must enter into the characters table, and MANUALLY change his id to 1100000.

Also, to be honest, I wouldn't bother with that source. It's realllllyyy messy. If you want 5095 strictly, I'd suggest you to pick up a source that's more organized, downgrade/upgrade it. Good luck on your journey

[Spirited]

I don't fault you for trying out CoEmu. Nobody bursts out of the gate knowing everything there is to know about Conquer development. It was one of my first sources as well. As long as you know it has a long way to go in terms of improvements and you're still learning something from it (like for me, it taught me about networking/packets in general), then good.

[LepEatWorld]

The first source I ever tried to learn on was from Dabishy... I wonder if it still exists lol

[Cmcada]

Originally Posted by Latyos

It's mentioned in the topic as well



Also, to be honest, I wouldn't bother with that source. It's realllllyyy messy. If you want 5095 strictly, I'd suggest you to pick up a source that's more organized, downgrade/upgrade it. Good luck on your journey

It takes real dedication to put out a source that size, no matter the quality, its more than 99% of the 'devs' in the world can muster.

I'm just learning a few new languages during lockdown, I come from a strong safety critical background and have never strayed much outside of that world, played CO for years (back in days, 03-09? Lion/Dark) so figured tapping into the private server codebases here makes sense so I can focus on the code rather than the context.

At the moment I'm halfway between CoEmu and COPS v6, comparing and contrasting, analysing the architecture, coding styles - Very interesting

[Spirited]

Originally Posted by Cmcada

It takes real dedication to put out a source that size, no matter the quality, its more than 99% of the 'devs' in the world can muster.

I'm just learning a few new languages during lockdown, I come from a strong safety critical background and have never strayed much outside of that world, played CO for years (back in days, 03-09? Lion/Dark) so figured tapping into the private server codebases here makes sense so I can focus on the code rather than the context.

At the moment I'm halfway between CoEmu and COPS v6, comparing and contrasting, analysing the architecture, coding styles - Very interesting

You're welcome to take a look at Comet as well. It's a different beast (dotnet core). I'm still in the middle of updating everything to be async-await, but it's a fully documented source if you're interested.

[Cmcada]

Originally Posted by Spirited

You're welcome to take a look at Comet as well. It's a different beast (dotnet core). I'm still in the middle of updating everything to be async-await, but it's a fully documented source if you're interested.

Oh cool, thanks! - I will definitely take a look.