VIP Aura not saving correctly

~OwnageBoy · 01/12/2018, 03:05

So I been writing hours of different codes, trying and testing over and over and decided to see if anyone here has the golden hint. The effect does appear, however when people jump out screen and back.. it's gone. and it will take a moment before it will appear again. Thanks in advance.

Code:

try
            {
                byte servermin = ServerTime.Minute;
                if (servermin % 1 == 0)
                {
                    foreach (Game.Character C in Game.World.H_Chars.Values)
                    {
                        if (C.VipLevel >= 5)
                        {
                            if (!C.VIPAura)
                            {
                                C.VIPAura = true;
                                Game.World.Action(C, (Packets.String(C.EntityID, 10, "2NDMetempsychosis")).Get);
                            }
                            else
                            {
                                Game.World.Action(C, (Packets.String(C.EntityID, 10, "none")).Get);
                                Game.World.Action(C, (Packets.String(C.EntityID, 10, "2NDMetempsychosis")).Get);
                            }

                        }
                    }
                }
            }
            catch { }

Spirited · 01/12/2018, 03:57

Quote:

Originally Posted by ~OwnageBoy

So I been writing hours of different codes, trying and testing over and over and decided to see if anyone here has the golden hint. The effect does appear, however when people jump out screen and back.. it's gone. and it will take a moment before it will appear again. Thanks in advance.

Spoiler

You're not going to like this response, but you need to do a lot better than this. This type of code is going to break your server pretty badly. Firstly, mod 1 of everything is going to be zero, always. The mod operation just says "what's the remainder of dividing these two numbers". If you divide anything by 1, the remainder will always be zero. Secondly, you need to be adding these effects on login, not in some massive loop that loops through every character every few minutes of the server being on. That's just inefficient. On top of that, you're sending these packets in duplicates to each player's screen for each run of this code. That's approaching exponential growth (the worst type of algorithm efficiency model there is). You need to move this to login, and to a status effect using the spawn packet rather than client effects using the string packet.

Soulfly25 · 01/12/2018, 07:47

@

is right dude. We have the same thought to use the string. Then again I was thinking there is an Statuseffect which will store all looped effects that's why I use the statuseffect procedure yet still confused about bitflags to figured it out (it's not a code it's a number system). Hehehe.

Spirited · 01/12/2018, 09:19

Quote:

Originally Posted by Soulfly25

@ is right dude. We have the same thought to use the string. Then again I was thinking there is an Statuseffect which will store all looped effects that's why I use the statuseffect procedure yet still confused about bitflags to figured it out (it's not a code it's a number system). Hehehe.

Your source already implements it...

~OwnageBoy · 01/12/2018, 11:02

Thanks for ur response. The 2nd reborn effect is not in the list of statuseffect. Would it be better to put it there? Thats why i tried using packet string since the 2nd rb effect only comes when im 2nd reborn by the rebirthcount.

Here is my status effects, 2NDMetempsychosis is not in there and I can't find which numbers to use behind it if I add it in there.

Spoiler

Hoping to find a solution for my problem, I been working days on this now

Spirited · 01/12/2018, 17:27

Not even sure you need to send a status effect for that... I'm pretty sure it's just the spawn packet having the right reborn info. You should probably send something else if you want to make a VIP aura anyways, so not to confuse players.

~OwnageBoy · 01/13/2018, 09:30

Quote:

Originally Posted by Spirited

Not even sure you need to send a status effect for that... I'm pretty sure it's just the spawn packet having the right reborn info. You should probably send something else if you want to make a VIP aura anyways, so not to confuse players.

What do you mean by sending something else? Players are not able to 2nd rb. Just me as a PM, aura works fine but cant find code that triggers it other than reborn count, and I would like the VIP to gain this 2nd reborn effect. I just keep getting stuck on it.

-impulse- · 01/13/2018, 15:26

Just because you don't allow 2nd reborn in your server doesn't mean the client doesn't know how to handle it. If you correctly set reborn count in entity spawn then anyone who sees that character will also see the 2nd reborn effect.

The only exception would be client version < 5000. I don't know what version your client is but since it looks like you're using LOTF it means it's at least 5017.

Spirited · 01/13/2018, 19:09

Quote:

Originally Posted by -impulse-

Just because you don't allow 2nd reborn in your server doesn't mean the client doesn't know how to handle it. If you correctly set reborn count in entity spawn then anyone who sees that character will also see the 2nd reborn effect.

The only exception would be client version < 5000. I don't know what version your client is but since it looks like you're using LOTF it means it's at least 5017.

The NCOS2 source developed super cancer in the Arabic community just like your leaked source did. That's the source he's using. They call it "***". It's the same source I found that explicitly programmed exploit in that allows anyone to delete all characters or make themselves a PM. It's very ****.

~OwnageBoy · 01/14/2018, 06:04

That moment people go off topic. Judging and cursing once again. Thanks anyway

Spirited · 01/14/2018, 07:19

Quote:

Originally Posted by ~OwnageBoy

That moment people go off topic. Judging and cursing once again. Thanks anyway

Can't be helped. You contribute to the problem when you use sources like that and then spam our community. We're not hosting the source. Why bring the problems here? Why do that and then decide not to try learning how to code when people offer to help you? Why come here just to request code, and then go out of your way not to contribute back in any way. That's not what we're here for, and people who come here looking for that can leave.

~OwnageBoy · 01/14/2018, 08:02

I didnt force you to answer. Go smoke some weed and get over yourself

Spirited · 01/14/2018, 08:06

Quote:

Originally Posted by ~OwnageBoy

I didnt force you to answer. Go smoke some weed and get over yourself

I wasn't talking about myself. Sorry if it sounds like I only care about myself, but I don't want to code for you. Nobody here does unless you're willing

. Ultimately, I think you have unreasonable expectations when posting questions. I'd love to help, and I offered to help you come to better answers, but you refuse to cooperate or expect the work to be done completely for you - and then you don't respond appropriately in return. If that's not a summary for the type of attitude those ***-awful sources bring here, then I don't know what is.

Soulfly25 · 01/14/2018, 12:37

@

sir, can I ask you something? Is it possible if I add new data in statuseffect? like if the statuseffect.ini have the last of 54 (of total effects) and in the public enum statuseffect also have 54. Can I add another new line of effects both statuseffect.ini and in the source part? It's kind a noob question but want to know it.

Thank you.

~OwnageBoy · 01/14/2018, 13:37

If thats possible it would be great. Looking forward to an answer of spirited