[5017] Fork of Arco's Source

[Hybris]

Im currently working on a fork of Arco's Source.
I will setup a GitHub for anyone who wishes to follow the work or participate.

More info, soon.

If anyone is interested, feel free to comment here

Edit :
Here is the link to the GitHub project :
Just missing the initial database sql I will add it soon

Edit(2) :
The goal of the project is to allow people create a very basic server in order to battle easely.
First step : Allow people to use ScentSword and FastBlade in PvP
Second step : Make some "event" where people will be able to touch each other with skills and not die, just count hits and have some winner after reached a certain count.

[pro4never]

#1: This is not a release
#2: There is a volunteer/looking for volunteer sticky for posts like this
#3: Is arco back involved in conquer and this is a new source or are you taking a very old, relatively un-influential source and trying to use it to develop with? Nothing against Arco but I seem to remember that source being nothing special at the time it was released.

[Hybris]

Originally Posted by pro4never

#1: This is not a release
#2: There is a volunteer/looking for volunteer sticky for posts like this
#3: Is arco back involved in conquer and this is a new source or are you taking a very old, relatively un-influential source and trying to use it to develop with? Nothing against Arco but I seem to remember that source being nothing special at the time it was released.

#1 Now it is a release
#2 Im not especially searching for volunteers, just if some people are interested I allow them to contact me
#3 Arco is not back involved in Conquer, I am taking a very old source as a base.
The aim of this project will be the following :
- Make a PvP server where people will be able to easely fight against each other without count of damage just count of hits. So the server itself will be very basic. The thing is, Arco's project is far enough to allow myself reach my goal with just a few edits.

[Best Coder 2014]

Wow, that's some really ugly code.

Also, why do you have "Backup", "_UpgradeReport_Files", and "obj" folders (just to name a few) in your git repository? You're doing git wrong.

[Hybris]

Originally Posted by Best Coder 2014

Wow, that's some really ugly code.

Also, why do you have "Backup", "_UpgradeReport_Files", and "obj" folders (just to name a few) in your git repository? You're doing git wrong.

As I said, the source is taken from someone else as base work. I modified like a dozen of lines in it to make it work first and uploaded it right away.
The cleanup work is coming

Edit :
Cleanup on those useless folders/files is done by now.


Edit(2) :
Added missing references and some future work.

[m e n a]

I'm supporting you dude, go on please.

[Hybris]

Moved the source in a "src" folder in order to separate the installation files from the source code.

Refactored the way character skills are stored (the way it is done yet stores a list of skill for an account not a character this will have to be reworked) from flat file to database.

Created a few vars to enhance maintenability.
Creates some config files at server startup if they dont exist ("settings.txt" for example).

Edit :

Transfered Items' Stats from Flat File to Database structure (still need to migrate the data).

Edit(2) :
Imported ConquerNetwork and DMapLoader projects for debugging :


Also fixed a few loading bugs, now to simple start the server you just need to put it inside your Conquer installation folder.

Edit(3) :
- Changed the itemstats table structure (drop the table to make sure it is correct).
Migrated the whole itemstats ini files into the database (made an extraction project for this).
- Now itemstats are directly loaded into server's memory to avoid unnecessary requests
- Clients are forced to disconnect when server is manually shutted down (to make sure everyone is saved)


Edit(4) :
- Allow Teleport Scrolls to be used (except DesertCity yet)
- Allow SkillBooks to be used
- Uses also Stamina (and not only Mana) when a spell is casted

[Xio.]

m_Variable .... thats an insta turnoff

Good luck on your project tough

[Best Coder 2014]

Originally Posted by Xio.

m_Variable .... thats an insta turnoff

Good luck on your project tough

Yeah, I agree.

private int _SomeVariable;

Looks so much better .

[Hybris]

Originally Posted by Best Coder 2014

Yeah, I agree.

private int _SomeVariable;

Looks so much better .

The original author clearly needs to standard his var naming, sometimes its "m_Var" sometimes its "myVar"...

Once again, the objective is not to have the most beautiful looking source code, especially since it's a fork, if I could I would have start it from scratch (thing I can't afford nowadays).

Edit :

accountsprofs table was added in order to pass "Profs" folder with Ini Files to database loading/saving (Done)

accountsinventory table was added in order to pass "inventory" folder with Ini Files to database loading/saving (Done)

Implement two NPCs and prepared Equipments to be saved/loaded from database (needs a little rework here). Added also a missing portal for Mystic Castle.

[Best Coder 2014]

Originally Posted by Hybris

The original author clearly needs to standard his var naming, sometimes its "m_Var" sometimes its "myVar"...

I was just making fun of Xio.

[Xio.]

Didn't quite work did it?

@Hybris,

Are you going to use ini files for accounts/characters?

[LetterX]

Why not use a better base?

[Hybris]

Originally Posted by Xio.

@Hybris,

Are you going to use ini files for accounts/characters?

I will not, by the way, I already transfered a lot of data to database :

Originally Posted by LetterX

Why not use a better base?

This one fits my needs, the rework needed is not so big.

[Super Aids]

If I remember correctly some packets are structured with invalid offset in the source. Can't remember exactly which. I could be wrong, could be thinking of another source.

Originally Posted by Xio.

m_Variable .... thats an insta turnoff

Good luck on your project tough

IMO m_variable looks better than _variable. m_ being a "member" prefix.

However I don't think variable names should ever be camel cased either. Either way m_Variable and _Variable looks like **** IMO.