Guild and Chat Packets

[pintinho12]

Hello,
I've been checking the packet logs, I am working on the packet 1107, the Guild Request one...

It looks like It's sending 2 Packets in a row, This and the Chat Packet one when a whisper is sent, It does have 2 TQClient ****, So i guess there are 2 packets..
Is it? Do i need to build something to Split it into 2 Packets?
I will try it now btw lol
I am sending the String Packet with the Guild Names, I'm doing this because ive seen on another sources...
I noticed that they send the SynID with ushort instead of uint, but the offsets between ranking and guild are 4 bytes away from each other...
I made them 16 (SynID) and 20(Rank) because Exodus didnt have them added
Tried 12 and 16, but the client crashes after the StringPacket..
Tried to look 5165 sources lol but couldnt find the Guild Load part... >_>
From 5180 to 5517 the Guild Packet changes alot?

[Spirited]

Regarding your first question, do you do any packet splitting or fragment handling?

[pintinho12]

Originally Posted by Spirited

Regarding your first question, do you do any packet splitting or fragment handling?

I've fixed this, now im stuck with a "The program has been terminated due to a stackoverflow"
Something like that


Trying to figure out whats causing that..
Happens after i open the Guild Window

[Spirited]

You need some proper error handling so your server doesn't crash if an error is thrown. Is the program terminating within error handling? If so, you may want to check how many resources your server is using (Shift + Ctrl + Esc).

[pintinho12]

Originally Posted by Spirited

You need some proper error handling so your server doesn't crash if an error is thrown. Is the program terminating within error handling? If so, you may want to check how many resources your server is using (Shift + Ctrl + Esc).

Ive been reading, it may be any loop, but i couldn't find any...
How can i handle errors? I have try/catch to receive and send packets lol
I've been having crashes after disconnections hahah
It started after i start adding guild stuff '-'
Now it's happening again..
Sometimes it just disconnects after the screen spawn
//edit
sure, removed the guild ****, logged in normally hahah -__-
Am i looping somewhere?
Because all it does is send the guild infos to the client :|
Gotta check out the code

[Spirited]

If your client disconnects randomly on a packet, it may be the length. Check your packet length in offset zero against your send buffer length. If the client receives the wrong length, it usually just disconnects you or crashes. As far as error checking goes, try-catches are a good start. From that picture though, it didn't seem like errors were caught properly. Are you referencing an external library incorrectly or reading beyond the memory your program as allocated?

[pintinho12]

It was crashing the Client, i checked and it was sending packet full of 0 with Lenght 11, so i found out that it was my String Packet, i rebuild it and then i logged in... But when i use the SendGuild() it crashes (The server).. I used a Try{}Catch{} but it crashes anyway..

 Spoiler

public void SendGuild(SocketClient Client)
        {
            if (!Members.ContainsKey(Client.Entity.UID))
            {
                Program.ConsoleWrite("Member " + Client.AccountID + " tried to load a guild that he isnt signed in!");
                return;
            }
            
            Client.AppendMessage(new Message(Bulletin, System.Drawing.Color.White, Message.GuildAnnouncement));
            DWORD32(uint.Parse(DateTime.Now.ToString("yyyymmdd")), 67);
            DWORD32((ushort)Client.asMember.Rank, 28);
            Client.Send(this.Packet);
        }

[pintinho12]

Thanks Fang, problem solved

How do i send the Name? lol Been trying, but the String Packet isnt working :|
Should i need to create another thread? If yes, you can close this one, the guild and chat problem are fixed

[Spirited]

Nah, another thread isn't necessary. As long as it's on topic. Guild names are usually set using the string packet, so how are you sending it? What data are you sending in what offsets?

[pintinho12]

Is it wrong? I send it before the items, skills and character stuff...

public void SendName(SocketClient Client)
        {
            StringPacket stringPacket = new StringPacket(true);
            stringPacket.UID = this.UID;
            stringPacket.Type = (byte)StringPacket.GuildName;
            stringPacket.Texts.Add(Name + " " + LeaderName + " 0 " + MemberAmount);
            stringPacket.Send(Client);
            Console.WriteLine("ID: " + this.UID + " Name: " + Name + " Leader Name: " + LeaderName);
        }

And this is the StringPacket

public StringPacket(bool Create)
            : base(8 + 11)
        {
            if (Create)
            {
                Buffer = new byte[19];
                WORD(11, 0, Buffer);
                WORD(1015, 2, Buffer);
                Texts = new List<string>();
            }
        }
        public uint UID
        {
            get { return BitConverter.ToUInt32(Buffer, 4); }
            set { DWORD32(value, 4, Buffer); }
        }
        public byte Type
        {
            get { return Buffer[8]; }
            set { Buffer[8] = value; }
        }
        public byte TextsCount
        {
            get { return Buffer[9]; }
            set { Buffer[9] = value; }
        }
        public List<string> Texts;
        public byte[] ToArray()
        {
            ushort entirelength = 19;
            foreach (string list in Texts)
                entirelength += (ushort)list.Length;
            byte[] buffer = new byte[entirelength];
            WORD((ushort)(entirelength - 8), 0, buffer);
            WORD(1015, 2, buffer);
            DWORD32(UID, 4, buffer);
            buffer[8] = Type;
            Buffer = buffer;
            Byte(Texts, 9, Buffer);
            return Buffer;
        }

[Spirited]

I've never implemented Guilds before, but don't think the elements should be appended to just one string. Each element is probably its own string that you have to send all in one packet. Perhaps someone else can confirm that what I'm saying is correct.

[pintinho12]

I've sawn it at another Sources, it sends the Name, Leader, 0 and the Member Amount '-'

Well, fixed 50%...
It isnt showing the Leader Name... But ill be fixing it..
About the Jumping... i remember a thread that you created with a calculation when someone jumps on your screen..
Do you remember which one is that?
It works when i send the Jump packet to leave the screen, but when it appears again it just "spawn"...
and make the jump on the same coord he spawned..

Someone still edit the Packet Wiki? I wish to donate 5187 Packet Offsets xD



The Guild ID is ushort or uint?
I can't make it on the spawn packet... UID is 8, Syn ID i tried ushort 12-14-18-20.. 16 is the Position, if i use any Offset after 16, it doesnt show the Position, and uint 12-16-20 Doesnt show the Name..