Rate Problem.

[LordGragen.]

hey guys i have a question i like to ask,

i am using the rate system in my project for example if this monster get killed he have 5% chance to drope the stone.

but some how the % system is not working proper. if i put 5% idk why it will drope the stone every 5 kills or maybe 7 or idk 4.

and should not drop to fast , here is the system i use

if (Name == "StoneStealer" && ServerBase.Kernel.Rate(5))

kernel.cs

public static Random Random = new Random();

kernel.cs

 public static bool Rate(int value)
        {
            return value > Random.Next() % 100;
        }
        public static bool Rate(int value, int discriminant)
        {
            return value > Random.Next() % discriminant;
        }
        public static bool Rate(ulong value)
        {
            return Rate((int)value);

[abdoumatrix]

I'm not sure but could some thing like this help?

 Spoiler

PHP Code:

public static bool PercentSuccess(double percent)
        {
            return ((double)Rand.Next(1, 1000000)) / 10000 >= 100 - percent;
        } 


or

PHP Code:

 public static bool ChanceSuccess(double Chance)
        {
            int e = Random.Next(10000000);
            double a = ((double)e / (double)10000000) * 100;
            return Chance >= a;
        } 


[pro4never]

Try making an easily breakpointed method to calculate it and also ensure you are not running the percentage chance calculation more than once (some sources do a loop for item drops. You don't want to check for 5 percent droprate 5 times in a row or you'll have an issue)

Currently you have a poor way of handling things for a number of reasons.

#1: You can never use lower than 1 percent droprates (1 percent is pretty high... 100 mobs can be killed very quickly)
#2: The random value is always a whole number


Decimal calculations are more costly but here's a quick example that pops to mind.

public static bool percentSuccess(double chance)
{
var decChance = chance * .01;//convert to percentage chance to compare.
var randomVal = Random.NextDouble();
return decChance > randomVal;
}

Breakpoint the return statement to see if it returns results you would expect and then just streamline it to be

return (chance * .01) > Random.NextDouble();

[LordGragen.]

thank you, gona try time to fix.

[LordGragen.]

okay so here is what i did, please let me know if i am doing something wrong.
sorry my English is not perfect so i am trying to collect every detail as much as i can.


so on kernel i added

 public static bool percentSuccess(double chance)
        {
            var decChance = chance * .01;
            var randomVal = Random.NextDouble();
            return decChance > randomVal;
        }

and for monster

if (Name == "DeadWarrior" && ServerBase.Kernel.percentSuccess(5.0))

i started using 5.0 from 5 but idk if thats make any different. am i missing anything else.