Impulse Based Source Bugs / Problem

[shadowman123]

Well I've Been working On this Source for 1 year or so Fixed alot of its bugs / added alot of thins but am looking for stability Right now .. making sure everything is well coded but Alot Told me that :-

1 - Thread system is Weakly Coded

2 - Monster Spawn is badly Coded

So what i was asking if sm1 tried Impulse based source ..Could Tell me :-

1 - How They r bad Coded ?

2 - What can be Done to improve them ?

3 - What do u see need to be Recoded ?

Regards
shadowman123

[_DreadNought_]

If you're asking us what's wrong with it what makes you think you can fix it?

[shadowman123]

Originally Posted by _DreadNought_

If you're asking us what's wrong with it what makes you think you can fix it?

ill Depend on My Experience in Source beside my C# knowlage then give it a try .. And i think i can handle it ..but my problem is that i dont know whats wrong with Threading system !! thats y am asking

[_DreadNought_]

Originally Posted by shadowman123

ill Depend on My Experience in Source beside my C# knowlage then give it a try .. And i think i can handle it ..but my problem is that i dont know whats wrong with Threading system !! thats y am asking

Do some searching, It's been pointed out by InfamousNoone in a DuelistAI thread.

It uses GC.KeepAlive, which really shouldn't be used.

[shadowman123]

Originally Posted by _DreadNought_

Do some searching, It's been pointed out by InfamousNoone in a DuelistAI thread.

It uses GC.KeepAlive, which really shouldn't be used.

ThanQ Dread

[I don't have a username]

Well it uses a lot of bad coding habits.

[shadowman123]

Originally Posted by I don't have a username

Well it uses a lot of bad coding habits.

What do u think need to be Recoded ? Honestly Only Things i Recoded Are Reincarnation and Floor Item / Flower system / Lottery system .. Nothing else i went thought Threads But Havent Learned Much ..

[_DreadNought_]

Threads do need recoding.

I'd also recode the Screen class, infact, I'd recode everything... iashdfai;sd, idunno, I can't use public sources anymore, own sources ftw.

[shadowman123]

Originally Posted by _DreadNought_

Threads do need recoding.

I'd also recode the Screen class, infact, I'd recode everything... iashdfai;sd, idunno, I can't use public sources anymore, own sources ftw.

Well Im Abit DisAppointed but i Can Handle it At last But Please When you Say smthing is Bad Tell me Y it is for Screen System idk whats Wrong with it..Can u ? .. For Threads i Searched for it But All i got is Different Techniques of Making Thread For Example Using This Way

Thread MyThread = new Thread(new ThreadStarter(Target));
MyThread.Start();
MyThread.Join();

[_DreadNought_]

Originally Posted by shadowman123

Well Im Abit DisAppointed but i Can Handle it At last But Please When you Say smthing is Bad Tell me Y it is for Screen System idk whats Wrong with it..Can u ? .. For Threads i Searched for it But All i got is Different Techniques of Making Thread For Example Using This Way

Thread MyThread = new Thread(new ThreadStarter(Target));
MyThread.Start();
MyThread.Join();

Threading is so, so, so simple, Why do people over do it?
It's as simple as:

PHP Code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading;
using ConquerSource.Game;
using System.Diagnostics;

namespace ConquerSource.Core
{
    public class Threading
    {
        static TIME _LastCheck;
        public static void Fireup()
        {
            _LastCheck = TIME.Now;

            //Main thread
            new Thread(Core).Start();
            Program.WriteLine("[Threading] Core threads has been created and started.");
        }
        public static void Core()
        {
            while (true)
            {
                TIME CurrentTime = TIME.Now;
                if (CurrentTime.Time >= _LastCheck.Time)
                {
                    _LastCheck = TIME.Now;

                    Stamina_Check();
                }
                Thread.Sleep(100);
            }
        }
        private static void Stamina_Check()
        {
            foreach (GameClient client in Kernel.GamePool.Values)
            {
                TIME CurrentTime = TIME.Now;
                double Time = 0;
                bool Quick = false;
                if (client.Char.Action == ConquerAction.Sit)
                {
                    Time = 800;
                    Quick = true;
                }
                else
                    Time = 1200;
                if (client.Char.StaminaStamp.Time <= CurrentTime.Time)
                {
                    client.Char.StaminaStamp = CurrentTime.AddMilliseconds((int)Time);
                    if (client.Char.Stamina != 100)
                    {
                        switch (Quick)
                        {
                            case false:
                                {
                                    if (client.Char.Stamina <= 96)//7?
                                        client.Char.Stamina += 3;
                                    else
                                        client.Char.Stamina = 100;
                                    break;
                                }
                            case true:
                                {
                                    if (client.Char.Stamina <= 93)//10?
                                        client.Char.Stamina += 7;
                                    else
                                        client.Char.Stamina = 100;
                                    break;
                                }
                        }
                    }
                }
            }
        }
    }
} 


I wrote that over a year ago, there's no need for a load of fancy threading shit, keep it simple, keep it good.

Note: Over a year ago, Yes I should be going through the dictionary as an array for faster speeds, and the stamina code is abit fucked up, ontop of the initial thread check, but it works, very well.

[Zeroxelli]

Never create a thread like that, it's a bad idea in servers. You always want to have a way to access it later on in case something happens. Create a variable and assign the thread to that, then call start. Thus why MSDN uses that method.

Also, why did that example call Join()? That's all fine and dandy in a desktop application, but in a server you never want to block the thread of the socket. That would mean that no other connections were accepted until that connection disconnected or the thread handle was terminated. Bad idea.

My $0.02 + tax.