Infinite mana problem

[macht102]

the problem is I have 30/30 MP on login like it should be. but it jumps to around 65000/30 after casting and then goes down from there.

if searched the forums. only found


and nothing in that thread has worked.
Its the same problem i think but cant figure it out.

[Kiyono]

So which source are you using?

[macht102]

I am using this one

[Kiyono]

I guess that the best answer is to not use a LOTF based source.

[I don't have a username]

Because it goes into negative and it's an ushort. unsigned integers cannot be negative, so it will jump to max value once it reaches a negative value. A simple if check can fix your problem, now it's up to you to do the rest yourself.

[Spirited]

Originally Posted by I don't have a username

Because it goes into negative and it's an ushort. unsigned integers cannot be negative, so it will jump to max value once it reaches a negative value. A simple if check can fix your problem, now it's up to you to do the rest yourself.

Are you serious?! That's the "Mana Problem" that everyone who uses LOTF brags about fixing?!

[I don't have a username]

Originally Posted by Fаng

Are you serious?! That's the "Mana Problem" that everyone who uses LOTF brags about fixing?!

No. The original LOTF didn't even have mana.

[Spirited]

Originally Posted by I don't have a username

No. The original LOTF didn't even have mana.

*exhales* Mk... that sounds a bit more understandable of a problem.
I can see how the problem could be overwhelming for some people that don't know how to break it down into manageable steps.

[macht102]

any hints to where i should put this check?

[pro4never]

Personally I'd write an accessor for mana which makes sure it never goes negative...

example..

public ushort Mana
{
get {return _mana;}
set{if(value < 0) value = 0; _mana = value;}
}
}

[macht102]

ok now the problem is mana doesnt decrease after casting a spell

even if i do this for example under public void UseSkill

if (SkillId == 1000)
{
if (SkillLvl == 0)
{
if (CurMP >= 1)
{
CurMP -= 1;
MyClient.SendPacket(General.MyPackets.Vital(UID, 2, CurMP));
}
else
{
MyClient.SendPacket(General.MyPackets.SendMsg(MyCl ient.MessageId, "SYSTEM", Name, "You do not have enough mana to cast this spell!", 2005));
}
}

[Spirited]

Originally Posted by pro4never

Personally I'd write an accessor for mana which makes sure it never goes negative...

example..

public ushort Mana
{
get {return _mana;}
set{if(value < 0) value = 0; _mana = value;}
}
}

^
Is a better answer. That way you only have to write the check once and forget about it.

[I don't have a username]

Originally Posted by Fаng

^
Is a better answer. That way you only have to write the check once and forget about it.

You would be amazed how **** the 5017 lotf source is.

@OP If you really want to use 5017, then use Hybrids base or if you seek one with a bit features, then find Arco's version of it.

[Lateralus]

Originally Posted by pro4never

Personally I'd write an accessor for mana which makes sure it never goes negative...

example..

public ushort Mana
{
get {return _mana;}
set{if(value < 0) value = 0; _mana = value;}
}
}

If he's going to do that, he's going to have to cast the (implicitly casted) int to a ushort before setting the value, which means that the value will never be < 0 and he'd have the same problem he has now. I'd also suggest using Math.Max... It looks cleaner, is probably inlined, and does the exact same thing.

[Arco.]

Originally Posted by I don't have a username

@OP If you really want to use 5017, then use Hybrids base or if you seek one with a bit features, then find Arco's version of it.

Remember its not mine. I don't have the talent to make something like that.