[Question] The purpose of this is...?

[Spirited42]

            if (_cryptKey1 != null)
            {
                [COLOR="Red"]if (_cryptKey1.Length != 0)[/COLOR]
                    return;
            }

What's the purpose of this line in red?
If the key isn't null... then the length cannot be 0... so why does it check that?

Sincerely,
Spirited

[Korvacs]

Null simple means undefined in the majority of cases, Length indicates the number of values within it, or if its a string, the string is empty, but not null.

Very different things.

[Spirited42]

Originally Posted by Korvacs

Null simple means undefined in the majority of cases, Length indicates the number of values within it, or if its a string, the string is empty, but not null.

Very different things.

I thought that you couldn't put values into an undefined variable though.

[Korvacs]

Originally Posted by Spirited

I thought that you couldn't put values into an undefined variable though.

Correct.........

Sorry just noticed the not equal, i believe this may have been an attempt to compensate for bad threading in whichever source your looking at.

Actually that makes even less sense, whats this from? If the key isnt null, then it has been defined, but that doesnt mean it has values within it.

[Spirited42]

Originally Posted by Korvacs

Correct.........

Sorry just noticed the not equal, i believe this may have been an attempt to compensate for bad threading in whichever source your looking at.

Actually that makes even less sense, whats this from? If the key isnt null, then it has been defined, but that doesnt mean it has values within it.

It's from Impulse's Public source. I'm using it as a very rough guide for my Cryptography.

[-impulse-]

It's actually really easy.

That stops the function PrepareAuthCryptography() from re-generating the keys.

if (_cryptKey1 != null)
{
if (_cryptKey1.Length != 0)
return;
}

The second 'if' can be removed, it will be exactly the same.

[Spirited42]

Originally Posted by -impulse-

It's actually really easy.

That stops the function PrepareAuthCryptography() from re-generating the keys.

if (_cryptKey1 != null)
{
if (_cryptKey1.Length != 0)
return;
}

The second 'if' can be removed, it will be exactly the same.

K, just making sure it isn't something with a meaning that I'm not aware of.

EDIT: You have a lot of things like that in your code Impulse... o.o

string IP = wr._socket.RemoteEndPoint.[COLOR="Red"]ToString()[/COLOR].Split(':')[0].[COLOR="Red"]ToString()[/COLOR];

[Korvacs]

You should use the cryptographer from my cuosp project, its very good.

[-impulse-]

Originally Posted by Spirited

string IP = wr._socket.RemoteEndPoint.[COLOR="Red"]ToString()[/COLOR].Split(':')[0].[COLOR="Red"]ToString()[/COLOR];

socket.RemoteEndPoint is not a string and so you have to use ToString to parse it. The second ToString, again, can be removed lol.

[Spirited42]

Originally Posted by Korvacs

You should use the cryptographer from my cuosp project, its very good.

Weird. I never got the chance to look at yours. It looks just like mine (Account Cryp). Mine works fine though. I haven't had an error since I completed it so I've kinda just stuck with it and just rewrote it using other influences (such as Impulse's crypt).

Originally Posted by -impulse-

socket.RemoteEndPoint is not a string and so you have to use ToString to parse it. The second ToString, again, can be removed lol.

Thanks. lol, but you don't have to explain things like that to me. I learned that in my first month of coding... ._.

[-impulse-]

Originally Posted by Spirited

Weird. I never got the chance to look at yours. It looks just like mine (Account Cryp). Mine works fine though. I haven't had an error since I completed it so I've kinda just stuck with it and just rewrote it using other influences (such as Impulse's crypt).



Thanks. lol, but you don't have to explain things like that to me. I learned that in my first month of coding... ._.

You know, you're not the only one to read whatever anyone posts, there are usually hundreds...and not everyone knows.

[Spirited42]

Originally Posted by -impulse-

You know, you're not the only one to read whatever anyone posts, there are usually hundreds...and not everyone knows.

Sorry, I didn't think about that.

[_tao4229_]

int[] i = new int[0];

Non null array with 0 length.

[-impulse-]

Originally Posted by _tao4229_

int[] i = new int[0];

Non null array with 0 length.

I know, I thought of that too, but the array is initialized with the length 0x100 so the second 'if' is really useless.

[_tao4229_]

Originally Posted by -impulse-

I know, I thought of that too, but the array is initialized with the length 0x100 so the second 'if' is really useless.

Under that assumption then the first if is "really useless" as well.