Aktuellster Firefox Installer Download

[only_blame]

Hi!

Also, meine Funktion gibt den Downloadlink der aktuellsten Firefox Version zurück, klappt auch sehr gut nur dauert es 'relativ' lange und der Code ist auch ziemlich lang. Habe Sie hier gleich mit einer Testausgabe versehen.
Also meine Frage an euch: Jemand eine Idee wie es besser klappt oder/und den Code kürzen?

 Spoiler

$URL = firefoxlink()
MsgBox(64,"Info", $URL)



Func firefoxlink()
$Hilf = "0"
$standard = "http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/Firefox Setup "
$zweite = "0"
$dritte = "0"
$null = "23"
$version = $null & "." & $zweite & "." & $dritte & ".exe"
$complete = $standard & $version

while InetGetSize($complete) = "0" and $Hilf = "0"                                     ;1


   if $zweite = 9 Then                                                    ;4
      $dritte = 0
      $zweite = 0
      $null = $null + 1
      if InetGetSize($standard & $null & ".0.exe") > 0 then $Hilf = "1"
   Else                                                                    ;4
      EndIf                                                                ;4
   if $dritte = 9 Then                                                    ;3
      $dritte = 0
      $zweite = $zweite + 1
      if InetGetSize($standard & $null & "." & $zweite & ".exe") > 0 then $Hilf = "2"
   Else                                                                    ;3
      EndIf                                                                ;3
$dritte = $dritte + 1
$version = $null & "." & $zweite & "." & $dritte & ".exe"
$complete = $standard & $version
WEnd
                                                                    ;1
if $Hilf = "1" then 
$version = $null & "." & "0.exe"
$complete = $standard & $version
EndIf

if $Hilf = "2" then 
$version = $null & "." & $zweite & ".exe"
$complete = $standard & $version
EndIf

if InetGetSize($complete) = "0" then                                    ;2
MsgBox(4096, "NICHT VORHANDEN!", "ist nicht da" & "   " & $complete)
Else                                                                    ;2
   return $complete
EndIf                                                                ;2


    EndFunc

Vielen Dank für Die Hilfe im vorraus!

Mit freundlichen Grüßen,
blame

[alpines]

Sehr schön, poste die Fragen in mehreren Foren damit du auch schneller eine Antwort bekommst, die Code-Einrückung ist grausam und lern wie man Arrays verwendet, dann sparst du auch mehr Zeilen.

Es ist vorallem dumm einfach die Versionsnummern durchzuprobieren, stattdessen könntest du per INetGet oder FTP auf die Webseite

http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/

zugreifen und mittelts

StringInStr
_StringBetween()
StringRegExp

die Versionsnummer extrahieren, das geht ruckzuck und in weniger als einer Sekunde.

[berkay2578]

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#include <String.au3>
#include <Clipboard.au3>

$Form1 = GUICreate("Firefox DL", 194, 65, 192, 124)
$genBTN = GUICtrlCreateButton("Generate Link", 8, 32, 83, 25)
$urlTXT = GUICtrlCreateInput("", 8, 8, 177, 21)
$clCHK = GUICtrlCreateCheckbox("Auto Clipboard", 96, 36, 89, 17)
GUICtrlSetState(-1, $GUI_CHECKED)
GUISetState(@SW_SHOW)

While 1
	$nMsg = GUIGetMsg()
	Switch $nMsg
		Case $GUI_EVENT_CLOSE
			Exit
		Case $genBTN
			GUICtrlSetData($urlTXT, GenerateLink("de"))
			If GUICtrlRead($clCHK) = $GUI_CHECKED Then _ClipBoard_SetData(GUICtrlRead($urlTXT))
	EndSwitch
WEnd

Func GenerateLink($language)
	$sData = BinaryToString(InetRead("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/" & $language & "/"))
	$version = _StringBetween($sData, ">Firefox Setup", "</a>")
	$fullLINK = ("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/" & $language & "/Firefox Setup" & $version[0])
	Return $fullLINK
EndFunc

This will automatically get a link for the latest Firefox Setup

PS: You can change the language ex: GenerateLink("en-GB") will generate a link for the UK English Version

[only_blame]

Sorry, das war nicht die Absicht.
Dankeschön, werde ich ausprobieren und hier posten

wow berkay2578, werde ich gleich mal testen

[lolkop]

wie bereits beschrieben lässt sich das ganze simpel als zweizeiler aufbauen:

Func GetLink()
	$link = StringRegExp(BinaryToString(InetRead("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/")), "(Firefox Setup.*?.exe)", 1)
	Return "http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/"&$link[0]
EndFunc

[c0w]

sei alpines ned böse, aber er hat schon recht das multiposting, oder falsche threadnamen machens leuten wie ihm die gern helfen ned unbedingt leichter ich denke mal die passende antwort hast du ja jetzt

[berkay2578]

Originally Posted by lolkop

wie bereits beschrieben lässt sich das ganze simpel als zweizeiler aufbauen:

Func GetLink()
	$link = StringRegExp(BinaryToString(InetRead("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/")), "(Firefox Setup.*?.exe)", 1)
	Return "http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/"&$link[0]
EndFunc

I wrote it like that so that he could understand how it works.. also you're overloading the regexp, it will not work from time to time.

[lolkop]

Originally Posted by berkay2578

I wrote it like that so that he could understand how it works.. also you're overloading the regexp, it will not work from time to time.

what is "overloading" of regex? o0

regular expression can allways be used on strings... the only reason for fails might be changes in naming of files or a missing internet connection (which would also cause a crash in your script).

to be 100% sure to not produce a script crash, you could add an "error catching line" like this:

Func GetLink()
	$link = StringRegExp(BinaryToString(InetRead("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/")), "(Firefox Setup.*?.exe)", 1)
	If Not IsArray($link) Then Return -1
	Return "http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/"&$link[0]
EndFunc

[berkay2578]

Originally Posted by lolkop

what is "overloading" of regex? o0

regular expression can allways be used on strings... the only reason for fails might be changes in naming of files or a missing internet connection (which would also cause a crash in your script).

to be 100% sure to not produce a script crash, you could add an "error catching line" like this:

Func GetLink()
	$link = StringRegExp(BinaryToString(InetRead("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/")), "(Firefox Setup.*?.exe)", 1)
	If Not IsArray($link) Then Return -1
	Return "http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/de/"&$link[0]
EndFunc

First parameter of the regexp function should be a static string. If you use another function like InetRead for it directly regexp will return 0 from time to time aka overload.
Also, why not just use @SetError?

[lolkop]

Originally Posted by berkay2578

First parameter of the regexp function should be a static string. If you use another function like InetRead for it directly regexp will return 0 from time to time aka overload.
Also, why not just use @SetError?

an empty string is just a normal string... there's absolutely no problem with it...

beside that your code:

Func GenerateLink($language)
	$sData = BinaryToString(InetRead("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/" & $language & "/"))
	$version = _StringBetween($sData, ">Firefox Setup", "</a>")
	$fullLINK = ("http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/" & $language & "/Firefox Setup" & $version[0])
	Return $fullLINK
EndFunc

is EXACTLY the same... it will also use an empty string as input for stringregexp if $sData is empty...

[berkay2578]

Originally Posted by lolkop

an empty string is just a normal string... there's absolutely no problem with it...

This is AutoIT, not a managed language. Just saying..

Originally Posted by lolkop

beside that your code:

is EXACTLY the same... it will also use an empty string as input for stringregexp if $sData is empty...

Maybe because I wrote that so that he could understand the basics and not deal with miscellaneous stuff?