[FIRST Release]PK Quest 5165

xScott · 01/15/2010, 01:16

I thought this small quest i made was a decent idea.

What you have to do is if you get 200PKPoints, you get rewarded 21500 CPs
After you have claimed the reward your PKPoints are reduced down to 0 and can only be claimed once a day

(Im unsure about adding the variable in Character.cs? Do i have to add it anywhere else? or is that right? im still learning C# >.>)

In Character.cs under

Code:

        public byte LotteryUsed = 0;

Put this

Code:

        public byte PKPQuestUsed = 0;

Now in NPCDialog.cs

Search for

Code:

default:

Above that put this

Code:

                            #region PKPQuest
                            case 66437:
                                {
                                    if (Control == 0)
                                    {
                                        GC.AddSend(Packets.NPCSay("Hey, Do you enjoy Pking? Why not get rewarded for it? "));
                                        GC.AddSend(Packets.NPCSay("Go get 200 Pk Points and ill give you some CPs! "));
                                        GC.AddSend(Packets.NPCSay("This quest is only available Once a day!"));
                                        GC.AddSend(Packets.NPCLink("Lets do it!", 1));
                                        GC.AddSend(Packets.NPCLink("Just passing by.", 255));
                                        GC.AddSend(Packets.NPCSetFace(N.Avatar));
                                        GC.AddSend(Packets.NPCFinish());
                                    }

                                    if(Control == 1)

                                    {
                                        if (GC.MyChar.PKPoints >= 200 && GC.MyChar.PKPQuestUsed == 0)
                                        {
                                                GC.MyChar.PKPQuestUsed++;
                                                GC.MyChar.CPs += 21500;
                                                GC.MyChar.PKPoints = 0;
                                                GC.AddSend(Packets.NPCSay("There you go! Go kill some more people and comeback tommorow for more CPs!"));
                                                GC.AddSend(Packets.NPCLink("Thanks!", 255));
                                                GC.AddSend(Packets.NPCSetFace(N.Avatar));
                                                GC.AddSend(Packets.NPCFinish());
                                        }
                                        else
                                        {
                                            GC.AddSend(Packets.NPCSay("You havent got 200 PK Points or already have done this quest!"));
                                            GC.AddSend(Packets.NPCLink("Sorry.", 255));
                                            GC.AddSend(Packets.NPCSetFace(N.Avatar));
                                            GC.AddSend(Packets.NPCFinish());
                                        }
                                    }                                       
                                    break;
                                }
                                
                            #endregion

In OldCODB in NPC.txt add this

Code:

66437 8110 2 0 1002 422 367

coreymills · 01/15/2010, 01:29

pretty good i'll give a thanks but i'm not using it.

~~pro4never~~ · 01/15/2010, 01:37

Dumb question: Why are you using pk points instead of another score system?

By using pk points (and then lowering to 0) you make it possible for black name/high pk point characters to instantly go back to 0 pk points every day making pk points completely pointless...

Personally I would use a hashtable to link character uid to a score and add to that score every time they kill someone while the quest is active. I assume this is across the entire game? If so you could simply have pk points not be added if they are pking while the quest is active but it still seems to me like this would destroy the pvp system controlling behavior in non free pk zones...

*note* Nvm after actually checking over the code (I thought there was more under what I saw :P) I realize that this is intended for a full pvp/command server to reward pking in non-pk free zones... still seems a bit odd to me but hopefully people will enjoy it.

<note> You will need a system to reset the quest daily.. I would, instead of using a int to control if quest has been done or not, add to the character table saving the date/time when the quest was last done, then do a datetime + day check to see if it has been more than a day since it was last finished, if so allow quest and reset the datetime in the database...

as it is right now, you are using an int for a primarily bool function (true/false) and not resetting it (meaning char can only ever do it once)

Not flaming, just offering some constructive criticism.

xScott · 01/15/2010, 01:44

Quote:

Originally Posted by pro4never

Dumb question: Why are you using pk points instead of another score system?

By using pk points (and then lowering to 0) you make it possible for black name/high pk point characters to instantly go back to 0 pk points every day making pk points completely pointless...

Personally I would use a hashtable to link character uid to a score and add to that score every time they kill someone while the quest is active. I assume this is across the entire game? If so you could simply have pk points not be added if they are pking while the quest is active but it still seems to me like this would destroy the pvp system controlling behavior in non free pk zones...

*note* Nvm after actually checking over the code (I thought there was more under what I saw :P) I realize that this is intended for a full pvp/command server to reward pking in non-pk free zones... still seems a bit odd to me but hopefully people will enjoy it.

<note> You will need a system to reset the quest daily.. I would, instead of using a int to control if quest has been done or not, add to the character table saving the date/time when the quest was last done, then do a datetime + day check to see if it has been more than a day since it was last finished, if so allow quest and reset the datetime in the database...

as it is right now, you are using an int for a primarily bool function (true/false) and not resetting it (meaning char can only ever do it once)

Not flaming, just offering some constructive criticism.

Haha thanks for the feedback, you mentioned a hashtable? were talking to a noob at coding here xD ive seen hashtables from one of the tutorials by Infamous i think,

the lottery NPC uses the same system? resets everyday?
ill see if i can use that as a template or something.

thanks for your feedback =]

~~pro4never~~ · 01/15/2010, 01:47

Hashtables are a very simple structure to hold values.

Eg: Link player id with a number

That way when you invoke one, you get the other. It's useful for holding scores and all sorts of other systems

I have some examples in my siggy that you may find useful (it's not for 5165 but they are the same thing really, just need to change around a few things)

<Edit> *** I hate dictionaries sooo much >.< I just can't seem to understand them atm.

xScott · 01/15/2010, 01:51

Quote:

Originally Posted by pro4never

Hashtables are a very simple structure to hold values.

Eg: Link player id with a number

That way when you invoke one, you get the other. It's useful for holding scores and all sorts of other systems

I have some examples in my siggy that you may find useful (it's not for 5165 but they are the same thing really, just need to change around a few things)

<Edit> *** I hate dictionaries sooo much >.< I just can't seem to understand them atm.

alright ill look into it and rerelease it if i manage to sort it out =]

-Shunsui- · 01/15/2010, 02:03

yeah, Like Pro4Never said your gona need something to Restart the PkQuestUsed Per Day, Check Arround where the spot on wich your Pk points Drop Per Each minutes or w,e and take the code from arround there or the idea and add it in. you can work something out by looking at the Code for pkp points drop

.Ryu · 01/15/2010, 02:41

Good job =P

Arcо · 01/15/2010, 05:25

Good release.
Glad to see you are improving xScott.

ImmuneOne · 01/15/2010, 14:08

Code:

[B]bool PkQuestUsed = false;
if (PkQuestUsed)
{

}[/B]

Why use an integer instead of a boolean?

xScott · 01/15/2010, 21:08

Quote:
Originally Posted by ImmuneOne
Code:
[B]bool PkQuestUsed = false;
if (PkQuestUsed)
{

}[/B]
Why use an integer instead of a boolean?

thats a good point, after seeing the lottery Int i thought use int, but cos its only allowed once Bool is probs better :S

spare2 · 01/16/2010, 01:25

Quote:
Originally Posted by ImmuneOne
Code:
[B]bool PkQuestUsed = false;
if (PkQuestUsed)
{

}[/B]
Why use an integer instead of a boolean?

I think he wants to count how many PK Quest the character did.

xScott · 01/16/2010, 01:35

Quote:

Originally Posted by spare2

I think he wants to count how many PK Quest the character did.

nah that was to check if the reward has already been claimed lol
ive been looking up hashtables gonna see if i can do what pro suggested.