Npc not working correctly

10/10/2010 08:48 biohazardous#1
hes not selling the items what did i code wrong
he just takes the money and sometimes he says you dont have enough but i have 99999999cps
and when it does work nothing is in my inventory
for some reason though this code has no errors
Edit: Can Someone at least give me the code for +12 2 soc items for tanels source
Edit2: il just figure it out nvm thanks everyone....
Code:
#region Kid Seller
    case 4466:
    {
        if (Control == 0)
        {
                GC.AddSend(Packets.NPCSay("Welcome to the Valhalla Legends Market - I'll give you stuff for a fee. I am one of bios Legendary Npcs!"));
                GC.AddSend(Packets.NPCLink("Cool let me in.", 1));
                GC.AddSend(Packets.NPCLink("Haa Ok Then", 255));
                GC.AddSend(Packets.NPCSetFace(N.Avatar));
                GC.AddSend(Packets.NPCFinish());
        }
            if (Control == 1)
            {
            GC.AddSend(Packets.NPCSay("I can gift you with some gear of specified profesion"));
            GC.AddSend(Packets.NPCLink("FireTao-100kCps", 2));
            GC.AddSend(Packets.NPCLink("WaterTao-100kCps", 3));
            GC.AddSend(Packets.NPCLink("Warrior-100kCps", 5));
            GC.AddSend(Packets.NPCLink("Trojan-100kCps", 6));
            GC.AddSend(Packets.NPCLink("Archer-100kCps", 4));
            GC.AddSend(Packets.NPCLink("Ninja-100kCps", 7));
            GC.AddSend(Packets.NPCLink("Woah Too Much.", 255));
            GC.AddSend(Packets.NPCSetFace(15));
            GC.AddSend(Packets.NPCFinish());
        }
        else if (GC.MyChar.Inventory.Count < 20)             

        {
            if (Control == 2)
            {
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(114109 - 12 - 7 - 255 - 3 - 3);//Head Gear
                    GC.MyChar.AddItem(421339 - 12 - 7 - 255 - 3 - 3);//BackSword
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 3 - 3);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 3 - 3);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 3 - 3);//Boots
                    GC.MyChar.AddItem(134109 - 12 - 7 - 255 - 3 - 3);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough money."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
            }
            else if (Control == 3)
            {
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(114109 - 12 - 7 - 255 - 13 - 13);//Head Gear
                    GC.MyChar.AddItem(560339 - 12 - 7 - 255 - 13 - 13);//Spear
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 13 - 13);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 13 - 13);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 13 - 13);//Boots
                    GC.MyChar.AddItem(134109 - 12 - 7 - 255 - 13 - 13);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough money."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
            }
            else if (Control == 4)
            {
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(142109 - 12 - 7 - 255 - 13 - 13);//Head Gear
                    GC.MyChar.AddItem(500329 - 12 - 7 - 255 - 13 - 13);//Bow
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 13 - 13);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 13 - 13);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 13 - 13);//Boots
                    GC.MyChar.AddItem(133109 - 12 - 7 - 255 - 13 - 13);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough money."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
            }
            if (Control == 5)
            {
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(141109 - 12 - 7 - 255 - 13 - 13);//Head Gear
                    GC.MyChar.AddItem(480339 - 12 - 7 - 255 - 13 - 13);//Club
                    GC.MyChar.AddItem(410339 - 12 - 7 - 255 - 13 - 13);//Blade
                    GC.MyChar.AddItem(420339 - 12 - 7 - 255 - 13 - 13);//Sword
                    GC.MyChar.AddItem(900109 - 12 - 7 - 255 - 13 - 13);//Shield
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 13 - 13);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 13 - 13);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 13 - 13);//Boots
                    GC.MyChar.AddItem(131109 - 12 - 7 - 255 - 13 - 13);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough Cps."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
            }
            else if (Control == 6)
            {
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(118109 - 12 - 7 - 255 - 13 - 13);//Head Gear
                    GC.MyChar.AddItem(480339 - 12 - 7 - 255 - 13 - 13);//Club
                    GC.MyChar.AddItem(410339 - 12 - 7 - 255 - 13 - 13);//Blade
                    GC.MyChar.AddItem(420339 - 12 - 7 - 255 - 13 - 13);//Sword
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 13 - 13);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 13 - 13);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 13 - 13);//Boots
                    GC.MyChar.AddItem(130109 - 12 - 7 - 255 - 13 - 13);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough Cps."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
            }
            else if (Control == 7)
            {
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(123109 - 12 - 7 - 255 - 13 - 13);//Head Gear
                    GC.MyChar.AddItem(601339 - 12 - 7 - 255 - 13 - 13);//Katana
                    GC.MyChar.AddItem(601339 - 12 - 7 - 255 - 13 - 13);//Katana
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 13 - 13);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 13 - 13);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 13 - 13);//Boots
                    GC.MyChar.AddItem(135109 - 12 - 7 - 255 - 13 - 13);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough Cps."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
            }
        }

        else
        {
            GC.AddSend(Packets.NPCSay("Your inventory is more than 20."));
            GC.AddSend(Packets.NPCLink("I see.", 255));
            GC.AddSend(Packets.NPCSetFace(N.Avatar));
            GC.AddSend(Packets.NPCFinish());
        }
        break;
    }
    #endregion
10/10/2010 23:34 .Beatz#2
Try this as an example.

Code:
#region Kid Seller
    case 4466:
    {
        if (Control == 0)
        {
                GC.AddSend(Packets.NPCSay("Welcome to the Valhalla Legends Market - I'll give you stuff for a fee. I am one of bios Legendary Npcs!"));
                GC.AddSend(Packets.NPCLink("Cool let me in.", 1));
                GC.AddSend(Packets.NPCLink("Haa Ok Then", 255));
                GC.AddSend(Packets.NPCSetFace(N.Avatar));
                GC.AddSend(Packets.NPCFinish());
        }
            if (Control == 1)
            {
            GC.AddSend(Packets.NPCSay("I can gift you with some gear of specified profesion"));
            GC.AddSend(Packets.NPCLink("FireTao-100kCps", 2));
            GC.AddSend(Packets.NPCLink("WaterTao-100kCps", 3));
            GC.AddSend(Packets.NPCLink("Warrior-100kCps", 5));
            GC.AddSend(Packets.NPCLink("Trojan-100kCps", 6));
            GC.AddSend(Packets.NPCLink("Archer-100kCps", 4));
            GC.AddSend(Packets.NPCLink("Ninja-100kCps", 7));
            GC.AddSend(Packets.NPCLink("Woah Too Much.", 255));
            GC.AddSend(Packets.NPCSetFace(15));
            GC.AddSend(Packets.NPCFinish());
        }     
        {
            if (Control == 2)
            {
 if (GC.MyChar.Inventory.Count < 20)
{
                if (GC.MyChar.CPs >= 100000)
                {
                    GC.MyChar.CPs -= 100000;
                    GC.MyChar.AddItem(114109 - 12 - 7 - 255 - 3 - 3);//Head Gear
                    GC.MyChar.AddItem(421339 - 12 - 7 - 255 - 3 - 3);//BackSword
                    GC.MyChar.AddItem(120249 - 12 - 7 - 255 - 3 - 3);//Necklace
                    GC.MyChar.AddItem(150249 - 12 - 7 - 255 - 3 - 3);//Ring
                    GC.MyChar.AddItem(160249 - 12 - 7 - 255 - 3 - 3);//Boots
                    GC.MyChar.AddItem(134109 - 12 - 7 - 255 - 3 - 3);//Armor
                    GC.MyChar.AddItem(201009 - 12 - 1 - 0 - 123 - 123);//HeavenFan
                    GC.MyChar.AddItem(202009 - 12 - 1 - 0 - 103 - 103);//StarTower
                    GC.AddSend(Packets.NPCSay("Congratz."));
                    GC.AddSend(Packets.NPCLink("Thanks.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
                }
                 else
                {
                    GC.AddSend(Packets.NPCSay("You don't have enough money."));
                    GC.AddSend(Packets.NPCLink("I see.", 255));
                    GC.AddSend(Packets.NPCSetFace(N.Avatar));
                    GC.AddSend(Packets.NPCFinish());
}
else
{
            GC.AddSend(Packets.NPCSay("Your inventory is more than 20."));
            GC.AddSend(Packets.NPCLink("I see.", 255));
            GC.AddSend(Packets.NPCSetFace(N.Avatar));
            GC.AddSend(Packets.NPCFinish());
        }
              }
                break;
            }
if you have problems add me on msn and I will TV or something and fix it for you.
10/11/2010 02:23 Arcо#3
PHP Code:
#region Kid Seller
case 4466:
switch(
Control)
{
case 
0:
GC.AddSend(Packets.NPCSay("Welcome to the Valhalla Legends Market - I'll give you stuff for a fee. I am one of bios Legendary Npcs!"));
GC.AddSend(Packets.NPCLink("Cool let me in."1));
GC.AddSend(Packets.NPCLink("Haa Ok Then"255));
GC.AddSend(Packets.NPCSetFace(N.Avatar));
GC.AddSend(Packets.NPCFinish());
break
case 
1:
if (
GC.MyChar.Inventory.count 20 && GC.MyChar.CPs 99999)
{
GC.AddSend(Packets.NPCSay("I can gift you with some gear of specified profesion"));
GC.AddSend(Packets.NPCLink("FireTao-100kCps"2));
GC.AddSend(Packets.NPCLink("WaterTao-100kCps"3));
GC.AddSend(Packets.NPCLink("Warrior-100kCps"5));
GC.AddSend(Packets.NPCLink("Trojan-100kCps"6));
GC.AddSend(Packets.NPCLink("Archer-100kCps"4));
GC.AddSend(Packets.NPCLink("Ninja-100kCps"7));
GC.AddSend(Packets.NPCLink("Woah Too Much."255));
GC.AddSend(Packets.NPCSetFace(15));
GC.AddSend(Packets.NPCFinish());
}
else
{
GC.AddSend(Packets.NPCSay("Please check your inventory space and amount of CPs. You need at least 20 free spaces and 100,000 CPs"));
GC.AddSend(Packets.NPCLink("I see."255));
GC.AddSend(Packets.NPCSetFace(N.Avatar));
GC.AddSend(Packets.NPCFinish());
}
break;
case 
2:
break;
case 
3:
break;
case 
4:
break;
case 
5:
break;
case 
6:
break;
case 
7:
break;
}
break;
#endregion 
Give that a go, just fill case 2-7, with the function you want them to do.
10/11/2010 03:28 biohazardous#4
Quote:
Originally Posted by Аrco View Post
PHP Code:
#region Kid Seller
case 4466:
switch(
Control)
{
case 
0:
GC.AddSend(Packets.NPCSay("Welcome to the Valhalla Legends Market - I'll give you stuff for a fee. I am one of bios Legendary Npcs!"));
GC.AddSend(Packets.NPCLink("Cool let me in."1));
GC.AddSend(Packets.NPCLink("Haa Ok Then"255));
GC.AddSend(Packets.NPCSetFace(N.Avatar));
GC.AddSend(Packets.NPCFinish());
break
case 
1:
if (
GC.MyChar.Inventory.count 20 && GC.MyChar.CPs 99999)
{
GC.AddSend(Packets.NPCSay("I can gift you with some gear of specified profesion"));
GC.AddSend(Packets.NPCLink("FireTao-100kCps"2));
GC.AddSend(Packets.NPCLink("WaterTao-100kCps"3));
GC.AddSend(Packets.NPCLink("Warrior-100kCps"5));
GC.AddSend(Packets.NPCLink("Trojan-100kCps"6));
GC.AddSend(Packets.NPCLink("Archer-100kCps"4));
GC.AddSend(Packets.NPCLink("Ninja-100kCps"7));
GC.AddSend(Packets.NPCLink("Woah Too Much."255));
GC.AddSend(Packets.NPCSetFace(15));
GC.AddSend(Packets.NPCFinish());
}
else
{
GC.AddSend(Packets.NPCSay("Please check your inventory space and amount of CPs. You need at least 20 free spaces and 100,000 CPs"));
GC.AddSend(Packets.NPCLink("I see."255));
GC.AddSend(Packets.NPCSetFace(N.Avatar));
GC.AddSend(Packets.NPCFinish());
}
break;
case 
2:
break;
case 
3:
break;
case 
4:
break;
case 
5:
break;
case 
6:
break;
case 
7:
break;
}
break;
#endregion 
Give that a go, just fill case 2-7, with the function you want them to do.
Got it figured out(not by me) but thanks anyway arco i found out my source is coded differently than yours but use tanels system still
Could you please Close this thread Arco :)
10/11/2010 05:47 -diRt#5
Quote:
Originally Posted by biohazardous View Post
Got it figured out(not by me) but thanks anyway arco i found out my source is coded differently than yours but use tanels system still
Could you please Close this thread Arco :)
He cannot, he is not a moderator in this section.