[RELEASE] anti speed hack

02/07/2020 01:24 redbull2905#1

System to improve but i release the code basic

Code:

 #region speed packet //put character.cs
                if (Session.Character.Authority == AuthorityType.User)
                {
                    if (Speed > 24)
                    {
                        var oBanPacket = new CommandPackets.BanPacket();
                        oBanPacket.CharacterName = Name;
                        oBanPacket.Duration = 5475; // Duration in Days
                        oBanPacket.Reason = "speed hack";
                        Ban(DateTime.Now.AddDays(oBanPacket.Duration), oBanPacket.Reason);

                        Session = null;
                        return;
                    }

                    if (VehicleSpeed > 34)
                    {
                        var oBanPacket = new CommandPackets.BanPacket();
                        oBanPacket.CharacterName = Name;
                        oBanPacket.Duration = 5475; // Duration in Days
                        oBanPacket.Reason = "speed hack";
                        Ban(DateTime.Now.AddDays(oBanPacket.Duration), oBanPacket.Reason);

                        Session = null;
                        return;
                    }
                }
              
                #endregion

02/07/2020 03:29 Apourtartt#2

what happens if my magician, who has 10 movespeed is sending the walk packet with 24 ?
Same for vehicle btw. Shouldn't you just check for his serverside speed instead of 24/34 ?

02/07/2020 08:14 Blowa#3

1/ the walk packet handling is supposed to handle that "anti hack" calculation
2/ Character object is supposed to be a data holder and no processing logic should be in it
3/ Obviously you like to copy paste code you don't understand at all, you are instantiating 2 objects (luckily, the compiler is not stupid enough to instantiate it cause he sees you are not using it) without using the point of an object.

As always, all your so called "releases" are useless bullshit code that gives more and more unmaintainable shit to OpenNos.

02/07/2020 11:11 OneFriend#4

Quote:

Originally Posted by val77

1/ the walk packet handling is supposed to handle that "anti hack" calculation
2/ Character object is supposed to be a data holder and no processing logic should be in it
3/ Obviously you like to copy paste code you don't understand at all, you are instantiating 2 objects (luckily, the compiler is not stupid enough to instantiate it cause he sees you are not using it) without using the point of an object.

As always, all your so called "releases" are useless bullshit code that gives more and more unmaintainable shit to OpenNos.

Should be more structured in general i guess?

I just took a look in OpenNos and saw that many thing's are handled wrong, if i'm not complete wrong?

(Or other dev's did just shit and pasted many bullshit (like in the character.cs, which he did..)

But let's come again to his "Code"...

I mean many Server's got vehicles which got more then 34 Speed..

Nice.. Let's move and get banned:notsureif:

Isn't there any other function which could check it?

PS : I'm a newbie in such thing's)

02/07/2020 22:01 Roxeez#5

Useless release as always :heyguys:
You just show us again that you don't understand a thing about what you're doing (funny from someone how is trying to sell sources)

02/07/2020 22:16 InnoTx#6

Quote:

Originally Posted by Roxeez

Useless release as always :heyguys:
You just show us again that you don't understand a thing about what you're doing (funny from someone how is trying to sell sources)

Hummmm....
You don't like PROFESSIONAL COPY PASTED SOURCE :notsureif:?

from RedBull2905

02/08/2020 02:00 Apourtartt#7

Quote:

Originally Posted by OneFriend

Should be more structured in general i guess?

I just took a look in OpenNos and saw that many thing's are handled wrong, if i'm not complete wrong?

(Or other dev's did just shit and pasted many bullshit (like in the character.cs, which he did..)

But let's come again to his "Code"...

I mean many Server's got vehicles which got more then 34 Speed..

Nice.. Let's move and get banned:notsureif:

Isn't there any other function which could check it?

PS : I'm a newbie in such thing's)

I don't know how is coded Opennos, but in theory :
- Your class Character is holding calculated (= server sided) speed.
- Packet walk is sending speed to your server
- if those two speeds are not equal, there is a problem : cheat or maybe lag

+ we can have a higher speed than 24 btw