[C++]Check Moving Item minor bug fix

03/12/2017 15:04 MrLibya#1
Hello :)

Most of u will ignore it ( even ymir did ) but there's somepeoples who love to keep it all clean , even the small non effect bug

Before fix the bug :
[Only registered and activated users can see links. Click Here To Register...]

After :
[Only registered and activated users can see links. Click Here To Register...]

#UPDATE
I've fix also fix this bug :
[Only registered and activated users can see links. Click Here To Register...]
and another bug related to inventory


To fix it :
Client Source / EterPythonLib/PythonGridSlotWindow.cpp
Serach for fucntion :
Code:
BOOL CGridSlotWindow::CheckMoving(DWORD dwSlotNumber, DWORD dwItemIndex, const std::list<TSlot*> & c_rSlotList)
replace with this :
Code:
BOOL CGridSlotWindow::CheckMoving(DWORD dwSlotNumber, DWORD dwItemIndex, const std::list<TSlot*> & c_rSlotList)
{
	if (m_dwSlotStyle != SLOT_STYLE_PICK_UP)
		return TRUE;

	for (std::list<TSlot*>::const_iterator itor = c_rSlotList.begin(); itor != c_rSlotList.end(); ++itor)
	{
		TSlot * pSlot = *itor;
		
		if (0 != pSlot->dwItemIndex || pSlot->dwCenterSlotNumber != pSlot->dwSlotNumber) // 아이템이 있고
		{
			if (dwItemIndex != pSlot->dwItemIndex || c_rSlotList.size() != 1) // 다른 아이템이면 못 옮김
				return false;
		}
	}

	return true;
}
Now Save and compile :)
03/12/2017 16:03 MaxChri#2
Esthetic fix on a high level. :) I like these kind of attention.
03/12/2017 17:02 EULOG1SON#3
Do you have any solution when you trying to move the item on the 1x slot at the top?
try with a 2 hand or 3 hand weapon and put it on the second slot and try to move it up, you can see the white slot but the weapon aren't able to move 1x slot up. (remove your fix first).

[Only registered and activated users can see links. Click Here To Register...]
03/12/2017 23:01 MrLibya#4
Quote:
Originally Posted by EULOG1SON View Post
Do you have any solution when you trying to move the item on the 1x slot at the top?
try with a 2 hand or 3 hand weapon and put it on the second slot and try to move it up, you can see the white slot but the weapon aren't able to move 1x slot up. (remove your fix first).

[Only registered and activated users can see links. Click Here To Register...]
I've fix it and update the topic , i also fix another bug related inventory
03/19/2017 23:36 MrLibya#5
Topic Updated
09/24/2017 16:24 xP3NG3Rx#6
Hello,

Here is an update for this fix, because it isnt' complete. If you are moving an item which size is > 1 onto the same item that makes false value.
Rubinum:
[Only registered and activated users can see links. Click Here To Register...]


Gallery


I didn't find any bugs, but if you will, feel free to explain how did you find it.
09/24/2017 23:02 .T4Ump#7
Quote:
Originally Posted by xP3NG3Rx View Post
Hello,

Here is an update for this fix, because it isnt' complete. If you are moving an item which size is > 1 onto the same item that makes false value.
Rubinum:
[Only registered and activated users can see links. Click Here To Register...]


Gallery


I didn't find any bugs, but if you will, feel free to explain how did you find it.
Omgg thanks boyyy
09/25/2017 19:22 HKwork#8
nice...
12/10/2017 14:01 jeddawee#9
Quote:
Originally Posted by xP3NG3Rx View Post
Hello,

Here is an update for this fix, because it isnt' complete. If you are moving an item which size is > 1 onto the same item that makes false value.
Rubinum:
[Only registered and activated users can see links. Click Here To Register...]


Gallery


I didn't find any bugs, but if you will, feel free to explain how did you find it.

In official, I can move the item x1 slot or x2 slot to up or down, but in your fix I'm not able to do that, only if I put the item in the first page of inventory I could only move the item down .


plz fix that






.
02/20/2018 10:47 x"Kazuki#10
Also bei mir funktioniert es nicht, hat jemand einen fix?
02/28/2018 11:35 pask94#11
nice
02/14/2022 16:33 dandiman22#12
you need swap sistem for this stupid guis