Quote:
Originally Posted by exelenze
I only have Classic installed.
You have since then fixed the correct version to install after I wrote that message.. Perhaps in the json/backend files you use, you might wanna rewrite the download so it does not use cache but ALWAYS retrieves fresh data no matter what
You are still checking those links before a user has set a path or even has pressed wanted to check for update and its still those old versions and that is for shadowlands?, why? I don't know?
This is during the startup where you echo the fetching addons data that takes time 3-5 seconds which make sense with the urls you are pulling
Video
[Only registered and activated users can see links. Click Here To Register...]
At 1.10 I start the program for the second time while having the other window open that shows you pull this data.
You also write this file every time on startup with unnecessary nuget logs :)
C:\temp\console-example-internal.log
Aslo may I suggest a autoclose window when update is done and as a bonus a little tiny windows beep as optional too, if its not too much to ask for :)
|
The reason it checks those links twice is because the first call is to determine if the link returns a 404 error, or any other type of error. If it does that, a fallback link will be chosen.
The second call is to get the file info from the link, such as the upload date.
Then it caches that data.
There's a reason I cache it throughout the lifetime of the program. It's like I said, it's so it doesn't make even more calls to those links unnecessarily when entering the install/update menu (such as when an update has installed, or when an addon is installed, it usually navigates back to the install menu, and triggers check for updates. That's why I cache it, because the user will usually just open the program, enter the install/update menu, and then update addons. Then finally close the app. There's no reason to keep checking for fresh data multiple times in the lifetime of the program, because it so short anyway. So I'm saving a few calls by doing it this way :-)
And whenever you open the program, it will always get fresh data. The cached data is only cached for the lifetime of the program.
However, I can rearrange some parts of the code so it only checks and caches data if the user has set a path, and only for the installed versions of WoW :-) Then it's a few less checks indeed, and it will speed up fetching addon data because it only checks and caches the link for the game's you have installed only :-)
About auto closing when update is done. There's already a feature that allows for that. It got introduced in v2.2 if I remember correctly. I just forgot to include the instructions in the latest post :-)
To get it to auto update and then close after, you have to run the program with the argument
-autoupdate.
About the log file. I don't personally write to it. I actually think that's a leftover file that I forgot to remove from the logger's config file :-)
I appreciate the feedback.
EDIT: Yeah I just checked, I forgot to remove the reference to the console-example-internal.log file.