[C++] Fix exp exploit

Quote:

Originally Posted by xP3NG3Rx

Override is true in r34k also:

Code:

            if ( v110 == 50183 )
            {
              v326 = CItem__GetValue(a2, 0);
              v327 = CItem__GetValue(a2, 1);
              v328 = CItem__GetValue(a2, 2);
              v329 = CItem__GetValue(a2, 3);
              CHARACTER__AddAffect(a1, 300, 19, v327, 12, v326, 0, 1, 1);
              CHARACTER__AddAffect(a1, 300, 114, v328, 0, v326, 0, 1, 1);
              CHARACTER__AddAffect(a1, 300, 116, v329, 0, v326, 0, 1, 1);
              v330 = CItem__GetCount(a2);
              CItem__SetCount(a2, v330 - 1);
              result = 1;
              goto LABEL_32;
            }

What makes you think that only Arabs used?
Other countries this event is unavailable or what? :)

There's no locale check about the use of 50183 (ITEM_RAMADAN_CANDY), but a "ramadan" item is tendentiously used by muslims.
If some german servers are using it, it will be just out-of-place, but nothing more.

By the way, the "ramadan_drop" event flag is commented in the server source by default. People must uncomment it if they want auto-drop the ramadan candy.

Talking about the fix, it's correct to say that there is a bug:
The affect override=true parameter will prevent the doubling of the bonuses, so there's no issue about it.
The actual problem is that you can use the candy again even if the affects didn't cooldown.

Even though it was already fixed in r34k, there's a possibility, if already implemented at that time, that it could have been as mrlibya said in r2089m or older. (bonus doubling)