[C++] Fix exp exploit

05/24/2016 16:27 MrLibya#1
Hallo All

That is fix for exploit that is only exist in arabic - turkey servers !

open char_item.cpp

search :


Code:
case ITEM_RAMADAN_CANDY:


add after
Code:
                                    if (FindAffect(AFFECT_RAMADAN_ABILITY))
                                    {
                                        ChatPacket(CHAT_TYPE_INFO, LC_TEXT("ہج¹ج ب؟°ْ°، °ة·ء ہض½ہ´د´ظ."));
                                        return false;
                                    }


it will looks like :

[Only registered and activated users can see links. Click Here To Register...]

have good day !
05/24/2016 18:45 Metin2 Team#2
well done :) and good timing Ramadan is close. :p
05/26/2016 12:59 Sphinx²#3
Quote:
Originally Posted by MrLibya View Post
Hallo All

That is fix for exploit that is only exist in arabic - turkey servers !

open char_item.cpp

search :


Code:
case ITEM_RAMADAN_CANDY:


add after
Code:
                                    if (FindAffect(AFFECT_RAMADAN_ABILITY))
                                    {
                                        ChatPacket(CHAT_TYPE_INFO, LC_TEXT("ہج¹ج ب؟°ْ°، °ة·ء ہض½ہ´د´ظ."));
                                        return false;
                                    }


it will looks like :

[Only registered and activated users can see links. Click Here To Register...]

have good day !
Hi,

"That is fix for exploit that is only exist in arabic - turkey servers !",
is there any locale check above?
It seems like this exploit also exists on german servers supporting the ramadan event.

GER: Auch die Deutschen Server haben dieses Problem.

Kind regards
Sphinx
05/26/2016 13:00 xP3NG3Rx#4
I do not understand, really.
What are you talking about? Exploit? Under what circumstances?
Your code is not bad, but the override parameter is true.
I was test right now, I used a lot of from this ramadan item but I did not found any problem.
05/26/2016 13:06 fcsk_aim#5
Quote:
Originally Posted by xP3NG3Rx View Post
I do not understand, really.
What are you talking about? Exploit? Under what circumstances?
Your code is not bad, but the override parameter is true.
I was test right now, I used a lot of from this ramadan item but I did not found any problem.
Same
05/26/2016 14:50 MrLibya#6
Quote:
Originally Posted by Sphinx² View Post
Hi,

"That is fix for exploit that is only exist in arabic - turkey servers !",
is there any locale check above?
It seems like this exploit also exists on german servers supporting the ramadan event.

GER: Auch die Deutschen Server haben dieses Problem.

Kind regards
Sphinx
i said arabic - turkey server cuz thos are who only use this event



Quote:
Originally Posted by xP3NG3Rx View Post
I do not understand, really.
What are you talking about? Exploit? Under what circumstances?
Your code is not bad, but the override parameter is true.
I was test right now, I used a lot of from this ramadan item but I did not found any problem.
in old files that has same bug , when i use the item and get 5% exp , then use it again u will get more exp bonus..etc

05/26/2016 15:42 xP3NG3Rx#7
Override is true in r34k also:
Code:
            if ( v110 == 50183 )
            {
              v326 = CItem__GetValue(a2, 0);
              v327 = CItem__GetValue(a2, 1);
              v328 = CItem__GetValue(a2, 2);
              v329 = CItem__GetValue(a2, 3);
              CHARACTER__AddAffect(a1, 300, 19, v327, 12, v326, 0, 1, 1);
              CHARACTER__AddAffect(a1, 300, 114, v328, 0, v326, 0, 1, 1);
              CHARACTER__AddAffect(a1, 300, 116, v329, 0, v326, 0, 1, 1);
              v330 = CItem__GetCount(a2);
              CItem__SetCount(a2, v330 - 1);
              result = 1;
              goto LABEL_32;
            }
What makes you think that only Arabs used?
Other countries this event is unavailable or what? :)
05/26/2016 16:59 MrLibya#8
Quote:
Originally Posted by xP3NG3Rx View Post
Override is true in r34k also:
Code:
            if ( v110 == 50183 )
            {
              v326 = CItem__GetValue(a2, 0);
              v327 = CItem__GetValue(a2, 1);
              v328 = CItem__GetValue(a2, 2);
              v329 = CItem__GetValue(a2, 3);
              CHARACTER__AddAffect(a1, 300, 19, v327, 12, v326, 0, 1, 1);
              CHARACTER__AddAffect(a1, 300, 114, v328, 0, v326, 0, 1, 1);
              CHARACTER__AddAffect(a1, 300, 116, v329, 0, v326, 0, 1, 1);
              v330 = CItem__GetCount(a2);
              CItem__SetCount(a2, v330 - 1);
              result = 1;
              goto LABEL_32;
            }
What makes you think that only Arabs used?
Other countries this event is unavailable or what? :)
cuz it's Muslims event and I didn't see german server has this event, just Arabic - turkey
05/26/2016 18:50 Sphinx²#9
Quote:
Originally Posted by MrLibya View Post
cuz it's Muslims event and I didn't see german server has this event, just Arabic - turkey
The german servers also support this event.
I'm not sure if this is really an exploit just saw that
"case ITEM_NOG_POCKET:" above also do this check.

edit:
AddAffect override parameter is true, so this just
give an error message if the affect already exists to avoid
that the player lose the item for an affect that is not expired.

Kind regards
Sphinx
05/26/2016 19:06 xP3NG3Rx#10
Yes, this was clear for (I hoped not only)me, I tried to figure out why thought this to an exploit, because this is not that.

Quote:
Originally Posted by MrLibya View Post
in old files that has same bug , when i use the item and get 5% exp , then use it again u will get more exp bonus..etc
Not bad.
05/30/2016 16:18 Mr. 'Avenue™#11
Quote:
Originally Posted by Lauling View Post
going Christian and u don't Need this, do you don't use the Event !
Wenn du die englische Sprache nicht beherrschst, lass es bitte.


Und ich sehe da irgendwie keinen Fix, bzw. keinen Sinn für solch einen "Fix"?!
05/30/2016 17:53 kstmr#12
this is indeed a bug if compared with how it goes in gf , and be logical after why would you be allowed to use an item that boost your exp (even if it is just by 5%) n times ?
the reason why you do not understand is bcz most of you does not use this event, (though it is quite the simple one).
anyway. think about it again and read that simple change once more.
05/30/2016 22:00 Lauling#13
Quote:
Originally Posted by Mr. 'Avenue™ View Post
Wenn du die englische Sprache nicht beherrschst, lass es bitte.


Und ich sehe da irgendwie keinen Fix, bzw. keinen Sinn für solch einen "Fix"?!
tut mir leid, willst du mir english stunden anbieten?
05/31/2016 14:18 Laben#14
Quote:
Originally Posted by Lauling View Post
going Christian and u don't Need this, do you don't use the Event !
shut up sht
05/31/2016 15:10 Lauling#15
Quote:
Originally Posted by Laben View Post
shut up sht
who are u? u noname talk to me?