[mini func](int(bool)) player.IsAntiFlagBySlot(iSlot, iAntiFlag)

Mr. 'Avenue™ · 05/15/2018, 17:47

Die Funktion gibt zurück, ob der Gegenstand im Slot X den AntiFlag Y besitzt.
in Python wird es wie folgt genutzt:

Code:

//usage
player.IsAntiFlagBySlot(iSlot, iAntiFlag)

//example
if player.IsAntiFlagBySlot(SrcSlotNumber, item.ANTIFLAG_GIVE):

SVN/Client/UserInterface/PythonPlayerModule.cpp

Code:

/*
paste following code under
PyObject * playerisItem(PyObject* poSelf, PyObject* poArgs)
{ ... }
*/

PyObject * playerIsAntiFlagBySlot(PyObject* poSelf, PyObject* poArgs)
{
	int iSlotIndex;
	if(!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
		return Py_BuildException();

	int iFlag;
	if(!PyTuple_GetInteger(poArgs, 1, &iFlag))
		return Py_BadArgument();

	const TItemData * pData;
	pData = CPythonPlayer::Instance().GetItemData(TItemPos(INVENTORY, iSlotIndex));
	
	if (NULL == pData)
	{
		pData = CPythonPlayer::Instance().GetItemData(TItemPos(DRAGON_SOUL_INVENTORY, iSlotIndex));
		if (NULL == pData)
			return false;
	}

	DWORD dwItemIndex = pData->vnum;

	CItemManager::Instance().SelectItemData(dwItemIndex);
	CItemData * pItemData = CItemManager::Instance().GetSelectedItemDataPointer();

	if (!pItemData)
		return Py_BuildException("no selected item data");

	return Py_BuildValue("i", pItemData->IsAntiFlag(iFlag));
}

/*
paste following code under
{ "isItem",						playerisItem,						METH_VARARGS },
*/


{ "IsAntiFlagBySlot",			playerIsAntiFlagBySlot,				METH_VARARGS },

xP3NG3Rx · 05/16/2018, 01:53

This is the same way what you can do with python

Code:

item.SelectItem(player.GetItemIndex(slot)
item.IsAntiflag(flag)

But wait, what would you do if the item is not in the inventory?

For example dragon soul inventory and so on. As may you know the ItemPos isn't finished so, the equipments and belt-items are part of the inventory, but in fact you cannot use the function for other windows in this way. I personally don't prefer the use of selectitem either.

And this isn't good either:

Code:

	int iSlotIndex;
	if(!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
		return Py_BuildException();

	int iFlag;
	if(!PyTuple_GetInteger(poArgs, 0, &iFlag))
		return Py_BadArgument();

Mr. 'Avenue™ · 05/16/2018, 17:25

Quote:
Originally Posted by xP3NG3Rx
This is the same way what you can do with python
Code:
item.SelectItem(player.GetItemIndex(slot)
item.IsAntiflag(flag)
But wait, what would you do if the item is not in the inventory?
For example dragon soul inventory and so on. As may you know the ItemPos isn't finished so, the equipments and belt-items are part of the inventory, but in fact you cannot use the function for other windows in this way. I personally don't prefer the use of selectitem either.

And this isn't good either:
Code:
	int iSlotIndex;
	if(!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
		return Py_BuildException();

	int iFlag;
	if(!PyTuple_GetInteger(poArgs, 0, &iFlag))
		return Py_BadArgument();

If you give a look at PyObject * playerGetItemIndex(..) - it's the same.

Code:

	switch (PyTuple_Size(poArgs))
	{
	case 1:
		{
			int iSlotIndex;
			if (!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
				return Py_BuildException();

			int ItemIndex = CPythonPlayer::Instance().GetItemIndex(TItemPos (INVENTORY, iSlotIndex));
			return Py_BuildValue("i", ItemIndex);
		}
	case 2:
		{ ... }
	default:
		return Py_BuildException();

	}

int ItemIndex = CPythonPlayer::Instance().GetItemIndex(TItemPos (INVENTORY, iSlotIndex));

Now, when you ask yourself, "Why is he doing something new for this?"
I'm about to use the newer root python files. And that, without great changes to the Python code.
example:

Code:

	if app.WJ_ENABLE_TRADABLE_ICON:
		def CantCheckInItem(self, slotIndex):
			itemIndex = player.GetItemIndex(slotIndex)
		
			if itemIndex:
				return player.IsAntiFlagBySlot(slotIndex, item.ANTIFLAG_SAFEBOX)

But yeah, one fact is true though. This function is used by uiExchange, uiPrivateShopBuilder, uiSafeBox. So yeah, I have to change something, 'cause I saw that the function is used after following if-clause:

Code:

if (player.SLOT_TYPE_INVENTORY == attachedSlotType
				or player.SLOT_TYPE_DRAGON_SOUL_INVENTORY == attachedSlotType):

So I've changed following part:

Code:

	const TItemData * pData;
	pData = CPythonPlayer::Instance().GetItemData(TItemPos(INVENTORY, iSlotIndex));
	
	if (NULL == pData)
	{
		pData = CPythonPlayer::Instance().GetItemData(TItemPos(DRAGON_SOUL_INVENTORY, iSlotIndex));
		if (NULL == pData)
			return false;
	}

I know, maybe it's coded bad, I ain't a professional programmer, it's just a hobby. But it works (at least the way I tested it).

And idk why this shouldn't be good (?)

Code:

	int iSlotIndex;
	if(!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
		return Py_BuildException();

	int iFlag;
	if(!PyTuple_GetInteger(poArgs, 0, &iFlag))
		return Py_BadArgument();

How else can you solve that, do you have a suggestion for improvement?

Hachiwari · 05/16/2018, 18:25

Quote:
Originally Posted by Mr. 'Avenue™
I know, maybe it's coded bad, I ain't a professional programmer, it's just a hobby. But it works (at least the way I tested it).

And idk why this shouldn't be good (?)
Code:
	int iSlotIndex;
	if(!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
		return Py_BuildException();

	int iFlag;
	if(!PyTuple_GetInteger(poArgs, 0, &iFlag))
		return Py_BadArgument();
How else can you solve that, do you have a suggestion for improvement?

You did mistake in PyTuple_GetInteger(poArgs, 0, &iFlag))
it's good:

Code:

	int iSlotIndex;
	if(!PyTuple_GetInteger(poArgs, 0, &iSlotIndex))
		return Py_BuildException();

	int iFlag;
	if(!PyTuple_GetInteger(poArgs, 1, &iFlag))
		return Py_BadArgument();

xP3NG3Rx · 05/17/2018, 01:13

I wasn't against you, I just told you what have you done with the code, is that bad? Why did you take it too serious? I know why we need this, I already wrote it when I saw it in the official binary at the first time.

If you have couple of minutes take a look on this video, I can prove the official version here:

Spoiler