Can someone tell me why it wont pick up Plant Fibers?

[beladarkoo]

heloo!

I have problem can someone plis tell me where is the problem!

It doesnt want to pick up plant fibers but it does pick up abnormal seeds!

Func PickUpLoot()
	Local $lMe
	Local $lBlockedTimer
	Local $lBlockedCount = 0
	Local $lItemExists = True
	Local $Distance

	For $i = 1 To GetMaxAgents()
		$lAgent = GetAgentByID($i)
		If Not GetIsMovable($lAgent) Then ContinueLoop
	    $lDistance = GetDistance($lAgent)
	    If $lDistance > 2000 Then ContinueLoop
		$lItem = GetItemByAgentID($i)
		If CanPickup($lItem) Then
			Do
				If GetDistance($lAgent) > 150 Then Move(DllStructGetData($lAgent, 'X'), DllStructGetData($lAgent, 'Y'), 100)
				PickUpItem($lItem)
				Sleep(GetPing())
				Do
					Sleep(100)
					$lMe = GetAgentByID(-2)
				Until DllStructGetData($lMe, 'MoveX') == 0 And DllStructGetData($lMe, 'MoveY') == 0
				$lBlockedTimer = TimerInit()
				Do
					Sleep(3)
					$lItemExists = IsDllStruct(GetAgentByID($i))
				Until Not $lItemExists Or TimerDiff($lBlockedTimer) > Random(500, 1000, 1)
				If $lItemExists Then $lBlockedCount += 1
			Until Not $lItemExists Or $lBlockedCount > 5
		EndIf
	Next
EndFunc	;=> PickUpLoot

Func CanPickUp($aitem)
	$m = DllStructGetData($aitem, 'ModelID')

	If $m = 442 Then Return True	;Abnormal Seeds
	If $m <> 442 Then Return False
	If $m = 934 Then Return True	;Plant Fibers
	If $m <> 934 Then Return False
	If $m = 2511 Then Return True	;Gold Coins
	If $m <> 2511 Then Return False

EndFunc	;=> CanPickUp

[DerMoench14]

Ofc. your Bot does only pickup abnormal seeds ... because your Function is designed to do so
Take a look into other bots CanPickup-Function.
Then you'll see what you did wrong.

[Underavelvetmoon]

Originally Posted by DerMoench14

Ofc. your Bot does only pickup abnormal seeds ... because your Function is designed to do so
Take a look into other bots CanPickup-Function.
Then you'll see what you did wrong.

Ill be a bit nice today and provide the answer and explanation for you Since I could see this problem being somewhat confusing to someone who doesnt code.

If $m = 442 Then Return True

This will always return before it checks the other statements because $m is ALWAYS either 442 or it is not 442 and since that is the only statement as the others are separate it will not check them.

You need to structure it like this:

If $m = 442 Then
   Return True ; Abnormal Seeds
ElseIf $m =934 Then
   Return True ; Plant Fibres (And bramble bows oddly)
ElseIf $m = 2511 Then
   Return True ; Gold Coins (Its better to do this with quantity I think)
Else
   Return True
EndIf

However this code is quite large and can get out of control very very quickly. Your better to use a switch function like this:

Func CanPickUp($aItem)
Local $M = DllStructGetData($aItem, 'ModelID')
Local $Q = DllStructGetData($aItem, 'Quantity')

Switch $M
Case 442, 934
   Return True ; Abnormal Seeds & Plant Fibre
EndSwitch

If $Q > 50 Then
   Return True
Else
   Return False
EndIf

Return False
EndFunc

So eventually you can structure it to contain everything you need with minimal coding since you can add multiple statements to each line like this:

 Func IsPcon($aItem)
	Local $ModelID = DllStructGetData($aItem, "ModelID")

	Switch $ModelID
    Case 910, 2513, 5585, 6049, 6366, 6367, 6375, 15477, 19171, 19172, 19173, 22190, 24593, 28435, 30855, 31145, 31146, 35124, 36682
	   Return True ; Alcohol
    Case 6376, 21809, 21810, 21813, 36683
	   Return True ; Party
    Case 21492, 21812, 22269, 22644, 22752, 28436
	   Return True ; Sweets
    Case 6370, 21488, 21489, 22191, 26784, 28433
	   Return True ; DP Removal
    Case 15837, 21490, 30648, 31020
	   Return True ; Tonic
    EndSwitch
	Return False
 EndFunc

Hope this helps!

[beladarkoo]

Now it works I just look a bit more precisly....
Thx for the advice!!!

Func PickUpLoot()
   If GetMapLoading() == 2 Then Disconnected()
   Local $lMe, $lAgent, $lItem
   Local $lBlockedTimer
   Local $lBlockedCount = 0
   Local $lItemExists = True
   For $i = 1 To GetMaxAgents()
	  If GetMapLoading() == 2 Then Disconnected()
	  $lMe = GetAgentByID(-2)
	  If DllStructGetData($lMe, 'HP') <= 0.0 Then Return
	  $lAgent = GetAgentByID($i)
	  If Not GetIsMovable($lAgent) Then ContinueLoop
	  If Not GetCanPickUp($lAgent) Then ContinueLoop
	  $lItem = GetItemByAgentID($i)
	  If CanPickUp($lItem) Then
		 Do
			If GetMapLoading() == 2 Then Disconnected()
			;If $lBlockedCount > 2 Then UseSkillEx(6,-2)
			PickUpItem($lItem)
			Sleep(GetPing())
			Do
			   Sleep(100)
			   $lMe = GetAgentByID(-2)
			Until DllStructGetData($lMe, 'MoveX') == 0 And DllStructGetData($lMe, 'MoveY') == 0
			$lBlockedTimer = TimerInit()
			Do
			   Sleep(3)
			   $lItemExists = IsDllStruct(GetAgentByID($i))
			Until Not $lItemExists Or TimerDiff($lBlockedTimer) > Random(5000, 7500, 1)
			If $lItemExists Then $lBlockedCount += 1
		 Until Not $lItemExists Or $lBlockedCount > 5
	  EndIf
   Next
EndFunc

Func CanPickUp($lItem)
   If GetMapLoading() == 2 Then Disconnected()
   Local $Quantity
   Local $ModelID = DllStructGetData($lItem, 'ModelID')
   Local $ExtraID = DllStructGetData($lItem, 'ExtraID')
   Local $lType = DllStructGetData($lItem, 'Type')
   Local $lRarity = GetRarity($lItem)
   If $ModelID == 146 And ($ExtraID == 10 Or $ExtraID == 12) Then Return True	; Black and White Dye
   If $ModelID == 921 Then	; Bones
	  $Drops += DllStructGetData($lItem, 'Quantity')
	  GUICtrlSetData($DropsCount,$Drops)
	  Return True
   EndIf
   If $ModelID == 929 Then Return True ; 929 = Dust
   If $ModelID == 934 Then Return True ; Plant Fibers
   If $ModelID == 442 Then Return True ; Abnormal seeds
   If $ModelID == 22751 Then Return True ; Lockpick
   If $ModelID == 22191 Then Return True ; Clover
   If $ModelID == 2511 And GetGoldCharacter() < 99000 Then Return True	;2511 = Gold Coins
   ;If $lType == 24 Then Return True ;Shields
   Return False
EndFunc