[Release] Fix Crash Server (Guild Bank & Bank)

ZeroTwo02 · 05/13/2016, 14:37

Too lazy to explain the "exploit".

CDPSrvr::OnPutItemBank

After

Code:

CItemElem* pItemElem = pUser->m_Inventory.GetAtId( nId );

Include

Code:

if( !pItemElem )
				return;

CDPSrvr::OnPutItemGuildBank

After

Code:

CItemElem* pItemElem = pUser->m_Inventory.GetAtId( nId );

Include

Code:

		if( !pItemElem )
			return;
ItemProp* pProp	= pItemElem->GetProp();
		if( !pProp )
			return
		if( nId < 1 || nId > pUser->m_Inventory.GetMax() )
			return;

alfredico · 05/13/2016, 16:11

Quote:
Originally Posted by naruto66620
CDPSrvr::OnPutItemBank

After
Code:
CItemElem* pItemElem = pUser->m_Inventory.GetAtId( nId );
Include
Code:
if( !pItemElem )
				return;

Unnecessary

Quote:

Originally Posted by naruto66620

CDPSrvr::OnPutItemGuildBank

After

Code:

CItemElem* pItemElem = pUser->m_Inventory.GetAtId( nId );

Include

Code:

		if( !pItemElem )
			return;
ItemProp* pProp	= pItemElem->GetProp();
		if( !pProp )
			return
		if( nId < 1 || nId > pUser->m_Inventory.GetMax() )
			return;

First part same as before.
Second part I don't understand why calling GetProp() there. If pItemElem is not null, when using as ItemProp class shouldn't return null. And you missed a semicolon.