Quote:
Originally Posted by Jomex
I know how it works, and the only flaw it ever had is not going through drop in random order. More chances as well as incremented max amount of dropped items are how flyff was designed with drop multipliers and giftbox. Also, would be funny to see someone wonder why 1% drop chance item always drops and blocks other drops because it's first on the list.
|
What do you mean blocks other drops? That would only be caused if the random number being used every time to check is the same, you should for every item generate a new random number, which is what Flyff currently does. This would then go to the next item and generate a new number, assuming the monsters maximum drop limit hasn't been hit.
The only flaw with the monsters maximum drop limit is that it doesn't get used in both Event item drops (propDropEvent.inc) and normal monster item drops (PropMoverEx.inc) causing some servers to drop tons of items as the event items aren't limited at all, they just drop randomly and won't have a break in the loop itself. That is i assume the flaw you are referring too.
As for what i was talking about, Giftbox increasing the drop rate and this should NEVER cause it to just iterate through the all drops again as this is a severally inefficient way to handle a drop modifier, consuming time and processing power to do so. It should just increase the probability of each individual item dropping (say 500% modifier should increase the probability of a 1% item to 5%, just have 5 tries at 1%) and then move on to the next in the drop table (or map in this case).
As for randomising a drop list, this again is a waste of processing power and currently there is no game that i know of that does this, assuming that the games drop lists are set up correctly it should never cause problems such as no other items dropping after and such.
So with just what i've stated above, you can clearly see that the flyff drop system was severely flawed and needed improving for both processing times and just general good programming practices.