Redux v2 - Official 5065 Classic Source

[pro4never]

Originally Posted by Aceking

I'm telling you, the stone itself isn't +1.
Just because it's a +1 stone doesn't automatically make it an actual +1. So the server looks at it and it doesn't have its plus variable set to 1.

So you have two options, make it +1 whenever you create it, or add exceptions into the packet processor to not check for pluses on stone items.

I would suggest the first option, as the second one will likely cause chaos if not written correctly.

If purchased from shop it should already be +1. Agreed.

There could definitely be some issues though.

[mujake]

I used NPCs to generate stones as rewards, and used their ID, so i guess that's the problem.

[Aceking]

Originally Posted by mujake

I used NPCs to generate stones as rewards, and used their ID, so i guess that's the problem.

Correct, when creating any kind of + stone, you need to use CreateItem(itemID, 1) which will give it +1.
Without that, the server considers it a regular item regardless of it being a + stone.

Originally Posted by pro4never

If purchased from shop it should already be +1. Agreed.

There could definitely be some issues though.

Its possible you may have to check if its a plus stone and give it a + when purchasing. I don't think the server handles that currently.
I just disabled the shopping mall completely in my source server side so I am not 100%.

[mujake]

I will remove certain stuff from my shopping mall also making it for just functional items not much.

[zakkwilde_17]

I found a bug :

Try using any passive skill at SOBs TG (Stigman, Shield, etc...)



I use Breakpoints and found where it buging

else if (target.AddEffect((ClientEffect)(1U << skill.Status), skill.StepSecs * Common.MS_PER_SECOND))

[pro4never]

Originally Posted by zakkwilde_17

I found a bug :

Try using any passive skill at SOBs TG (Stigman, Shield, etc...)



I use Breakpoints and found where it buging

else if (target.AddEffect((ClientEffect)(1U << skill.Status), skill.StepSecs * Common.MS_PER_SECOND))

Easy to fix. Just need to edit the combat handler so that when dealing AttachStatus it checks if the target is a SOB. Seems like it's trying to spawn the target but SOBs cannot spawn with that packet type.

Whoever wrote SOBs likely inherited from the entity class which... saves time but isn't necessarily correct in terms of how the rest of the source is written for error checking.

[zakkwilde_17]

Originally Posted by pro4never

Easy to fix. Just need to edit the combat handler so that when dealing AttachStatus it checks if the target is a SOB. Seems like it's trying to spawn the target but SOBs cannot spawn with that packet type.

Whoever wrote SOBs likely inherited from the entity class which... saves time but isn't necessarily correct in terms of how the rest of the source is written for error checking.

So, the only solution is to abort the attack when the target is a SOB.

[pro4never]

Originally Posted by zakkwilde_17

So, the only solution is to abort the attack when the target is a SOB.

..............

no...

The server is trying to spawn sobs to players as if they are monsters/players. It's just a matter of checking the screen code so that doesn't happen. It'll be fixed in the next uploaded verison

[zakkwilde_17]

Ok, I will wait anxiously to see new updates: D

[turk55]

Originally Posted by zakkwilde_17

Ok, I will wait anxiously to see new updates: D

Well you can keep waiting since nobody is really sharing anymore.

[pro4never]

Originally Posted by turk55

Well you can keep waiting since nobody is really sharing anymore.

I wrote a bunch of updates last week and released them. Not sure if/when I'd do another release but there's many updates since 2.9.1 so worst case I'd just post that eventually.

[turk55]

Originally Posted by pro4never

I wrote a bunch of updates last week and released them. Not sure if/when I'd do another release but there's many updates since 2.9.1 so worst case I'd just post that eventually.

Oh... I didn't know about that. You must of been bored eh?

[pro4never]

Originally Posted by turk55

Oh... I didn't know about that. You must of been bored eh?

I took last week off... after about 24 hours I was bored out of my mind and was procrastinating paid coding work so I continued to make a mess of this source xD

[pureone]

Originally Posted by mujake

Check that your antivirus has removed some .dlls from the game folder.
I have Norton and windows 8.1 x64 and i can run the server and client perfectly normal.

I am currently using ChatType.Talk2 and i have it being stacked up!
Any idea how to make it overwrite itself and be in purple is think?

 Spoiler

Also i noticed that if i want to compose an +1 to +2 with +1 stones i get an error saying :
The bonus level of the minor item has to be at least level 1!

i have no anti virus and it always popup when i run the conquerloader as administrator and i also delete the tq anti virus

same as always

i hate this thing i cant even open the client with this error createremotethread grrr

[pro4never]

Originally Posted by zakkwilde_17

I found a bug :

Try using any passive skill at SOBs TG (Stigman, Shield, etc...)



I use Breakpoints and found where it buging

else if (target.AddEffect((ClientEffect)(1U << skill.Status), skill.StepSecs * Common.MS_PER_SECOND))

Confirmed fixed for 2.9.2

Entity.AddEffect is trying to re-send the entityspawnpacket for anything that has its effect changed. As a temp fix you can just change if(success) to be

if (success && !(this is SOB))

Originally Posted by mujake

I used NPCs to generate stones as rewards, and used their ID, so i guess that's the problem.

Shops will generate + on items automatic. This is because they are searching the ItemType for what is being purchased and initializing the + value of it based on the "Magic3" field in that table.

If you're generating + stones from commands or NPCs you need to manually specify that + value.

EG: CreateItem(730001, 1); to create a +1Stone that is also +1 (cause yah... tq is fun like that)

Redux 2.9.2 Release

NPCs
-Market Upgrades now check new item level (no more lvl 120 items on lvl 1 characters)
-Added LOTS of market/lab NPCs [mujake]
-Added all mine assistants
-Added Moon Box Quest (should be 100%)
-Added VP Rewards
-Added Lab (rewards/tokens/etc)
-Added Unknown man (awards 8 exp balls of exp)
-Added Tinter/Shop boy (armor dye)

MISC/Features
-Added Tasks (daily limits for events/quests/items)
-Added character deletion
-Fixed level up logic (who the fuck wrote that mess..)
-Virtue points added
-Team Exp added
-Fixed minor portal issue
-ReWrote mining system
-Added mine support for all mines
-Fixed weapon skill issue in TG (100% activation rate)
-Fixed map flags (was causing issue with mine caves/other maps resetting location incorrectly)
-Added AC2 Spawns
-Corrected Lab spawns




NOTE: This is missing the NPC spawn locations for Moon Box Quest as well as the spawns for lab (only slingers are spawning atm)

If someone has already added them, hit me up and I'll include in a future release.