Register for your free account! | Forgot your password?

You last visited: Today at 12:56

  • Please register to post and access all features, it's quick, easy and FREE!


Source CandyConquer BUG

Discussion on Source CandyConquer BUG within the CO2 PServer - Discussions / Questions forum part of the Conquer Online 2 category.

Reply
 
Old   #1
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
Unhappy Source CandyConquer BUG

Hello anyone
I'm using candyconquer and trying to complete the missing features. I found a serious problem.

If level >= 70 and re-login 2 or 3 times, the client will disappear.
http://i.epvpimg.com/9YySaab.png

I think the problem is here.
http://i.epvpimg.com/FVxAfab.png
I remove player.UpdateClientNobility(); problem no longer occurs.

The NobilityPacket seems to have no problem, Nobility works fine.
http://i.epvpimg.com/MvKhaab.png
I not donate, The problem still arises.
I didn't get any exception messages.
please help me.


my english bad, sorry



liqicong is offline  
Old 04/23/2019, 18:58   #2
 
elite*gold: 0
Join Date: Dec 2012
Posts: 1,688
Received Thanks: 879
Are you sure you're using the correct client version?

also please log all packets send to the client and received by the server and post the log here.

Because when the client "disappears" it's usually because it receives either an invalid packet or an invalid packet size.


Super Aids is offline  
Old 04/23/2019, 19:17   #3
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
The client version is correct.
I checked these packets and it seems that there is no problem.

'10.0.0.2' has connected to the server.
packetId:35237 Length:43185
packetId:2079 Length:8
packetId:2078 Length:264
packetId:1004 Length:52
packetId:1006 Length:124
packetId:1033 Length:36
packetId:10010 Length:37
packetId:1110 Length:20
packetId:1016 Length:20
packetId:10010 Length:37
packetId:10010 Length:38
packetId:1008 Length:68
packetId:1015 Length:19
packetId:10010 Length:38
packetId:10010 Length:38
packetId:10010 Length:38
packetId:10010 Length:38
packetId:10010 Length:38
packetId:10017 Length:28
packetId:10017 Length:28
packetId:10017 Length:28
packetId:1040 Length:136
packetId:10017 Length:28
packetId:10017 Length:28
packetId:10017 Length:28
packetId:1040 Length:136
packetId:10017 Length:28
packetId:10017 Length:28
packetId:10017 Length:28
packetId:1040 Length:136
packetId:10017 Length:28
packetId:10017 Length:28
packetId:10017 Length:28
packetId:1040 Length:136
packetId:10017 Length:28
packetId:10017 Length:28
packetId:10017 Length:28
packetId:1040 Length:136
packetId:10017 Length:28
packetId:10017 Length:28
packetId:10017 Length:28
packetId:2064 Length:58
packetId:10017 Length:28
packetId:10017 Length:28
packetId:1004 Length:91
'taoist' has successfully logged in...
packetId:10005 Length:24
packetId:10005 Length:24
packetId:10005 Length:24
packetId:10005 Length:24
packetId:10005 Length:24
'10.0.0.2' has disconnected from the server Reason: [N-6]The socket has been disconnected.
'10.0.0.2' has connected to the server.
packetId:11980 Length:54906
packetId:2079 Length:8
packetId:2078 Length:264
packetId:1004 Length:52
packetId:1006 Length:124
packetId:1033 Length:36
packetId:10010 Length:37
packetId:1110 Length:20
packetId:1016 Length:20
packetId:10010 Length:37
packetId:10010 Length:38
packetId:1008 Length:68
packetId:10010 Length:38
'10.0.0.2' has disconnected from the server Reason: [N-2]The client has been disconnected.

The first login send packet 2064
There will be problems with the second login.

packet 2064 no problem
liqicong is offline  
Old 04/23/2019, 21:46   #4
 
elite*gold: 0
Join Date: Dec 2012
Posts: 1,688
Received Thanks: 879
packetId:35237 Length:43185
packetId:11980 Length:54906

Are wrong.

I think you need to debug that.

Did you make sure the account etc. was entirely clean and the data too.

It looks like something is corrupt in it.

(I can't reproduce it and nobody else seem to have the issue either.)


Super Aids is offline  
Old 04/24/2019, 03:21   #5
 
elite*gold: 12
Join Date: Jul 2011
Posts: 7,253
Received Thanks: 3,518
Quote:
Originally Posted by Super Aids View Post
packetId:35237 Length:43185
packetId:11980 Length:54906

Are wrong.

I think you need to debug that.

Did you make sure the account etc. was entirely clean and the data too.

It looks like something is corrupt in it.

(I can't reproduce it and nobody else seem to have the issue either.)
Those incorrect packet Ids and lengths are probably the DH key exchange.
But yeah, as you said, it needs to be debugged.
Spirited is offline  
Old 04/24/2019, 03:42   #6
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
Quote:
Originally Posted by Super Aids View Post
packetId:35237 Length:43185
packetId:11980 Length:54906

Are wrong.

I think you need to debug that.

Did you make sure the account etc. was entirely clean and the data too.

It looks like something is corrupt in it.

(I can't reproduce it and nobody else seem to have the issue either.)
I use the new clean source, found that the problem also exists

Quote:
Originally Posted by Spirited View Post
Those incorrect packet Ids and lengths are probably the DH key exchange.
But yeah, as you said, it needs to be debugged.
I have been debugging for a long time and can't find the problem.
liqicong is offline  
Old 04/25/2019, 06:46   #7
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
I fixed it, send packet 2064 in here.
http://i.epvpimg.com/hfUSbab.png
I don't know why.
liqicong is offline  
Old 04/25/2019, 07:18   #8
 
elite*gold: 12
Join Date: Jul 2011
Posts: 7,253
Received Thanks: 3,518
Quote:
Originally Posted by liqicong View Post
I fixed it, send packet 2064 in here.
http://i.epvpimg.com/hfUSbab.png
I don't know why.
I don't understand, can you clarify? How did you fix it? What was the issue?
Thanks.
Spirited is offline  
Old 04/25/2019, 08:33   #9
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
Quote:
Originally Posted by Spirited View Post
I don't understand, can you clarify? How did you fix it? What was the issue?
Thanks.
I'm not sure what the problem is.
I found that changing the location of player.UpdateClientNobility(); can avoid this problem.
liqicong is offline  
Old 04/25/2019, 18:23   #10
 
elite*gold: 0
Join Date: Feb 2014
Posts: 105
Received Thanks: 59
Arco and I worked with this source for upwards of 6 months and never had this issue. Not sure why that's causing problems.
Asphy×ia is offline  
Old 04/26/2019, 04:43   #11
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
Quote:
Originally Posted by Asphy×ia View Post
Arco and I worked with this source for upwards of 6 months and never had this issue. Not sure why that's causing problems.
It looks like my problem, but I use the clean source and new client, found that the problem also exists.
liqicong is offline  
Old 04/26/2019, 06:34   #12
 
elite*gold: 12
Join Date: Jul 2011
Posts: 7,253
Received Thanks: 3,518
It's possible that it's some race condition that's just now being spotted due to varying hardware. I took a lot at the source, but the abstraction of everything still makes it difficult to read that source and follow the code... Especially when you don't have Visual Studio installed on your tablet. I couldn't see anything out of the ordinary. I can try installing Visual Studio when I get home... But it's such a huge program...
Spirited is offline  
Old 04/26/2019, 07:46   #13
 
elite*gold: 0
Join Date: Jan 2013
Posts: 14
Received Thanks: 0
Quote:
Originally Posted by Spirited View Post
It's possible that it's some race condition that's just now being spotted due to varying hardware. I took a lot at the source, but the abstraction of everything still makes it difficult to read that source and follow the code... Especially when you don't have Visual Studio installed on your tablet. I couldn't see anything out of the ordinary. I can try installing Visual Studio when I get home... But it's such a huge program...
If it is hardware varying what should I do?
liqicong is offline  
Old 04/26/2019, 09:16   #14
 
elite*gold: 0
Join Date: Oct 2007
Posts: 1,542
Received Thanks: 606
I remember having the same issue. I believe I fixed it by adding condition checks to the packet reader/writer class. As the source is now, there are no conditions.
turk55 is offline  
Old 04/26/2019, 09:57   #15
 
elite*gold: 0
Join Date: Dec 2012
Posts: 1,688
Received Thanks: 879
Quote:
Originally Posted by turk55 View Post
I remember having the same issue. I believe I fixed it by adding condition checks to the packet reader/writer class. As the source is now, there are no conditions.
A wild guess is that the virtual size of a packet doesn't match the actual size of the packet.

Ex.

Code:
{
    ushort: 6 (size)
    ushort: 2
    uint: 1
    uint  1
}
Has a virtual size of 6.

But a physical size of 12.

That means when the client receives the packet it will read the first 6 bytes and then the second half of the first uint will be a new packet to the client and will most likely be read as an invalid size since it obviously isn't the size of a packet.

Instead that packet should have been:

Code:
{
    ushort: 12 (size)
    ushort: 2
    uint: 1
    uint  1
}
---

That's also why I said debug and log the packets. Check what the server is actually sending to the client.

Quote:
Originally Posted by Spirited View Post
It's possible that it's some race condition that's just now being spotted due to varying hardware. I took a lot at the source, but the abstraction of everything still makes it difficult to read that source and follow the code... Especially when you don't have Visual Studio installed on your tablet. I couldn't see anything out of the ordinary. I can try installing Visual Studio when I get home... But it's such a huge program...
Definitely not a race condition, or at least it shouldn't be since it doesn't send anything across threads to the client during login which is when this happens.

And even when it does it's concurrent and shouldn't cause any race conditions.


Super Aids is offline  
Thanks
1 User
Reply

Tags
candyconquer



« EU emerald CO Virus | Looking for someone to guide me »

Similar Threads
ProjectX V5 (Aka. Codename CandyConquer) - 5517 Source
05/21/2019 - CO2 PServer Guides & Releases - 71 Replies
CandyConquer is the base source for ProjectX V5 and it's based around patch 5517. It's currently playable, but has some missing features that would be up to you to implement. It uses MSSQL with a custom ORM implementation. The whole source is documented and kept in a user-friendly structure. It should be fairly easy to work with. It's not a fully featured or bugless source, but it's definitely better than my previous sources, both in terms of design, stability and maintainability. As it...
FCQMap_Convertor [CandyConquer]
07/21/2018 - CO2 PServer Guides & Releases - 2 Replies
it's Covert Map from TinyMaps to FCQMap_Convertor It will help you if you are working on Source CandyConquer 1- open FCQMap Convertor.exe 2- Choose Path Folder TinyMaps and Click to Ctrl+A to select All + Open Will Covert Auto into Folder Maps
[SEARCH]Gold bug , castel bug ans speed repair bug for key bug or crystal bug
08/24/2012 - Browsergames - 1 Replies
Hi I search key or crystal bug :) I will give gold , castel and speed repair bug Please send me skype : ciechomek111



All times are GMT +2. The time now is 12:56.


Powered by vBulletin®
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.
SEO by vBSEO ©2011, Crawlability, Inc.

BTC: 3KeUpz52VCbhmLwuwydqxu6U1xsgbT8YT5
ETH: 0xc6ec801B7563A4376751F33b0573308aDa611E05

Support | Contact Us | FAQ | Advertising | Privacy Policy | Terms of Service | Abuse
Copyright ©2019 elitepvpers All Rights Reserved.