[QUESTION] How to correctly display online status of associates?

[Basser]

I've noticed that most public servers have an odd way of communicating the online status of associates to the client.

Most use these types:

 Spoiler

RequestFriend = 10,
NewFriend = 11,
SetOnlineFriend = 12,
SetOfflineFriend = 13,
RemoveFriend = 14,
AddFriend = 15,
SetOnlineEnemy = 16,
SetOfflineEnemy = 17,
RemoveEnemy = 18,
AddEnemy = 19,

What most sources seem to do:
When I log in, my friend is sent:
Packet with RemoveFriend followed by a packet with AddFriend, Online = true.

When I log out, my friend is sent:
Packet with RemoveFriend followed by a packet with AddFriend, Online = false;

I simply use SetOnlineFriend in situation 1. The weird thing is, when I use SetFriendOffline in situation 2 it doesn't work.

What do you guys think is the correct way of communicating with the client?

[shadowman123]

When u login you should send all the player Friends 2 Times 1st Packet to send containing ID = RemoveENemy , 2nd Packet is FriendList Packet with ID = AddFriend (this to Prevent Duplicate Friend in your List ) Duplicate Friends means that you see your Friend Twice in List and sure u dont want to smthing like that to happen.. then you should send all the Friends the player have a message telling them that their friend is Online ( if they are Online for sure ) .. when Disconnecting you should send the Online Friends in your char Same 2 Packets but make sure that the offset responsible for player Online state = 1 ( i guess its offset 20 or 16 i dont remember ) and message telling them that their friend is offline now that how you should handle the Friend

BTW the FriendShip Request Part is Wrongly coded and leads to Getting Bugs Which are :-
lets say i sent u request it would show to u that i need to make FriendShip with u in form of MessageBox (which is Wrong cuz Friendship packet can handle that) .. and u pressed No everytime u get Invitation in form of messageBox and u pressed no u are going to get message telling u that the player u sent request has Declined your Request .. althought u didnt send any1 FriendRequest AT that Time .. u know y this bug is caused .. cause of these USELESS Codes client.OKMessageBox , client.CancelMessageBox

Note if you know what u r doing then i recommend u to Recode the Whole system its not hard at all took me about 1 - 2 Hours to understand , code everything ..if u got any question feel free to ask

Hope i helped you

[teroareboss1]

put one breakpoints
where you send packet, to see if they really sent

Client.GamePackets.KnowPersons request = new Client.GamePackets.KnowPersons();
                            request.Name = client.Player.Name;
                            request.Online = false;
                            request.Type   =Client.GamePackets.KnowPersons.AddOffline;
                            request.UID = client.Player.UID;
                            clients.Enqueue(request.ToArray());

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Project_Terror.Client.GamePackets
{
    public class KnowPersons : ServerSocket.Packet
    {
        public const byte
            RequestFriendship = 10,
            AcceptRequest = 11,
            AddOnline = 12,
            AddOffline = 13,
            RemovePerson = 14,
            AddFriend = 15,

            RemoveEnemy = 18,
            AddEnemy = 19;

        public KnowPersons()
            : base(80, true)
        {

            WriteUshort(72, 0);
            WriteUshort((ushort)CMD.GamePackets.KnowPersons, 2);
        }

        public uint UID
        {
            get { return ReadUint(4); }
            set { WriteUint(value, 4); }
        }

        public byte Type
        {
            get { return ReadByte(8); }
            set { WriteByte(value, 8); }
        }

        public bool Online
        {
            get { return ReadByte(9) == 1; }
            set { WriteByte((byte)(value == true ? (byte)1 : (byte)0), 9); }
        }

        public string Name
        {
            get
            {
                return ReadString(20, 16);
            }
            set
            {
                WriteString(value, 20);
            }
        }
    }
}

this work sure

[Basser]

It works for me, but why is there a SetOnlineFriend if that doesn't work?
I personally feel that sending to packets to remove and add the friend isn't necessary to change it's online/offline status.

Not sure what TQ does, but it seemed to me the removing and adding again worked best (which doesn't mean it is the best, haven't tried everything...)

I was hoping someone could tell me what the correct way was - yes, still assuming two packets aren't necessary

Originally Posted by shadowman123

BTW the FriendShip Request Part is Wrongly coded and leads to Getting Bugs Which are :-
lets say i sent u request it would show to u that i need to make FriendShip with u in form of MessageBox (which is Wrong cuz Friendship packet can handle that) .. and u pressed No everytime u get Invitation in form of messageBox and u pressed no u are going to get message telling u that the player u sent request has Declined your Request .. althought u didnt send any1 FriendRequest AT that Time .. u know y this bug is caused .. cause of these USELESS Codes client.OKMessageBox , client.CancelMessageBox

Note if you know what u r doing then i recommend u to Recode the Whole system its not hard at all took me about 1 - 2 Hours to understand , code everything ..if u got any question feel free to ask

Hope i helped you

Not sure what source you're referring to, I don't use a message box for friend requests (pretty sure it wasn't done like that at patch 5065?). Besides my friend system is from scratch as it is a very basic feature.

[shadowman123]

Originally Posted by Basser

Not sure what source you're referring to, I don't use a message box for friend requests (pretty sure it wasn't done like that at patch 5065?). Besides my friend system is from scratch as it is a very basic feature.

aha fine .. try using Type = AddFriend and see results

[Basser]

Originally Posted by shadowman123

aha fine .. try using Type = AddFriend and see results

AddFriend should only be sent at initial log in, not to change the online/offline status...
I know it will duplicate, obviously that will happen.

[shadowman123]

Originally Posted by Basser

AddFriend should only be sent at initial log in, not to change the online/offline status...
I know it will duplicate, obviously that will happen.

what controls Online and offline state of player is offset 9 not the Type ,...End of story

[Basser]

Originally Posted by shadowman123

what controls Online and offline state of player is offset 9 not the Type ,...End of story

And that's how TQ does it? Why are there so many types there?

[Korvacs]

Ok, this is fairly simple, on login you do a few things:

First: Send AddFriend (0x0F) for every friend associated with the Online bool set to true if the friend is online (This populates the logging in character's list).
Second: Send SetFriendOnline (0x0C) with the bool marked as true, to every friend to tell them that your character has just logged in (this updates the friend's friend list).

Then you rinse/repeat for enemies.

When a character logs out, you notify each of that characters friends that they are now offline by sending SetFriendOffline with the bool marked as false.

And that is it.

[Basser]

Originally Posted by Korvacs

Ok, this is fairly simple, on login you do a few things:

First: Send AddFriend (0x0F) for every friend associated with the Online bool set to true if the friend is online (This populates the logging in character's list).
Second: Send SetFriendOnline (0x0C) with the bool marked as true, to every friend to tell them that your character has just logged in (this updates the friend's friend list).

Then you rinse/repeat for enemies.

When a character logs out, you notify each of that characters friends that they are now offline by sending SetFriendOffline with the bool marked as false.

And that is it.

Thats what I assumed, but for some reason enemies will stay offline (using SetEnemyOnline)

EDIT:
Not sure what I did differently this time, but it seems to work now, so thanks!