are these packets correct?

Quote:

Originally Posted by aintx Code: packetReader reader((byte*)data, size); short psize = reader.readWord(); short opcode = reader.readWord(); short security = reader.readWord(); printf("packet size: %d\n", psize); printf("opcode: %.4x\n", opcode); try like this. ^^ you do not need +6 for psize

Quote:

Originally Posted by sjaakie100 Thank you for your quick response. It didn't solve my problem. I think I need to add + 6 because now I've got 6 bytes more in every packet than psize says. Like that 4th packet It says packet size: 0 but there are 6 bytes in it.

struct TPacket
    {
[COLOR="Lime"]        public ushort size;
        public ushort opcode;
        public byte securityCount;
        public byte securityCRC;[/COLOR]
        public fixed byte [COLOR="Red"]data[/COLOR][8096];
    }

	short psize = reader.readWord();

Quote:

Originally Posted by Shadowz75 Well, this is how silkroad builts the packets(the header is always 6 bytes big, the green marked) Code: struct TPacket { [COLOR="Lime"] public ushort size; public ushort opcode; public byte securityCount; public byte securityCRC;[/COLOR] public fixed byte [COLOR="Red"]data[/COLOR][8096]; } Code: short psize = reader.readWord(); this size is not the packet size, its the size of the data. if you add +6 you add the size of the header, too.so your 4th packet has just no data in it.

Quote:

Originally Posted by sjaakie100 Thanks for explaining I get it now:). I still the problem with the reading I think it's just a problem with the reader itself so I'll make my own one too see if that works.

	public class RawPacket
	{
		public WORD size;
		public WORD opcode;
		public BYTE _securityCount;
		public BYTE _securityCRC;
		public BYTE[] data;

		/// <summary>
		/// RawPacket constructor. Ususally used to read packets.
		/// </summary>
		/// <param name="buffer">The bytes received.</param>
		/// <param name="length">The length of the bytes received.</param>
		public RawPacket(BYTE[] buffer, int length)
		{
			size = BitConverter.ToUInt16(buffer, 0);
			opcode = BitConverter.ToUInt16(buffer, 2);
			_securityCount = buffer[4];
			_securityCRC = buffer[5];
			data = new BYTE[length + 1];
			Array.Copy(buffer, 6, data, 0, length - 5);
		}

		/// <summary>
		/// RawPacket constructor. Usually used to write packets.
		/// </summary>
		/// <param name="inputOpcode">The opcode of the packet.</param>
		public RawPacket(WORD inputOpcode)
		{
			size = 0;
			opcode = inputOpcode;
			_securityCount = 0;
			_securityCRC = 0;
			data = new BYTE[4096];
		}

		public BYTE[] GetBytes()
		{
			BYTE[] tmpBytes = new BYTE[size + 6];

			BYTE[] tmpSize = BitConverter.GetBytes(size);
			tmpBytes[0] = tmpSize[0];
			tmpBytes[1] = tmpSize[1];

			BYTE[] tmpOpcode = BitConverter.GetBytes(opcode);
			tmpBytes[2] = tmpOpcode[0];
			tmpBytes[3] = tmpOpcode[1];

			tmpBytes[4] = _securityCount;

			tmpBytes[5] = _securityCRC;

			Array.Copy(data, 0, tmpBytes, 6, size);

			return tmpBytes;
		}
	};

	public class PacketReader : BinaryReader
	{
		public PacketReader(RawPacket input)
			: base(new MemoryStream(input.data)) { }

		public WORD ReadWord() { return this.ReadUInt16(); }

		public DWORD ReadDWord() { return this.ReadUInt32(); }

		public QWORD ReadQWord() { return this.ReadUInt64(); }

		public override string ReadString() { return new string(this.ReadChars(this.ReadWord())); }

		public string ReadString(WORD length) { return new string(this.ReadChars(length)); }
	}

Quote:

Originally Posted by lesderid Reader for SRO is kinda easy. Well, it is in C#. You just inherit the BinaryReader class and you override some functions. (like string reading)

Quote:

Originally Posted by sjaakie100 I saw it in csremu:) but i'm using c++ so it's a bit more difficult:P btw when i print my packet like data[3],data[2] I get the right opcodes so it is a reading problem and not a prolbem with the data. I'll tell you guys if I got it working correctly but tips ect. are always welcome:)

Quote:

Originally Posted by sjaakie100 I saw it in csremu:) but i'm using c++ so it's a bit more difficult:P btw when i print my packet like data[3],data[2] I get the right opcodes so it is a reading problem and not a prolbem with the data. I'll tell you guys if I got it working correctly but tips ect. are always welcome:)