[Problem] Error with warehouse

Page 1 of 2

09/16/2010 03:54 iLikeSkittles#1

Can anyone explain why i have this error please :confused:

[Only registered and activated users can see links. Click Here To Register...]

Line 679 in Packets.cs

Spoiler

Line 87 in Warehouse.cs

Spoiler

Inside SendWarehouse

Spoiler

Code:

 public static COPacket SendWarehouse(Game.Character C, ushort NPC)
        {
            ArrayList Warehouse = null;
            switch (NPC)
            {
                case 8: { Warehouse = C.Warehouses.TCWarehouse; break; }
                case 10012: { Warehouse = C.Warehouses.PCWarehouse; break; }
                case 10028: { Warehouse = C.Warehouses.ACWarehouse; break; }
                case 10011: { Warehouse = C.Warehouses.DCWarehouse; break; }
                case 10027: { Warehouse = C.Warehouses.BIWarehouse; break; }
                case 44: { Warehouse = C.Warehouses.MAWarehouse; break; }
                case 4101: { Warehouse = C.Warehouses.SCWarehouse; break; }
                default: return new COPacket(new byte[0]);
            }
            byte[] Packet = new byte[8 + 16 + (32 * Warehouse.Count)];
            COPacket P = new COPacket(Packet);
            P.WriteInt16((ushort)(Packet.Length - 8));
            P.WriteInt16((ushort)0x44e);
            P.WriteInt32(NPC);
            P.Move(4);
            P.WriteInt32((uint)Warehouse.Count);
            foreach (Game.Item I in Warehouse)
            {
                if (I.ID != 0)
                {
                    P.WriteInt32(I.UID);
                    P.WriteInt32(I.ID);
                    P.Move(1);
                    P.WriteByte((byte)I.Soc1);
                    P.WriteByte((byte)I.Soc2);
                    P.WriteInt16((ushort)I.Effect);
                    P.WriteByte(I.Plus);
                    P.WriteByte(I.Bless);
                    if (I.FreeItem)
                        P.WriteByte(1);
                    else P.Move(1);
                    P.WriteByte(I.Enchant);
                    P.WriteByte(0);
                    P.WriteByte(0);
                    P.WriteByte(0);
                    P.WriteByte(0);
                    P.WriteByte(0);
                    P.WriteByte(0);
                    P.WriteByte((byte)I.Color);
                    P.WriteInt32(I.TalismanProgress);
                    P.Move(4);
                }
            }
            return P;
        }

Line 638 in PacketHandler.cs

Spoiler

Inside Handle

Spoiler

Code:

public static void Handle(Main.GameClient GC, byte[] Data)
        {
            if (!GC.MyChar.WHOpen && GC.MyChar.WHPassword != "0")
                return;

            uint NPC = BitConverter.ToUInt32(Data, 4);
            uint IUID = BitConverter.ToUInt32(Data, 12);
            byte Type = Data[8];

            ArrayList Warehouse = null;

            switch (NPC)
            {
                case 8: { Warehouse = GC.MyChar.Warehouses.TCWarehouse; break; }
                case 10012: { Warehouse = GC.MyChar.Warehouses.PCWarehouse; break; }
                case 10028: { Warehouse = GC.MyChar.Warehouses.ACWarehouse; break; }
                case 10011: { Warehouse = GC.MyChar.Warehouses.DCWarehouse; break; }
                case 10027: { Warehouse = GC.MyChar.Warehouses.BIWarehouse; break; }
                case 44: { Warehouse = GC.MyChar.Warehouses.MAWarehouse; break; }
                case 4101: { Warehouse = GC.MyChar.Warehouses.SCWarehouse; break; }
            }

            if (Type == 1)
            {
                try
                {
                    if (Warehouse.Count < Warehouse.Capacity)
                    {
                        Game.Item I = GC.MyChar.FindInvItem(IUID);
                        if (I.ID != 0)
                        {
                            GC.MyChar.RemoveItem(I);
                            Warehouse.Add(I);
                            GC.AddSend(Packets.AddWHItem(GC.MyChar, (ushort)NPC, I));
                            return;
                        }
                        else
                            GC.AddSend(Packets.ItemPacket(IUID, 0, 3));
                    }
                }
                catch { }
                return;
            }
            else if (Type == 2)
            {
                try
                {
                    if (GC.MyChar.Inventory.Count < 40)
                    {
                        Game.Item I = new Game.Item();
                        foreach (Game.Item II in Warehouse)
                            if (II.UID == IUID)
                                I = II;

                        if (I.ID != 0 && I.UID != 0)
                        {
                            GC.AddSend(Packets.RemoveWHItem(GC.MyChar, (ushort)NPC, I));
                            Warehouse.Remove(I);
                            GC.MyChar.AddItem(I); return;
                        }
                    }
                }
                catch { return; }
                return;
            }

            switch (NPC)
            {
                case 8: { GC.MyChar.Warehouses.TCWarehouse = Warehouse; break; }
                case 10012: { GC.MyChar.Warehouses.PCWarehouse = Warehouse; break; }
                case 10028: { GC.MyChar.Warehouses.ACWarehouse = Warehouse; break; }
                case 10011: { GC.MyChar.Warehouses.DCWarehouse = Warehouse; break; }
                case 10027: { GC.MyChar.Warehouses.BIWarehouse = Warehouse; break; }
                case 44: { GC.MyChar.Warehouses.MAWarehouse = Warehouse; break; }
                case 4101: { Warehouse = GC.MyChar.Warehouses.SCWarehouse; break; }
            }
            GC.AddSend(Packets.SendWarehouse(GC.MyChar, (ushort)NPC));
        }

09/16/2010 09:31 -F�ng-#2

How did you get that error? Did you fill up the WH all the way?
I didn't look at your code because I'm a bit hand-tied right now but tell me how you got that problem.

09/16/2010 09:45 Ian*#3

Quote:

System.NullReferenceException: Object reference not set to an instance of an object

That's the error, basically what it means is you're trying to send data to something that's just not there. Or at least you didn't tell it what to send data to.

Just skimmed through your code, anyways I think it's because you set warehouse as a null object then try to reassign it.

Why is it null anyways?

Code:

ArrayList Warehouse = null;

In your Inside Warehouse spoiler.

09/16/2010 10:05 Korvacs#4

Code:

ArrayList Warehouse = null;

Should read:

Code:

ArrayList Warehouse = new ArrayList();

Even though the warehouse may remain empty this is correct because it will be an empty arraylist, so Warehouse.Count will return 0.

09/16/2010 10:19 -F�ng-#5

Quote:
Originally Posted by Korvacs
Code:
ArrayList Warehouse = null;
Should read:
Code:
ArrayList Warehouse = new ArrayList();
Even though the warehouse may remain empty this is correct because it will be an empty arraylist, so Warehouse.Count will return 0.

Sorry =s I just got out of the shower. Good job Korvacs =]
The array list is where the items are stored. Won't do much if it's equal to null xP

09/17/2010 04:35 salem rey#6

So anyone can fix this problem?

09/17/2010 04:56 -F�ng-#7

Quote:

Originally Posted by salem rey

So anyone can fix this problem?

Korvacs fixed it o.o
The warehouse was being assigned to a null reference instead of an array.

09/17/2010 05:34 Ian*#8

Hang on let me get a spoon...

Code:

 public static COPacket SendWarehouse(Game.Character C, ushort NPC)
        {
[B]            ArrayList Warehouse = null;[/B]
            switch (NPC)
            {

then backspace the word "null".

replace null with "new ArrayList();"
make it look like this, exactly like this.

Code:

 public static COPacket SendWarehouse(Game.Character C, ushort NPC)
        {
[B]            ArrayList Warehouse = new ArrayList();[/B]
            switch (NPC)
            {

Basically what was going wrong was you were trying to use a null value (null basically means there is nothing there).

so instead of making a null array list, you want to create a new array list object to use for each client instance.

09/17/2010 05:36 salem rey#9

did he relesae the fix guide? please if it is release give me a link or teach me how? please

09/17/2010 05:42 Ian*#10

Quote:
Originally Posted by Korvacs
Code:
ArrayList Warehouse = null;
Should read:
Code:
ArrayList Warehouse = new ArrayList();
Even though the warehouse may remain empty this is correct because it will be an empty arraylist, so Warehouse.Count will return 0.

Read this.

Quote:
Originally Posted by Ian*
Hang on let me get a spoon...
Code:
 public static COPacket SendWarehouse(Game.Character C, ushort NPC)
        {
[B]            ArrayList Warehouse = null;[/B]
            switch (NPC)
            {
then backspace the word "null".

replace null with "new ArrayList();"
make it look like this, exactly like this.
Code:
 public static COPacket SendWarehouse(Game.Character C, ushort NPC)
        {
[B]            ArrayList Warehouse = new ArrayList();[/B]
            switch (NPC)
            {
Basically what was going wrong was you were trying to use a null value (null basically means there is nothing there).

so instead of making a null array list, you want to create a new array list object to use for each client instance.

And if you still don't get it read this.

ITS REALLY EASY.... JUST CHANGE ONE WORD AND UR DONE YOU DONT NEED A WHOLE GUIDE TO FIGURE THIS OUT.

kthx

09/17/2010 05:50 salem rey#11

i did it but still i got error i see this in my source

In my packet.cs

public static COPacket SendWarehouse(Game.Character C, ushort NPC)
{
ArrayList Warehouse = new ArrayList();
switch (NPC)
{
case 8: { Warehouse = C.Warehouses.TCWarehouse; break; }
case 10012: { Warehouse = C.Warehouses.PCWarehouse; break; }
case 10028: { Warehouse = C.Warehouses.ACWarehouse; break; }
case 10011: { Warehouse = C.Warehouses.DCWarehouse; break; }
case 10027: { Warehouse = C.Warehouses.BIWarehouse; break; }
case 44: { Warehouse = C.Warehouses.MAWarehouse; break; }
case 4101: { Warehouse = C.Warehouses.SCWarehouse; break; }
default: return new COPacket(new byte[0]);
}

In my Warehouse.cs

ArrayList Warehouse = null;
switch (NPC)
{
case 8: { Warehouse = GC.MyChar.Warehouses.TCWarehouse; break; }
case 10012: { Warehouse = GC.MyChar.Warehouses.PCWarehouse; break; }
case 10028: { Warehouse = GC.MyChar.Warehouses.ACWarehouse; break; }
case 10011: { Warehouse = GC.MyChar.Warehouses.DCWarehouse; break; }
case 10027: { Warehouse = GC.MyChar.Warehouses.BIWarehouse; break; }
case 44: { Warehouse = GC.MyChar.Warehouses.MAWarehouse; break; }
case 4101: { Warehouse = GC.MyChar.Warehouses.SCWarehouse; break; }
}

09/17/2010 06:03 -F�ng-#12

If you don't have the error then what's the problem.. you said you want to add a new warehouse. So do it? My friend that can't code can do it ... :facepalm: I don't mean to sound mean... but all you have to do is go to the definitions, copy them, and paste them to make a new Warehouse... and make a new NPC in Stone City and assign it's id to the warehouse...

09/17/2010 06:12 salem rey#13

i have then i try korvacs fix but still i still facing problem when i open my VIP and click stone city a error pop up in my source, can anyone help me here?

aha i fix it now but the problem is the old accounts cannot log in... you must make new account,.. what is the problem?

09/17/2010 07:28 -F�ng-#14

Quote:

Originally Posted by salem rey

i have then i try korvacs fix but still i still facing problem when i open my VIP and click stone city a error pop up in my source, can anyone help me here?

aha i fix it now but the problem is the old accounts cannot log in... you must make new account,.. what is the problem?

Please read what I said... =[
Korvac's fix isn't for you because you don't have that problem. You're not trying hard enough. Look at the code in front of you. Right click what you don't understand and say "follow to definition" or whatever it is. :facepalm: Please don't just respond with "idk"- say what you tried to do and we might help.

09/17/2010 08:33 Ian*#15

Quote:

Originally Posted by salem rey

i have then i try korvacs fix but still i still facing problem when i open my VIP and click stone city a error pop up in my source, can anyone help me here?

aha i fix it now but the problem is the old accounts cannot log in... you must make new account,.. what is the problem?

Google how to use break points in visual studios.

Set breakpoints within your switch, try depositing an item in your warehouse, see which line the error occurs on, and then let us know exactly where the exception is thrown.

Page 1 of 2