Redux - Observing friend/enemy gears and item unlock

Quote:

Originally Posted by moorrr However, when trying to observe a player's gear through the Friend/Enemy list window using the "Check" button, the client sends a MsgAction(1010) packet with action = 310. Returning MsgItemInformation packets for each item doesn't work; the observe window opens but displays the observing player's own character (not the target) with empty items. Is there an additional packet that needs to be sent by the server to update the observing window with the target player's character and gear?

        public async Task QueryFriendEquipmentAsync(Client client)
        {
            if (client.Character == null)
                return;

            if (client.Character.Relationships == null)
                return;

            if (!(client.Character.Relationships.ContainsFriend(Command) || client.Character.Relationships.ContainsEnemy(Command)))
                return;

            if (!ServerCollections.TryGetCharacter(Command, out var targetCharacter))
                return;

            await CharacterObservationAsync(client);
        }
        public async Task CharacterObservationAsync(Client client)
        {
            if (client.Character == null)
                return;

            if (!client.Character.Alive)
                return;

            if (!ServerCollections.TryGetCharacter(Command, out var targetCharacter))
                return;

            if (!targetCharacter.Alive)
                return;

            if (!CalculationEngine.CanSee(client.Character, targetCharacter, 18))
                return;


            await client.SendAsync(MsgPlayer.SpawnPlayer(targetCharacter));
            foreach (var equippedItem in targetCharacter.Equipment.GetAllEquippedItems())
            {
                await client.SendAsync(MsgItemInfo.CreateItemWithOwner(targetCharacter.UniqueID, equippedItem, ItemActionFlag.OtherPlayerEquipment));
            }
        }

Quote:

Originally Posted by Arcо iirc, you need to send 1014 with the target character to the client first. Here's my function for it.  Spoiler Code: public async Task QueryFriendEquipmentAsync(Client client) { if (client.Character == null) return; if (client.Character.Relationships == null) return; if (!(client.Character.Relationships.ContainsFriend(Command) || client.Character.Relationships.ContainsEnemy(Command))) return; if (!ServerCollections.TryGetCharacter(Command, out var targetCharacter)) return; await CharacterObservationAsync(client); } public async Task CharacterObservationAsync(Client client) { if (client.Character == null) return; if (!client.Character.Alive) return; if (!ServerCollections.TryGetCharacter(Command, out var targetCharacter)) return; if (!targetCharacter.Alive) return; if (!CalculationEngine.CanSee(client.Character, targetCharacter, 18)) return; await client.SendAsync(MsgPlayer.SpawnPlayer(targetCharacter)); foreach (var equippedItem in targetCharacter.Equipment.GetAllEquippedItems()) { await client.SendAsync(MsgItemInfo.CreateItemWithOwner(targetCharacter.UniqueID, equippedItem, ItemActionFlag.OtherPlayerEquipment)); } }

Quote:

Originally Posted by CptSky To add to Arco's comment. The MsgPlayer packet has a small flag near the end to indicate that it is a "remote" player, which may not be on screen. Most sources do not set this flag properly, which makes the querying broken when the player isn't already in screen. I see that Arco's example seem to just always restrict the query range. Also, the fact that the MsgPlayer packet is sent can be abused, so make sure to only send it when querying through the friends interface. It simplifies the patches you need to do. You might wonder how it can be abused? 1. The client teleports the target player to the position in the packet, so by spamming the query equipment request (like using a proxy to do so), you can know where the target stands directly (even when it jumps) and makes PvP easier. 2. The packet can be used to track players on the map and know their specific position (if you enable the out-of-range querying). There are protections possible for both.

Quote:

Originally Posted by CptSky To add to Arco's comment. The MsgPlayer packet has a small flag near the end to indicate that it is a "remote" player, which may not be on screen. Most sources do not set this flag properly, which makes the querying broken when the player isn't already in screen. I see that Arco's example seem to just always restrict the query range. Also, the fact that the MsgPlayer packet is sent can be abused, so make sure to only send it when querying through the friends interface. It simplifies the patches you need to do. You might wonder how it can be abused? 1. The client teleports the target player to the position in the packet, so by spamming the query equipment request (like using a proxy to do so), you can know where the target stands directly (even when it jumps) and makes PvP easier. 2. The packet can be used to track players on the map and know their specific position (if you enable the out-of-range querying). There are protections possible for both.

Quote:

Originally Posted by moorrr It worked! Apparently the flag that you was talking about wasn't documented anywhere in the sources that I known of: [Only registered and activated users can see links. Click Here To Register...] [Only registered and activated users can see links. Click Here To Register...] (might be Window Spawn offset?) So for those interested, in patch 5065 the "remote" flag in MsgPlayer is at offset 64, set it to true before observing friend/enemy equips. Thanks guys! :)