AsyncServerClient: Simple, open-source, cross-platform Async TCP Server-Client

Quote:

Originally Posted by _DeaLyDeviL_ *Three-Way TCP Handshaking feature

while (s_master != null)
            {
                lock (m_Locker)
                {
                    try
                    {
                        Socket client = s_master.AcceptSocket();
                        [...]
                }
                Thread.Sleep(1);
            }

Quote:

Originally Posted by _DeaLyDeviL_ It is designed in the bare-minimum struct.

Quote:

Originally Posted by warfley The fuck are you talking about? Usually your Operating system should take care of the 3-Way-Handshake of TCP, and not a single line of code by you should be dedicated to implementing the 3WHS. What you implemented is a Handshake for encryption, and it's insecure AF.

Quote:

Originally Posted by warfley Your Blowfish key is 32 bit Integer, and can be brute forced within seconds by any modern day computer. Your signing algorithm utilizes on the Hardness of the discrete log problem, but also only operates on 32 bit integers, meaning any modern day computer can crack this within seconds.

Quote:

Originally Posted by warfley If you want to have a secure TCP connection, use TLS implemented by a modern day library like the OpenSSL. Never (in a productive project) try to implement it yourself, ever. You will make mistakes, and your approach will be less secure (and performant) the libraries which are written by dozens of professionals over the course of decades.

Quote:

Originally Posted by warfley Why using SQL? As this is meant to be an example, why use SQL at all doesn't this overcomplicate everything? Just use text files, no special software (SQL server) is than required and it fulfills the same purpose. Personally, as long as concurrency doesn't get a big problem (i.e. hundreds of connections at once) I usually always use files, because installing an sql server, creating the database structure and implementing the SQL functionality is hell of a lot work that I can just skip

Quote:

Originally Posted by warfley Accept is blocking, meaning this line of code could eventually take for ever. I think what you want to do is lock the server so it can't be set to null (i.e. stop listening) until the accept action is performed. But as s_master.AcceptSocket could take indefenetly, this could block you whole program. I would recommend you to rethink your locking philosophy, because actually this lock is never used again if I can see correctly, rendering it completely useless, except to prevent startListener from interfering if executed multiple times, but this should be prevented by your design in the first place. So this lock just handles a case that shouldn't (be possible to) occur. Seems useless to me

private readonly ManualResetEvent m_manualResetEvent = new ManualResetEvent(false);

protected void DOBeginAccepter() {
	while (m_listenerSocket != null) {
		m_manualResetEvent.Reset();
		try {
			m_listenerSocket.BeginAccept(new AsyncCallback(DOConnectionAccepter), m_listenerSocket);
		} catch { }
		m_manualResetEvent.WaitOne();
	}
}

protected void DOConnectionAccepter(IAsyncResult iar) {
	Socket socket = null;

	m_manualResetEvent.Set();

	try {
		socket = m_listenerSocket.EndAccept(iar);
	} catch (SocketException e) {
		throw new Exception("XXX " + e.ToString());

	} catch (ObjectDisposedException e) {
		throw new Exception("YYY " + e.ToString());
	}

	//...
   
}

Quote:

Originally Posted by warfley Why the fuck is it then overengineered like that? I know .Net developers often suffer from OOP-Tourette, but I can write a bare minimum TCP server, using OpenSSL for better security than yours in C in around 200 lines of Code (Including cross platform switches). A bare minimum C# project shouldn't be more than 4 times as much code than the bare minimum C variant.

Quote:

Originally Posted by _DeaLyDeviL_ First of all, thank you for your valuable comment. I have to say a few things. Firstly, i understand your rage clearly. And i think, you didn't read somethings that in the README. And I would like to remind you that I did the project in 2015.

Quote:

Originally Posted by _DeaLyDeviL_ 2. Eveybody knows Blowfish is too bad and F* waste. Yes, you of course can crack it within seconds. But SSA.dll uses Blowfish to encrypting somethings. That's why I'm stick with it. I would also love to use RSA-4096, then you can't crack this unless if you have a super computer, isn't it?

Quote:

I do not remember exactly what I would do with this project 4 years ago. It was probably part of the project. Why did you get rage at that? Server and SQL are inseparable lovers.

Quote:

The most sensible comment part for me. Thanks for that. Because I didn't know what is Blocking-NonBlocking sockets then. But now, maybe i can write a better struct for main accepter. What about this one? Code: private readonly ManualResetEvent m_manualResetEvent = new ManualResetEvent(false); protected void DOBeginAccepter() { while (m_listenerSocket != null) { m_manualResetEvent.Reset(); try { m_listenerSocket.BeginAccept(new AsyncCallback(DOConnectionAccepter), m_listenerSocket); } catch { } m_manualResetEvent.WaitOne(); } } protected void DOConnectionAccepter(IAsyncResult iar) { Socket socket = null; m_manualResetEvent.Set(); try { socket = m_listenerSocket.EndAccept(iar); } catch (SocketException e) { throw new Exception("XXX " + e.ToString()); } catch (ObjectDisposedException e) { throw new Exception("YYY " + e.ToString()); } //... } I really don't know, I created this structure in my previous project. What do you think?

while (!terminated) {
  if (!s_master.Pending()) { Sleep(1); continue; } // break fast break even
  Socket client = s_master.AcceptSocket();
  ...
}

void StopAcception() { terminated = true; }

Quote:

Originally Posted by _DeaLyDeviL_ It just for advertising actually. And also i can write in around a few lines in Rust with better and more secure way (Including cross platform switches) if you want to race. :)