[OpenNos/Collection] Crash fixes

Page 1 of 3

03/17/2018 20:39 Shıgeo#1

Hello Shigeo here and I want to help you to fix your ON Bugs. (Packet Crashes, Dupes etc.)
I have just one request, leave my texts as they are.

Hf

PetMove (CRASH): (NpcPacketHandler.cs)

Spoiler

DeleteCharacter (CRASH): (CharacterScreenPacketHandler.cs)

Spoiler

Code:

public void DeleteCharacter(CharacterDeletePacket characterDeletePacket)
{
	if (Session.HasCurrentMapInstance)
	{
		return;
	}
	Logger.LogUserEvent("DELETECHARACTER", Session.GenerateIdentity(), $"[DeleteCharacter]Name: {characterDeletePacket.Slot}");
	AccountDTO account = DAOFactory.AccountDAO.LoadById(Session.Account.AccountId);
	if (account == null)
	{
		return;
	}
	if (account.Password.ToLower() == CryptographyBase.Sha512(characterDeletePacket.Password))
	{
		CharacterDTO character = DAOFactory.CharacterDAO.LoadBySlot(account.AccountId, characterDeletePacket.Slot);
		if (character == null)
		{
			return;
		}
		DAOFactory.GeneralLogDAO.SetCharIdNull(Convert.ToInt64(character.CharacterId));
		DAOFactory.CharacterDAO.DeleteByPrimaryKey(account.AccountId, characterDeletePacket.Slot);
		LoadCharacters(string.Empty);
	}
	else
	{
		Session.SendPacket($"info {Language.Instance.GetMessageFromKey("BAD_PASSWORD")}");
	}
}

Code:

public void DeleteCharacter(CharacterDeletePacket characterDeletePacket)
{
	if (Session.HasCurrentMapInstance)
	{
		return;
	}
	Logger.LogUserEvent("DELETECHARACTER", Session.GenerateIdentity(), $"[DeleteCharacter]Name: {characterDeletePacket.Slot}");
	AccountDTO account = DAOFactory.AccountDAO.LoadById(Session.Account.AccountId);
	if (account == null)
	{
		return;
	}
	if (characterDeletePacket.Password == null)
	{
		Session.SendPacket($"info Fixxed by Shigeo: https://www.elitepvpers.com/forum/nostale/4451612-crash-fixes-collection.html");
		Logger.Log.Debug($"ShigeoWall: account {Session.Account.Name} tried a Crash: DeleteCharacter");
		return;
	}
	if (account.Password.ToLower() == CryptographyBase.Sha512(characterDeletePacket.Password))
	{
		CharacterDTO character = DAOFactory.CharacterDAO.LoadBySlot(account.AccountId, characterDeletePacket.Slot);
		if (character == null)
		{
			return;
		}
		DAOFactory.GeneralLogDAO.SetCharIdNull(Convert.ToInt64(character.CharacterId));
		DAOFactory.CharacterDAO.DeleteByPrimaryKey(account.AccountId, characterDeletePacket.Slot);
		LoadCharacters(string.Empty);
	}
	else
	{
		Session.SendPacket($"info {Language.Instance.GetMessageFromKey("BAD_PASSWORD")}");
	}
}

MultiTargetListHit (CRASH): (BattlePacketHandler.cs)

Spoiler

Code:

public void MultiTargetListHit(MultiTargetListPacket mutliTargetListPacket)
{
	if (!Session.HasCurrentMapInstance)
	{
		return;
	}
	bool isMuted = Session.Character.MuteMessage();
	if (isMuted || Session.Character.IsVehicled)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		return;
	}
	if ((DateTime.Now - Session.Character.LastTransform).TotalSeconds < 3)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		Session.SendPacket(UserInterfaceHelper.GenerateMsg(Language.Instance.GetMessageFromKey("CANT_ATTACK"), 0));
		return;
	}
	if (mutliTargetListPacket.TargetsAmount > 0 && mutliTargetListPacket.TargetsAmount == mutliTargetListPacket.Targets.Count && mutliTargetListPacket.Targets != null)
	{
		Session.Character.MTListTargetQueue.Clear();
		foreach (MultiTargetListSubPacket subpacket in mutliTargetListPacket.Targets)
		{
			Session.Character.MTListTargetQueue.Push(new MTListHitTarget(subpacket.TargetType, subpacket.TargetId));
		}
	}
}

Code:

public void MultiTargetListHit(MultiTargetListPacket mutliTargetListPacket)
{
	if (!Session.HasCurrentMapInstance)
	{
		return;
	}
	bool isMuted = Session.Character.MuteMessage();
	if (isMuted || Session.Character.IsVehicled)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		return;
	}
	if ((DateTime.Now - Session.Character.LastTransform).TotalSeconds < 3)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		Session.SendPacket(UserInterfaceHelper.GenerateMsg(Language.Instance.GetMessageFromKey("CANT_ATTACK"), 0));
		return;
	}
	if (mutliTargetListPacket.TargetsAmount > 0 && mutliTargetListPacket.Targets == null)
	{
		Session.SendPacket($"say 1 0 10 Fixxed by Shigeo: https://www.elitepvpers.com/forum/nostale/4451612-crash-fixes-collection.html");
		Logger.Log.Debug($"ShigeoWall: user {Session.Character.Name} tried an Crash: MultiTargetListHit");
		return;
	}
	if (mutliTargetListPacket.TargetsAmount > 0 && mutliTargetListPacket.TargetsAmount == mutliTargetListPacket.Targets.Count && mutliTargetListPacket.Targets != null)
	{
		Session.Character.MTListTargetQueue.Clear();
		foreach (MultiTargetListSubPacket subpacket in mutliTargetListPacket.Targets)
		{
			Session.Character.MTListTargetQueue.Push(new MTListHitTarget(subpacket.TargetType, subpacket.TargetId));
		}
	}
}

NRun (Gold BUG): (NRunHandler.cs)

Spoiler

Code:

case 17:
	double currentRunningSeconds = (DateTime.Now - Process.GetCurrentProcess().StartTime.AddSeconds(-50)).TotalSeconds;
	double timeSpanSinceLastPortal = currentRunningSeconds - Session.Character.LastPortal;
	if (!(timeSpanSinceLastPortal >= 4) || !Session.HasCurrentMapInstance || ServerManager.Instance.ChannelId == 51 || Session.CurrentMapInstance.MapInstanceId == ServerManager.Instance.ArenaInstance.MapInstanceId || Session.CurrentMapInstance.MapInstanceId == ServerManager.Instance.FamilyArenaInstance.MapInstanceId)
	{
		Session.SendPacket(Session.Character.GenerateSay(Language.Instance.GetMessageFromKey("CANT_MOVE"), 10));
		return;
	}
	if (Session.Character.Gold >= 500 * (1 + packet.Type))
	{
		Session.Character.LastPortal = currentRunningSeconds;
		Session.Character.Gold -= 500 * (1 + packet.Type);
		Session.SendPacket(Session.Character.GenerateGold());
		MapCell pos = packet.Type == 0 ? ServerManager.Instance.ArenaInstance.Map.GetRandomPosition() : ServerManager.Instance.FamilyArenaInstance.Map.GetRandomPosition();
		ServerManager.Instance.ChangeMapInstance(Session.Character.CharacterId, packet.Type == 0 ? ServerManager.Instance.ArenaInstance.MapInstanceId : ServerManager.Instance.FamilyArenaInstance.MapInstanceId, pos.X, pos.Y);
	}
	else
	{
		Session.SendPacket(Session.Character.GenerateSay(Language.Instance.GetMessageFromKey("NOT_ENOUGH_MONEY"), 10));
	}
	break;

Code:

case 17:
	double currentRunningSeconds = (DateTime.Now - Process.GetCurrentProcess().StartTime.AddSeconds(-50)).TotalSeconds;
	double timeSpanSinceLastPortal = currentRunningSeconds - Session.Character.LastPortal;
	if (!(timeSpanSinceLastPortal >= 4) || !Session.HasCurrentMapInstance || ServerManager.Instance.ChannelId == 51 || Session.CurrentMapInstance.MapInstanceId == ServerManager.Instance.ArenaInstance.MapInstanceId || Session.CurrentMapInstance.MapInstanceId == ServerManager.Instance.FamilyArenaInstance.MapInstanceId)
	{
		Session.SendPacket(Session.Character.GenerateSay(Language.Instance.GetMessageFromKey("CANT_MOVE"), 10));
		return;
	}
	if(packet.Type < 0)
	{
		Session.SendPacket($"say 1 0 10 Fixxed by Shigeo: https://www.elitepvpers.com/forum/nostale/4451612-crash-fixes-collection.html");
		Logger.Log.Debug($"ShigeoWall: user {Session.Character.Name} tried an Gold Bug: NRun");
		return;
	}
	if (Session.Character.Gold >= 500 * (1 + packet.Type))
	{
		Session.Character.LastPortal = currentRunningSeconds;
		Session.Character.Gold -= 500 * (1 + packet.Type);
		Session.SendPacket(Session.Character.GenerateGold());
		MapCell pos = packet.Type == 0 ? ServerManager.Instance.ArenaInstance.Map.GetRandomPosition() : ServerManager.Instance.FamilyArenaInstance.Map.GetRandomPosition();
		ServerManager.Instance.ChangeMapInstance(Session.Character.CharacterId, packet.Type == 0 ? ServerManager.Instance.ArenaInstance.MapInstanceId : ServerManager.Instance.FamilyArenaInstance.MapInstanceId, pos.X, pos.Y);
	}
	else
	{
		Session.SendPacket(Session.Character.GenerateSay(Language.Instance.GetMessageFromKey("NOT_ENOUGH_MONEY"), 10));
	}
	break;

MoveItem (Itemdupe): (InventoryPacketHandler.cs) (Found by Bull.)

Spoiler

CreateCharacter (Crash): (CharacterScreenPacketHandler.cs)

Spoiler

If I helped you, just let a thanks there <3

03/17/2018 20:42 LikeAGinger#2

Thanx again mate!

03/17/2018 23:48 Tbp123#3

Nice one!

03/18/2018 21:38 Shıgeo#4

Update:
added
-MultiTargetListHit Crash fixxed

03/19/2018 05:42 0Lucifer0#5

the best way to fix every of those errors would be to find why it accept null values on packet parsing
edit : the fix should be like this [Only registered and activated users can see links. Click Here To Register...]

03/19/2018 11:59 Tbp123#6

Quote:

Originally Posted by Shıgeo

Hello I'm shigeo and I want to help you to fix your ON Bugs. (Packet Crashes, Dupes etc.)
I do it only cause' one friend (@[Only registered and activated users can see links. Click Here To Register...]) asked me about help. And I do it only for all ^^

Hf

PetMove (CRASH): (NpcPacketHandler.cs)

Spoiler

DeleteCharacter (CRASH): (CharacterScreenPacketHandler.cs)

Spoiler

Code:

public void DeleteCharacter(CharacterDeletePacket characterDeletePacket)
{
	if (Session.HasCurrentMapInstance)
	{
		return;
	}
	Logger.LogUserEvent("DELETECHARACTER", Session.GenerateIdentity(), $"[DeleteCharacter]Name: {characterDeletePacket.Slot}");
	AccountDTO account = DAOFactory.AccountDAO.LoadById(Session.Account.AccountId);
	if (account == null)
	{
		return;
	}
	if (account.Password.ToLower() == CryptographyBase.Sha512(characterDeletePacket.Password))
	{
		CharacterDTO character = DAOFactory.CharacterDAO.LoadBySlot(account.AccountId, characterDeletePacket.Slot);
		if (character == null)
		{
			return;
		}
		DAOFactory.GeneralLogDAO.SetCharIdNull(Convert.ToInt64(character.CharacterId));
		DAOFactory.CharacterDAO.DeleteByPrimaryKey(account.AccountId, characterDeletePacket.Slot);
		LoadCharacters(string.Empty);
	}
	else
	{
		Session.SendPacket($"info {Language.Instance.GetMessageFromKey("BAD_PASSWORD")}");
	}
}

Code:

public void DeleteCharacter(CharacterDeletePacket characterDeletePacket)
{
	if (Session.HasCurrentMapInstance)
	{
		return;
	}
	Logger.LogUserEvent("DELETECHARACTER", Session.GenerateIdentity(), $"[DeleteCharacter]Name: {characterDeletePacket.Slot}");
	AccountDTO account = DAOFactory.AccountDAO.LoadById(Session.Account.AccountId);
	if (account == null)
	{
		return;
	}
	if (characterDeletePacket.Password == null)
	{
		Session.SendPacket($"info Fixxed by Shigeo: https://www.elitepvpers.com/forum/nostale/4451612-crash-fixes-collection.html");
		Logger.Log.Debug($"ShigeoWall: user {Session.Character.Name} tried a Crash: DeleteCharacter");
		return;
	}
	if (account.Password.ToLower() == CryptographyBase.Sha512(characterDeletePacket.Password))
	{
		CharacterDTO character = DAOFactory.CharacterDAO.LoadBySlot(account.AccountId, characterDeletePacket.Slot);
		if (character == null)
		{
			return;
		}
		DAOFactory.GeneralLogDAO.SetCharIdNull(Convert.ToInt64(character.CharacterId));
		DAOFactory.CharacterDAO.DeleteByPrimaryKey(account.AccountId, characterDeletePacket.Slot);
		LoadCharacters(string.Empty);
	}
	else
	{
		Session.SendPacket($"info {Language.Instance.GetMessageFromKey("BAD_PASSWORD")}");
	}
}

MultiTargetListHit (CRASH): (BattlePacketHandler.cs)

Spoiler

Code:

public void MultiTargetListHit(MultiTargetListPacket mutliTargetListPacket)
{
	if (!Session.HasCurrentMapInstance)
	{
		return;
	}
	bool isMuted = Session.Character.MuteMessage();
	if (isMuted || Session.Character.IsVehicled)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		return;
	}
	if ((DateTime.Now - Session.Character.LastTransform).TotalSeconds < 3)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		Session.SendPacket(UserInterfaceHelper.GenerateMsg(Language.Instance.GetMessageFromKey("CANT_ATTACK"), 0));
		return;
	}
	if (mutliTargetListPacket.TargetsAmount > 0 && mutliTargetListPacket.TargetsAmount == mutliTargetListPacket.Targets.Count && mutliTargetListPacket.Targets != null)
	{
		Session.Character.MTListTargetQueue.Clear();
		foreach (MultiTargetListSubPacket subpacket in mutliTargetListPacket.Targets)
		{
			Session.Character.MTListTargetQueue.Push(new MTListHitTarget(subpacket.TargetType, subpacket.TargetId));
		}
	}
}

Code:

public void MultiTargetListHit(MultiTargetListPacket mutliTargetListPacket)
{
	if (!Session.HasCurrentMapInstance)
	{
		return;
	}
	bool isMuted = Session.Character.MuteMessage();
	if (isMuted || Session.Character.IsVehicled)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		return;
	}
	if ((DateTime.Now - Session.Character.LastTransform).TotalSeconds < 3)
	{
		Session.SendPacket(StaticPacketHelper.Cancel());
		Session.SendPacket(UserInterfaceHelper.GenerateMsg(Language.Instance.GetMessageFromKey("CANT_ATTACK"), 0));
		return;
	}
	if (mutliTargetListPacket.Targets == null)
	{
		Session.SendPacket($"say 1 0 10 Fixxed by Shigeo: https://www.elitepvpers.com/forum/nostale/4451612-crash-fixes-collection.html");
		Logger.Log.Debug($"ShigeoWall: user {Session.Character.Name} tried an Crash: MultiTargetListHit");
		return;
	}
	if (mutliTargetListPacket.TargetsAmount > 0 && mutliTargetListPacket.TargetsAmount == mutliTargetListPacket.Targets.Count && mutliTargetListPacket.Targets != null)
	{
		Session.Character.MTListTargetQueue.Clear();
		foreach (MultiTargetListSubPacket subpacket in mutliTargetListPacket.Targets)
		{
			Session.Character.MTListTargetQueue.Push(new MTListHitTarget(subpacket.TargetType, subpacket.TargetId));
		}
	}
}

If I helped you... give a thanks <3

I wonder if you know how are the people duping gold like hell, I don't know what are they doing, I need to fix that bug, the console doesn't log it as an event. I would be thankful if you know.

03/19/2018 22:55 Shıgeo#7

Quote:

Originally Posted by Tbp123

I wonder if you know how are the people duping gold like hell, I don't know what are they doing, I need to fix that bug, the console doesn't log it as an event. I would be thankful if you know.

Hey thanks ;)
I know how they do that. I found it too.
So you will find the fix in the next days.

03/20/2018 00:01 Tbp123#8

Quote:

Originally Posted by Shıgeo

Hey thanks ;)
I know how they do that. I found it too.
So you will find the fix in the next days.

Thank you so much!

03/20/2018 01:05 0Lucifer0#9

Quote:

Originally Posted by Shıgeo

Hey thanks ;)
I know how they do that. I found it too.
So you will find the fix in the next days.

If its the same (nre in packet handler) my fix should prevent that

03/20/2018 01:41 Shıgeo#10

Quote:

Originally Posted by 0Lucifer0

If its the same (nre in packet handler) my fix should prevent that

Nah, it's not a nre... just a changed packet ^^

03/20/2018 01:52 0Lucifer0#11

Quote:

Originally Posted by Shıgeo

Nah, it's not a nre... just a changed packet ^^

Ok ;) because your 3 Packet fix can be fixed with my fix. That�s quite strange no one report this before because it is like this since a while...

03/20/2018 17:16 Petonio#12

Quote:

Originally Posted by Tbp123

I wonder if you know how are the people duping gold like hell, I don't know what are they doing, I need to fix that bug, the console doesn't log it as an event. I would be thankful if you know.

Did you fix the bank ?

03/21/2018 01:26 Tbp123#13

Quote:

Originally Posted by Petonio

Did you fix the bank ?

I did

03/21/2018 14:03 Petonio#14

Quote:

Originally Posted by Tbp123

I did

If you know how to block a packet, i could help you. Right now i'm working on other stuff, so i'm not even trying yet

03/21/2018 17:06 LikeAGinger#15

Quote:

Originally Posted by 0Lucifer0

the best way to fix every of those errors would be to find why it accept null values on packet parsing
edit : the fix should be like this [Only registered and activated users can see links. Click Here To Register...]

It doesn't work.
I get warnings that the skill packet "guri" has the wrong value and no skills are working.

Page 1 of 3