First one, thanks for your contribution.
Quote:
Originally Posted by Noa_
Quote:
|
file.write(str(index[0])+","+str(index[1])+";")
|
|
The index[0-1] are already string, you don't need to convert it again.
Also the method how you assigned a string is very bad, already exist format like these two options.
Code:
file.write('%s,%s;' % (index[0], index[1]))
file.write('{0},{1};'.format(index[0], index[1]))
Quote:
Originally Posted by Noa_
Code:
########################################### Noa
path = "switchbot_v/"
item_type = str(type)
item_subtype = str(item.GetItemSubType())
proposals = {
1:{},#Waffen
2:{#Rüstungsteile
0:{},#Rüstung
1:{},#Helm
2:{},#Schild
3:{},#Armband
4:{},#Schuhe
5:{},#Halskette
6:{},#Ohrringe
},
}
if item_type < str(3):
if item_type == "1":
for files in os.listdir(path+item_type):
liste = self.__openfile(path+item_type+"/"+files)
for ItemList in liste:
if ItemList:
bonusID,bonusVALUE = int(ItemList.split(",")[0]),int(ItemList.split(",")[1])
if not files.replace(".txt","") in proposals[int(item_type)].keys():
proposals[int(item_type)][files.replace(".txt","")] = []
proposals[int(item_type)][files.replace(".txt","")].append([bonusID,bonusVALUE])
else:
for files in os.listdir(path+item_type+"/"+item_subtype):
liste = self.__openfile(path+item_type+"/"+item_subtype+"/"+files)
for ItemList in liste:
if ItemList:
bonusID,bonusVALUE = int(ItemList.split(",")[0]),int(ItemList.split(",")[1])
if not files.replace(".txt","") in proposals[int(item_type)][int(item_subtype)].keys():
proposals[int(item_type)][int(item_subtype)][files.replace(".txt","")] = []
proposals[int(item_type)][int(item_subtype)][files.replace(".txt","")].append([bonusID,bonusVALUE])
else:
print "Dieses Item kannst du nicht Switchen"
|
Also the style of this code from qoute is very 'bad' for some things, i don't understand what exactly you want to do, but doesn't looks good.
I would like to do some changes like that.
Code:
def replace_method(fileName, dest = ['.txt', '']):
return fileName.replace(*dest)
def split_method(item):
buffer = item.split(',')
return [buffer[c].__int__() for c in xrange(len(buffer))]
def default_dict_method():
return {1: dict(), 2: {item: dict() for item in xrange(item.ITEM_TYPE_SPECIAL + 1)}}
pathName = 'switchbot_v/'
proposals = default_dict_method()
itemType = item.GetItemType()
itemSubType = item.GetItemSubType()
if itemType < item.ITEM_TYPE_USE:
if itemType == item.ITEM_TYPE_WEAPON:
for fileName in os.listdir('{0}{1}'.format(pathName, itemType)):
for item in self.__openfile('{0}{1}/{2}'.format(pathName, itemType, fileName)):
if item:
if not replace_method(fileName) in proposals[itemType].keys():
proposals[itemType][replace_method(fileName)] = list()
proposals[itemType][replace_method(fileName)].append(split_method(item))
else:
for fileName in os.listdir('{0}{1}/{2}'.format(pathName, itemType, itemSubType)):
for item in self.__openfile('{0}{1}/{2}/{3}'.format(pathName, itemType, itemSubType, fileName)):
if item:
if not replace_method(fileName) in proposals[itemType][itemSubType].keys():
proposals[itemType][itemSubType][replace_method(fileName)] = list()
proposals[itemType][itemSubType][replace_method(fileName)].append(split_method(item))
else:
print 'Dieses Item kannst du nicht Switchen'
