Did noone test this "Fix"?
Quote:
unter
Code:
D3DXVECTOR3 vPos = *pvPosition - m_vPosListener;
double fRadian = sqrt14(
fabs ( vPos.x ) * fabs ( vPos.x ) + fabs ( vPos.z ) * fabs ( vPos.z ) );
//Radian *= 2.0f;
if( fRadian > 100.0 )
return FALSE;
Fügt ihr das ein:
Code:
else if (fRadian < 0.0)
{
D3DVECTOR vec;
m_pDSListener->GetPosition(&vec);
pSound->m_pBufferParams[dwIndex].vPosition.x = vec.x;
pSound->m_pBufferParams[dwIndex].vPosition.y = vec.y;
pSound->m_pBufferParams[dwIndex].vPosition.z = vec.z;
}
|
fRadian is calculated with the Pythagorean theorem. It represents the distance between the soundsource and the player.
A sqrt has always a negative and a positive result, but std:sqrt does only return the positive value!
So fRadian can never be smaller than 0.0!
The second Problem is that even if fRadian would get smaller than 0.0 and the else part is hit it would change nothing, because some lines later pSound->m_pBufferParams[dwIndex].vPosition will be overwritten:
Code:
vPos.x = (float)( (int)(sin( a ) * fRadian ) ); // 여기 (int)캐스팅 바꾸지 말것. (int)안하면 컴터 리붓됨.
vPos.z = (float)( (int)(cos( a ) * fRadian ) );
vPos.y = (float)( (int) vPos.y );
D3DVECTOR v;
v.x = vPos.x; // 혹시 몰라 이렇게 해봤다.
v.y = vPos.y;
v.z = vPos.z;
pSound->m_pBufferParams[dwIndex].vPosition = v; // D3XVECTOR3를 D3DVECTOR에 그대로 넣어도 되나?
I think this would make more sense:
Code:
D3DXVECTOR3 vPos = *pvPosition - m_vPosListener;
FLOAT fRadian = sqrt(
fabs ( vPos.x ) * fabs ( vPos.x ) + fabs ( vPos.z ) * fabs ( vPos.z ) );
//Radian *= 2.0f;
if( fRadian > 100.0f )
return FALSE;
#ifdef __SOUND_BUG_FIX
else if (fRadian == 0.0)
m_pDSListener->GetPosition(&pSound->m_pBufferParams[dwIndex].vPosition);
else
#endif // __SOUND_BUG_FIX
{
D3DXVECTOR3 Line1 = D3DXVECTOR3( 0.0f, 0.0f, -1.0f );
D3DXVECTOR3 Line2 = -vPos;
//Line2 = m_world.m_vCenter - Line2;
// Nomralize Vectors
FLOAT vlength = sqrt( ( Line2.x * Line2.x ) + ( Line2.z * Line2.z ) );
Line2 = Line2 / vlength;
// 라디안 구하기
FLOAT a = acos( D3DXVec3Dot( &Line1, &Line2 ) );
//a = ( D3DX_PI * 2.0f ) - a;
if( vPos.x < 0 )
a = ( D3DX_PI * 2.0f ) - a;
a += -m_fTheta;
vPos.x = (float)( (int)(sin( a ) * fRadian ) ); // 여기 (int)캐스팅 바꾸지 말것. (int)안하면 컴터 리붓됨.
vPos.z = (float)( (int)(cos( a ) * fRadian ) );
vPos.y = (float)( (int) vPos.y );
D3DVECTOR v;
v.x = vPos.x; // 혹시 몰라 이렇게 해봤다.
v.y = vPos.y;
v.z = vPos.z;
pSound->m_pBufferParams[dwIndex].vPosition = v; // D3XVECTOR3를 D3DVECTOR에 그대로 넣어도 되나?
}
}
I tested it but somehow it plays the sound with and without the fix. Perhabs I fixed it somewhere else long time ago.
