[Release] [Untested] Awarding Halos

12/06/2009 01:25 Andrew.A#1
Im not entirely sure this works but its an idea. Someone try this out or tell me whats wrong please.

Chat.cs
Code:
                               if (Cmd[0] == "/awardtopWarrior")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopWarrior);
                               if (Cmd[0] == "/awardtopTrojan")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopTrojan);
                               if (Cmd[0] == "/awardtopFire")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopFireTaoist);
                               if (Cmd[0] == "/awardtopWater")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopWaterTaoist);
                               if (Cmd[0] == "/awardtopArcher")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopArcher);
                               if (Cmd[0] == "/awardtopNinja")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopNinja);
                               if (Cmd[0] == "/RemovetopWarrior")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWarrior);
                               if (Cmd[0] == "/RemovetopTrojan")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopTrojan);
                               if (Cmd[0] == "/RemovetopFire")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopFireTaoist);
                               if (Cmd[0] == "/RemovetopWater")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWaterTaoist);
                               if (Cmd[0] == "/RemovetopArcher")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopArcher);
                               if (Cmd[0] == "/RemovetopNinja")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopNinja);
                       if (Cmd[0] == "/RemovetopWeek")
                            #region Players
                            try
                            {
                                foreach (Game.Character Player in Game.World.H_Chars.Values)
                            #endregion
                                    Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.WeeklyPKChampion);
                        if (Cmd[0] == "/RemovetopMonth")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.MonthlyPKChampion);
                               if (Cmd[0] == "/RemovetopWarrior")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWarrior);
                               if (Cmd[0] == "/RemovetopTrojan")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopTrojan);
                               if (Cmd[0] == "/RemovetopFire")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopFireTaoist);
                               if (Cmd[0] == "/RemovetopWater")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWaterTaoist);
                               if (Cmd[0] == "/RemovetopArcher")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopArcher);
                               if (Cmd[0] == "/RemovetopNinja")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopNinja);
                       if (Cmd[0] == "/RemovetopWeek")
                            #region Players
                            try
                            {
                                foreach (Game.Character Player in Game.World.H_Chars.Values)
                            #endregion
                                    Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.WeeklyPKChampion);
                        if (Cmd[0] == "/RemovetopMonth")
                                    #region Players
                                    try
                                    {
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.MonthlyPKChampion);
12/06/2009 01:32 airborne.#2
You should test it before releasing it. Anyway, yeah fix it and update it. Then +k. Nice try though.
12/06/2009 11:56 Korvacs#3
That wont compile, i can tell you that already, you either need to remove the try { or close it with anouther bracket and add the catch aswell.
12/06/2009 14:32 Tw3ak#4
Also there is no need for command for each halo like that when you can split it up all into 1 command.

For example would be better to do like this.

/halo TopGuildLeader
/halo TopDeputyLeader
/halo TopFiretaoist


ect ect instead of doing a seperate command for each type of halos just have a static command and then add all the variables to it to do all the halos.

Will be much cleaner in the source.

You can simply look at how commands that exist allready do this such as /effect and you will see how to do it with halos as well.
12/06/2009 18:55 Basser#5
Code:
                               if (Cmd[0] == "/awardtopWarrior")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopWarrior);
                               if (Cmd[0] == "/awardtopTrojan")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopTrojan);
                               if (Cmd[0] == "/awardtopFire")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopFireTaoist);
                               if (Cmd[0] == "/awardtopWater")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopWaterTaoist);
                               if (Cmd[0] == "/awardtopArcher")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopArcher);
                               if (Cmd[0] == "/awardtopNinja")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Add(NewestCOServer.Game.StatusEffectEn.TopNinja);
                               if (Cmd[0] == "/RemovetopWarrior")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWarrior);
                               if (Cmd[0] == "/RemovetopTrojan")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopTrojan);
                               if (Cmd[0] == "/RemovetopFire")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopFireTaoist);
                               if (Cmd[0] == "/RemovetopWater")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWaterTaoist);
                               if (Cmd[0] == "/RemovetopArcher")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopArcher);
                               if (Cmd[0] == "/RemovetopNinja")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopNinja);
                       if (Cmd[0] == "/RemovetopWeek")
                            #region Players
                                foreach (Game.Character Player in Game.World.H_Chars.Values)
                            #endregion
                                    Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.WeeklyPKChampion);
                        if (Cmd[0] == "/RemovetopMonth")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.MonthlyPKChampion);
                               if (Cmd[0] == "/RemovetopWarrior")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWarrior);
                               if (Cmd[0] == "/RemovetopTrojan")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopTrojan);
                               if (Cmd[0] == "/RemovetopFire")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopFireTaoist);
                               if (Cmd[0] == "/RemovetopWater")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopWaterTaoist);
                               if (Cmd[0] == "/RemovetopArcher")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopArcher);
                               if (Cmd[0] == "/RemovetopNinja")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.TopNinja);
                       if (Cmd[0] == "/RemovetopWeek")
                            #region Players
                                foreach (Game.Character Player in Game.World.H_Chars.Values)
                            #endregion
                                    Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.WeeklyPKChampion);
                        if (Cmd[0] == "/RemovetopMonth")
                                    #region Players
                                        foreach (Game.Character Player in Game.World.H_Chars.Values)
                                    #endregion
                                            Player.StatEff.Remove(NewestCOServer.Game.StatusEffectEn.MonthlyPKChampion);
I do not recommened using this, it is not very good in my opinion.
Don't feel like telling you guys why, its obvious for who ever actually knows what a boolean (simply: bool) is.