In-Orbit Official Emulator

08/09/2014 22:52 SYSTEMEWAR#1
Its ready In-Orbit Emulator was now released

You need to use In_Orbit CMS for use this Emulator

[Only registered and activated users can see links. Click Here To Register...]

EQUIPEMENT SYSTEM NOT ADDED

[Only registered and activated users can see links. Click Here To Register...]

Copyright statement:



[Only registered and activated users can see links. Click Here To Register...]
PHP Code:
[URL=http://www.elitepvpers.com/forum/darkorbit/3318021-release-orbit-private-server-website.html][IMG]http://i.epvpimg.com/9Iorg.png[/IMG][/URL] 
Credit : BAU for CMS and Help =)

Best Regards Dr-Batcher
08/09/2014 23:10 Toxicsnacht#2
Sorry but dont work, stopped after message -> loaded 117ships. Have done all things ( new db and in-orbit cms)
08/09/2014 23:14 SYSTEMEWAR#3
look into Map table
08/09/2014 23:15 Toxicsnacht#4
what map table? more informations please
08/09/2014 23:21 Luffa#5
Quote:
Originally Posted by Toxicsnacht View Post
Sorry but dont work, stopped after message -> loaded 117ships. Have done all things ( new db and in-orbit cms)
Quote:
Originally Posted by Toxicsnacht View Post
what map table? more informations please
This issue is is solved by deleting some of the maps in the table.

[Only registered and activated users can see links. Click Here To Register...]

When it comes to the official part. I will recognize that this can be used to in-orbit.
Best Regards Bau
08/09/2014 23:58 quinster08#6
Very nice job. Only the cool thing from in-orbit is the equipment, and equipment is not working. But still good job.
08/10/2014 00:06 Moonsteroid#7
From the Features that was listet : Good Job Guys!
I'm happy to know that i can host soon my own DarkOrbit Private server ;)
And I hope you will make the equipment too :)

Greeting IGnoXX
08/10/2014 00:21 cryz35#8
Sorry but your code hurts my eyes..Especially the newuser part :(
Thanks for sharing anyways.
08/10/2014 00:26 SYSTEMEWAR#9
haha !!

In all thread for Emulator i see critic.
So upload your own emulator for community ;)
But if you can go create constructive critic.

And my code work nice.
08/10/2014 08:32 «Ice.Shock™#10
Quote:
Originally Posted by SYSTEMEWAR View Post
haha !!

In all thread for Emulator i see critic.
So upload your own emulator for community ;)
But if you can go create constructive critic.

And my code work nice.
Let me remind you for 1 thing in life, if you want something good you must pay for it. And also he released PHP emulator that is still a lot of work.
08/10/2014 11:13 th0rex#11
Ok so you want constructive critic ?
Here we go.

So first off just follow one rule: One class/enum per file. Filename = Classname. Would make things more clear.

Document your things. There are nearly no comments at all. When there is stuff commented it's just stupid like this:
Code:
NewConnected(); // Check If New Connected
You should make the names of the methods expressive. Good code explains itself.

Stay to one naming convention.

Use given functions from dictionarys.
Code:
if (Core.Config.Users.ContainsKey(userId))
                {
                    name = Core.Config.Users[userId].GetUser().Name;
                    userConfig = Core.Config.Users[userId].GetUser().Settings;
                    mapId = Core.Config.Users[userId].GetUser().MapId;
                    shipId = Core.Config.Users[userId].GetUser().ShipId;
                    factionId = Core.Config.Users[userId].GetUser().FactionId;

                    x = Core.Config.Users[userId].GetUser().X;
                    xz = Core.Config.Users[userId].GetUser().XZ;
                    y = Core.Config.Users[userId].GetUser().Y;
                    yz = Core.Config.Users[userId].GetUser().YZ;
                    toX = Core.Config.Users[userId].GetUser().ToX;
                    toY = Core.Config.Users[userId].GetUser().ToY;
//... much more of such shit
Can be made to this
Code:
Conn value;
                if (Core.Config.Users.TryGetValue(userId, out value))
                {
                    name = value.GetUser().Name;
                    userConfig = value.GetUser().Settings;
                    mapId = value.GetUser().MapId;
                    shipId = value.GetUser().ShipId;
                    factionId = value.GetUser().FactionId;

                    x = value.GetUser().X;
                    xz = value.GetUser().XZ;
                    y = value.GetUser().Y;
                    yz = value.GetUser().YZ;
                    toX = value.GetUser().ToX;
                    toY = value.GetUser().ToY;
That version will be faster because the old one called too many functions.

Write wrappers around the raw strings used in packets. Will be cleaner.

I could have gone into depth with every single of that suggestions but I will not because I have better things to do. Just remember those things when programming.

I just wanted to say that I think it is a shame that this is the official emulator for such an great cms.
08/10/2014 11:48 SYSTEMEWAR#12
Quote:
Originally Posted by omitma View Post
Ok so you want constructive critic ?
Here we go.

So first off just follow one rule: One class/enum per file. Filename = Classname. Would make things more clear.

Document your things. There are nearly no comments at all. When there is stuff commented it's just stupid like this:
Code:
NewConnected(); // Check If New Connected
You should make the names of the methods expressive. Good code explains itself.

Stay to one naming convention.

Use given functions from dictionarys.
Code:
if (Core.Config.Users.ContainsKey(userId))
                {
                    name = Core.Config.Users[userId].GetUser().Name;
                    userConfig = Core.Config.Users[userId].GetUser().Settings;
                    mapId = Core.Config.Users[userId].GetUser().MapId;
                    shipId = Core.Config.Users[userId].GetUser().ShipId;
                    factionId = Core.Config.Users[userId].GetUser().FactionId;

                    x = Core.Config.Users[userId].GetUser().X;
                    xz = Core.Config.Users[userId].GetUser().XZ;
                    y = Core.Config.Users[userId].GetUser().Y;
                    yz = Core.Config.Users[userId].GetUser().YZ;
                    toX = Core.Config.Users[userId].GetUser().ToX;
                    toY = Core.Config.Users[userId].GetUser().ToY;
//... much more of such shit
Can be made to this
Code:
Conn value;
                if (Core.Config.Users.TryGetValue(userId, out value))
                {
                    name = value.GetUser().Name;
                    userConfig = value.GetUser().Settings;
                    mapId = value.GetUser().MapId;
                    shipId = value.GetUser().ShipId;
                    factionId = value.GetUser().FactionId;

                    x = value.GetUser().X;
                    xz = value.GetUser().XZ;
                    y = value.GetUser().Y;
                    yz = value.GetUser().YZ;
                    toX = value.GetUser().ToX;
                    toY = value.GetUser().ToY;
That version will be faster because the old one called too many functions.

Write wrappers around the raw strings used in packets. Will be cleaner.

I could have gone into depth with every single of that suggestions but I will not because I have better things to do. Just remember those things when programming.
Thanks.

Quote:
I just wanted to say that I think it is a shame that this is the official emulator for such an great cms.
not thanks ^^


I'm a beginner so i think this comment was better than oh you hurt my eyes
And i try to upload new release better for your eyes :)

Best Regards Dr-Batcher
08/10/2014 12:23 nckrnckr#13
[Only registered and activated users can see links. Click Here To Register...]


I don't really understand.
Why not start? :confused:
08/10/2014 12:25 Luffa#14
Quote:
Originally Posted by nckrnckr View Post
[Only registered and activated users can see links. Click Here To Register...]


I don't really understand.
Why not start? :confused:
May i ask you to take a look at:
[Only registered and activated users can see links. Click Here To Register...]


This emulator is built on azure.
And Azure can't handle that many maps.

Best Regards Bau
08/10/2014 12:27 CoolJedy#15
Quote:
Originally Posted by nckrnckr View Post
[Only registered and activated users can see links. Click Here To Register...]


I don't really understand.
Why not start? :confused:
Leave only the first three maps