Quote:
Originally Posted by abdoumatrix
like what?
|
When the original source was created, it was stitched together very quickly. As a result, the data handling for most packets is half-assed. For example, the map and screen systems handle the clients incorrectly and inefficiently, using far more packets than they should to process map objects. Some systems use too many threads and locks due to incorrect ways to manage multithreading, and thus create deadlocks in the source. I want to believe that it's a good source since it was created by a mentor of mine, but the design is weak. I'm sure the author realizes that too, which is why he no longer uses it.
On top of that, it's been modified by other "programmers" hired by people with no experience to patch it. Patching features only does so much, and when multiple people are hired to patch a source, the design is lost and safety isn't properly maintained. It creates bugs where features break the functionality of the server, or crash it completely due to a lack of safety checks. Sure, you could have patched some of those safety problems, but you won't know for sure until things go wrong.
Now, that was just me talking about your modification of that source for United. The other modifications that are public shouldn't be recommended to members. They contain keyloggers now as well. Be considerate and don't recommend Trinity modifications to members here.