NextCo V2 Extreamly basic source framework

Quote:

Originally Posted by Smaehtin Just commenting on the packet classes for now. First of all, the naming of your packets are HORRIBLE. All your packets inherit from CPacket which exposes a set of usable Readxxx methods yet ALL the packets' getter properties are using BitConverter.Toxxx. Why? Your IPacket interface has a method called ToArray that returns the packet as a byte array. Why the fuck are you exposing the byte array as a public member of CPacket then? ("public byte[] Packet;" - Packet.cs line 8) In your ChatPacket class you're exposing public members and naming them with underscore prefixes - and the "Message" member even has DOUBLE underscores. Why? There's so much more to comment on, but I'm starting to get sick from looking at this code :(

Quote:

Originally Posted by U2_Caparzo good job :) i used impulse's source as base for the first source i wrote too xdd, btw.i don't know why the CO2_CORE_DLL's cripto. implementation is almost never used, in fact, i only saw it in csv3, let's move to a native calls independency ^^

Quote:

Originally Posted by Super Aids I am on the list *.* Btw. good job on improving and good luck in the future.

Quote:

Originally Posted by Ultimation im not on list :(

Quote:

Originally Posted by Ultimation im not on list :(

Quote:

Originally Posted by Korvacs I'll be honest I haven't downloaded it to take a look, but based on a couple of the above comments you should be working on simplifying and consistency. Rewrite your packets to use either one method or the other, it doesn't matter which as long as its the same throughout. You should not go down the route of complication for the sake of complication otherwise you will end up in a situation where yes it might work but its needlessly complicated to the point of confusion. In other words, follow Occam's razor when coding.

public interface IPacket
{
    unsafe void WriteStringWithLength(string arg, int offset);
//rest of writexxx
    unsafe ulong ReadUInt64(int offset);
//rest of readxxx
    byte[] ToArray();
}

    public class CPacket : IPacket
    {
        public byte[] Packet;

        public unsafe void WriteString(string arg, int offset)
        {
            fixed (byte* Buffer = Packet)
            {
                ushort i = 0;
                while (i < arg.Length)
                {
                    *((byte*)(Buffer + offset + i)) = (byte)arg[i];
                    i++;
                }
            }
        }
//rest of write and read were removed just to point out what i mean, feel free to see the source for the rest of methods
        public unsafe ulong ReadUInt64( int offset)
        {
            fixed (byte* Buffer = Packet)
            {
                return *((ulong*)(Buffer + offset));
            }
        }

        public virtual byte[] ToArray()
        {
            return Packet;
        }
    }

        public DataPacket_10010_()
        {
            Packet = new byte[37 + 8];
            WriteUInt16(37, 0);
            WriteUInt16(10010, 2);
        }
        public DataPacket_10010_(byte[] buffer)
        {
            Packet = buffer;
        }
        public DataPacket_10010_(uint Identifier, uint Value1, ushort Value2, ushort Value3, ushort Type)

Quote:

Originally Posted by Super Aids Why do you put the packet-type in the class name? Wtf. What if the type changed? And especially for general data. It has changed one time and it may change another time.

Quote:

Originally Posted by Super Aids Dumb thing to do,it's pointless to do it like that and it looks ugly. Just change the file name to have the packet type and perhaps make an enum or class with constants.