[FIX]250 Items Stack (PickUp Bug)

12/11/2012 21:56 Lupetto#1

Hi all epvp members,
i'm going to release an important fix of that bug:
lot of p.servers have encreased the max slot capacity to 250 (Original was 200).
All of them, have an important bug, i will try to explain what is the bug:
If you have, for example, 250 red pots, and you drop down 1, when you PickUp your will receive 49 extra pots. Why? cause the gamefile know the maximum slotsize is 200, then it make a new stack with the extra items (49) +1 with the picked item, so now we have 249 red pots + 50 red pots into another slot.
I think this bug is really dangerous, cause people will make lot of red pots for free, and then sell them to make yangs, or they can "duplicate" important items.
The fix for this bug is easy, i was looking on the PickUp functions and i have found this:

[Only registered and activated users can see links. Click Here To Register...]

in this piece of code we can see :

Code:

v14 = MIN(200 - v13,v52)

We have just to change 200 to 250(in hex 0xC8 to 0xFA), and the problem will be solved ;)
This is the DIF for rev_2089 (just the fix)

Code:

0004E1B9: C8 FA

This is the full DIF for 250 Items in a slot

Code:

0004E1B9: C8 FA
0004EA24: C8 FA
0008C8BC: C8 FA
000EFA44: C8 FA
000F28AE: C8 FA
000F6579: C8 FA

Sorry for my bad english, i hope this will help Server Founder of many servers ;)

Lup.

12/12/2012 01:10 balika01#2

for 255:
0004E1B9: C8 FF
0004EA24: C8 FF
0008C8BC: C8 FF
000EFA44: C8 FF
000F28AE: C8 FF
000F6579: C8 FF

12/12/2012 02:51 Laben#3

Quote:
Originally Posted by Lupetto
Hi all epvp members,
i'm going to release an important fix of that bug:
lot of p.servers have encreased the max slot capacity to 250 (Original was 200).
All of them, have an important bug, i will try to explain what is the bug:
If you have, for example, 250 red pots, and you drop down 1, when you PickUp your will receive 49 extra pots. Why? cause the gamefile know the maximum slotsize is 200, then it make a new stack with the extra items (49) +1 with the picked item, so now we have 249 red pots + 50 red pots into another slot.
I think this bug is really dangerous, cause people will make lot of red pots for free, and then sell them to make yangs, or they can "duplicate" important items.
The fix for this bug is easy, i was looking on the PickUp functions and i have found this:

[Only registered and activated users can see links. Click Here To Register...]

in this piece of code we can see :
Code:
v14 = MIN(200 - v13,v52)
We have just to change 200 to 250(in hex 0xC8 to 0xFA), and the problem will be solved ;)
This is the DIF for rev_2089 (just the fix)
Code:
0004E1B9: C8 FA
This is the full DIF for 250 Items in a slot
Code:
0004E1B9: C8 FA
0004EA24: C8 FA
0008C8BC: C8 FA
000EFA44: C8 FA
000F28AE: C8 FA
000F6579: C8 FA
Sorry for my bad english, i hope this will help Server Founder of many servers ;)

Lup.

thanks a lot :)

12/12/2012 03:27 vinni03#4

this is already released...
[Only registered and activated users can see links. Click Here To Register...]

12/12/2012 11:36 Lupetto#5

Quote:

Originally Posted by vinni03

this is already released...
[Only registered and activated users can see links. Click Here To Register...]

I didn't saw that.. i found this from myself, but someone found that before me, so i'm sorry, but i test this bug on some server and all have it..

12/12/2012 12:01 xP3NG3Rx#6

Code:

This difference file is created by The Interactive Disassembler

game_r2089M_32
CHARACTER__AutoGiveItem
0004D38D: C8 FA

CHARACTER__PickupItem
0004E1B9: C8 FA

CHARACTER__MoveItem
0004EA24: C8 FA

do_item
0008C8BC: C8 FA

CItem__GetCount
000EFA44: C8 FA

CItem__SetCount
000F28AE: C8 FA

ITEM_MANAGER__CreateItem
000F6579: C8 FA