[Open-Source] Virtual Conquer

07/20/2010 09:53 Basser#46
Actually, I agree with Korvacs.
I am completely rewritting the source, I will release the new version as soon as possible.
07/20/2010 10:33 Korvacs#47
Was just looking through your socket and packet handling Basser, you never actually split your packets up, so the chances are your socket at some point or anouther may receive 2 packets at once, and your server will treat them as one packet.

This will cause numerous errors =o

Also you might want to consider commenting your source throughout, it'll help you keep track of where you want your code to go, and also allow people to understand what your code is doing.
07/20/2010 16:26 Basser#48
Quote:
Originally Posted by Korvacs View Post
Was just looking through your socket and packet handling Basser, you never actually split your packets up, so the chances are your socket at some point or anouther may receive 2 packets at once, and your server will treat them as one packet.

This will cause numerous errors =o

Also you might want to consider commenting your source throughout, it'll help you keep track of where you want your code to go, and also allow people to understand what your code is doing.
Yes, I was aware of the fact I did not yet split packets.
About the 2nd, thing, I'm not sure if thats necessary, because I often find my comments annoying, because they make code look less structured.
07/21/2010 18:42 ~Yuki~#49
Quote:
Originally Posted by Basser View Post
Yes, I was aware of the fact I did not yet split packets.
About the 2nd, thing, I'm not sure if thats necessary, because I often find my comments annoying, because they make code look less structured.
But easier to understand.

Anyway, I joined Virtual Conquer and will work on the upcomming Revisions.

Thanks bas. Finally we are working together again.
07/21/2010 20:27 Basser#50
Entirely rewritten the source.
New SVN folder, removed the old one, uploaded the new source.

I have entirely rewritten this source!
--> You need .NET Framework 4.0!
07/21/2010 20:56 Korvacs#51
I massively prefered the old source, this one is very, very messy, over complication for the sake of over complication.
07/21/2010 21:31 Basser#52
I hope we can discuss this on MSN, I wasn't really expecting this, so please explain what exactly is messy about this source.
I'm sure it can be redone.

Besides, remember its open-source, it is not meant to be be used as an example, its meant to be a base for developing it into your own, unique source.
07/21/2010 21:59 MonstersAbroad#53
Might update this to 5180.
07/21/2010 22:32 Korvacs#54
Quote:
Originally Posted by Basser View Post
I hope we can discuss this on MSN, I wasn't really expecting this, so please explain what exactly is messy about this source.
I'm sure it can be redone.

Besides, remember its open-source, it is not meant to be be used as an example, its meant to be a base for developing it into your own, unique source.
If you compare the two sources that youve been working on the first is very lightweight, but extremely powerful, this one from the code ive read seems bulky, and extremely complicated, for seemingly very little reason.
07/22/2010 10:00 JoshuaX#55
Korv man add me on msn =P think you changed it and i wasnt around haha [Only registered and activated users can see links. Click Here To Register...] and i'd agree with korv your old one was neat and powerful. this one is fairly sloppy =x
07/22/2010 12:10 Basser#56
Quote:
Originally Posted by Korvacs View Post
If you compare the two sources that youve been working on the first is very lightweight, but extremely powerful, this one from the code ive read seems bulky, and extremely complicated, for seemingly very little reason.
Are you saying it is less powerful now?
07/22/2010 12:50 chickmagnet#57
Quote:
Originally Posted by Basser View Post
Are you saying it is less powerful now?
the first 1 was pretty nice just had a few probs maybe u should use old 1 and just fix it up
07/22/2010 13:43 Basser#58
Quote:
Originally Posted by chickmagnet View Post
the first 1 was pretty nice just had a few probs maybe u should use old 1 and just fix it up
Or use the new one and fix the parts you guys find messy.
07/22/2010 15:17 chickmagnet#59
Quote:
Originally Posted by Basser View Post
Or use the new one and fix the parts you guys find messy.
its all up 2 u bro anyways good job and goodluck wit watever u decide i have faith in u
07/23/2010 22:52 ~Yuki~#60
I would prefer the old one too.... Sorry bas. please lets work on the old one =(

EDIT: Since Yesterday, i cant find motivation to work on it