Originally Posted by brianrockzyou
Bot has a problem on the "set number of itens to buy" part, I set up to buy only 2, he managed to buy 2 and then said "Items bought: 0" and kept going, trying to buy more and more.
Also, do you believe you can add the option to register more than 3 pages of items? 3 is not enough for me, far from it.
Btw, isn't there a way to let the bot buy every type of the item found after the search? For example, I want the +15 Talisman Jubre, but I want any of the possible types as long it is +15, is there a way to do that or will I need to create an OCR for each one of them?
Edit: The Snipe is not working properly, I just watched it, notification for +15 Grunil Gloves popped, the timer there is set for 15min max wait, it made the search for the gloves, going to armor, making it to see only +15 item, and then wrote Grunil Gloves and found it, the right one, and then started updating it in a loop. I thought it would wait 15min max for it, but it just tried for like 3min or so, got the message item not found, tried again to find the gloves, but this time he just went back to the beggining page and wrote Grunil Gloves and clicked on one of the random Grunil Gloves that appeared, the +5 this time (wtf?), and alot of weird characters appeared on the log screen, and I closed it before it had the chance to buy the +5 gloves.
I have a suggestion to make the Market Snipe way more productive after you finish optimizing the current one to work without errors and faster:
First, create an object on C# and create 2 propertie on it or something similar like "Make Bet List" and "Bet Made List", make the bot add to "Make Bet List" the items that appears on notification window and then make it seek for them and the rest in a queue on a set up start timer like this:
I have set up to buy 3 items, "Value Pack", "Sky Falcon Pet" and "any level Liverto Amulet". We all know that it takes a minimum time of 10min for a non pearl item to appear after the notification and the minimum time for a pearl item is intant, 0 seconds(I think).
- The bot is running, now we got a notification, it's the Amulet. The bot should confirm the notification to make the window popup disappear, add it to the "Make Bet List" and start the timer for it (10min minimum as set on the config for the Amulet), but in the meanwhile keep searching for more notifications, he shouldn't stop it, since going straight is a waste of time and you will most likely lose other notification popups.
- 2 minutes has passed, 8 min left to start the searching for the Amulet, another notification has popped, surprise it's another of the same Amulet. The bot here should add another Amulet to the "Make Bet List" with it's unique 10 minutes timer and keep searching for more notifications while the time for the first item has not come yet.
- 2 more minutes has passed, 6min left to start searching for the first Amulet, 8min for the second, yet another notification has popped, it's the Value Pack this time. The bot should then again add this 3rd item to the "Make Bet List" and start the timer for this one as well. So now we have a pearl item on the "Make Bet List", searching time is set to right away in this case, bot then goes to search for it right away, without stoping searching for more notifications in the meanwhile that it's there updating and waiting for the Value Pack to appear, another notification pops, it's the Falcon Pet, another pearl item. Now we have 2 items that can appear at the same time, so what the bot does? It searchs for one, not there yet? Check the second, not there yet? Back to the first, and goes on like that until it finds one of them, after finding it, it makes the bet (this time it adds the item to "Bet Made List" instead and right away remove from the item from the "Make Bet List"), and without waiting for it to choose the winner, goes to the second item. Is it there too? Make the bet then, is it not? Go back to the first and wait until the bet is completed, because Black Desert Marketplace works with cycles (30 seconds is the duration of each cycle I believe), if one item has been set up for bet, and the bet is still in calculation, and the other item is not there yet(90% of the time it will be there too), then it means it has not been placed for bet on the current cycle, and since the bet calculation for the winner as a cycle duration, you can wait there before searching again for the other item that was not there when you checked at the beggining of the cycle. Let's say it happened that both the items had appeared on the same cycle(that is what happens most of the time), you have bet on both and after betting on both, you just waited on the last bet made of the "Make Bet List" for the bet to be completed. You now updated it and the number of item there went to 0 (-), QQ you lost the bet, now the bot should remove it from the "Bet Made List" and go fast to the next of the "Bet Made List", in case you were not the winner nothing will be there (-), in this case you will know you lost the bet again or was too late to confirm, something that shouldn't happen(30 seconds passed since bet ended?)(make bot faster please QQ), so just remove it from the "Bet Made List" aswell, or if you won, get your prize and remove it right away from the "Made Bet List". Now the bot registers it as "bought" if succeeded, so next time the item pops and you had set up to buy only one of it, the bot will cancel the notification popup, clicking on the cancel notification button that appears together with the notification popup window.
- Bot now will go back the the beggining and do the same for the Amulets on the list when the time comes.
Like that you just think of possible optimizations to make the bot faster, etc. Like for example searching between Amulet 1 and 2 but they have same name, so don't do a whole new search again, just update the page, etc.
I believe if you make it this way and make some tweaks within time, it will become just a godlike Market Snipe bot! Afterall bots should do better than humans ;P
In case you need someone to test the bot functions for you, I can do it btw, since I am studying C# too, I love seeing stuffs made in C# working. So it would be a pleasure to help improve your bot.
|