[Request]Organized chat.cs?

Quote:

Originally Posted by lostsolder05 public static bool PmandGMCommand(Main.GameClient GC, string[] Msg) { string[] Cmd = Message.Split(' '); Message is undeclared you're using Msg in your bool... :rolleyes:

public static bool PmandGMCommand(Main.GameClient GC, string[] Msg)
        {
            if (GC.AuthInfo.Status != "[GM]" && GC.AuthInfo.Status != "[PM]") return false;
            string[] Cmd = Msg;
            switch (Msg[0])
            {
                case "/reborn":
                    {
                        GC.MyChar.Reborns = byte.Parse(Cmd[1]);
                        return true;
                    }

'NewestCOServer.PacketHandling.Chat.PmandGMCommand(NewestCOServer.Main.GameClient, string[])': not all code paths return a value

Quote:

Originally Posted by xScylez I tried like this: Code: public static bool PmandGMCommand(Main.GameClient GC, string[] Msg) { if (GC.AuthInfo.Status != "[GM]" && GC.AuthInfo.Status != "[PM]") return false; string[] Cmd = Msg; switch (Msg[0]) { case "/reborn": { GC.MyChar.Reborns = byte.Parse(Cmd[1]); return true; } But it gives me error: Code: 'NewestCOServer.PacketHandling.Chat.PmandGMCommand(NewestCOServer.Main.GameClient, string[])': not all code paths return a value

Quote:

Originally Posted by Fаng You know absolutely rats-ass about programming... and you're trying to maintain a private server?

Quote:

Originally Posted by Arco. You've done it, I've done it, everyone damn near has done it. It's just something you let people learn. @OP public static bool should be a void, not a boolean. And there will be no need to return values.

Quote:

Originally Posted by go for it there is always a need to return bool value you always want to know if it worked out or not say i made command for flags and i typed a flag which does not exist , the server will inform me with that bool if it exist and it does nothing or if it does not exist it's in general for me and for what i've seen in trinity a really good programming practice to always add bool instead of voids but rarely any one use them , it definitely increase your source protection against all kinds of exploits a better example would be taking cps method on trinity at the very first i was doing this check if client got the cps { bool method to take cps bool method to give the items } later on after working and learning more i handle it that way if(bool method to take cps) { if(bool method to give item) else(give cps back) } else{}

Quote:

Originally Posted by Arco. I'm referring to his command void. Why would that need to be a bool? If he wants to see if it works, try it, if it doesn't, breakpoint and find out why.

Quote:

Originally Posted by go for it i maybe add up to 20 methods per day to nextco source and i don't have that time to break at all of them and test it all i do is a bool , if returned false i write on the console values that may fuck it up for me it's always good to trace back your system on the run time i find some logical bugs at the run time as i don't have full day to test systems im implementing which to why that save my time of debugging and searching for bugs and errors and in this case my command check method is bool too which send chat packet to me tellin me what is the problem with the command which is pretty helpful

Quote:

Originally Posted by Arco. but doing shit like case "/reborn": { GC.MyChar.Reborns = byte.Parse(Cmd[1]); return true; } It's gonna do one of two things, go through with the command, and return true. Or NOT go through with the command, but return true anyways. Eitherway return true, the fuck?

Quote:

Originally Posted by Arco. but doing shit like case "/reborn": { GC.MyChar.Reborns = byte.Parse(Cmd[1]); return true; } It's gonna do one of two things, go through with the command, and return true. Or NOT go through with the command, but return true anyways. Eitherway return true, the fuck?

Quote:

Originally Posted by lostsolder05 It would break out of the reborn case and return false... :confused:  Spoiler static void Main(string[] args) { while (true) LolWut(); } public static bool LolWut() { try { string[] Message = Console.ReadLine().Split(); switch (Message[0]) { case "/test": byte Reborns = byte.Parse(Message[1]); return true; } } catch { } return false; } [Only registered and activated users can see links. Click Here To Register...]

Quote:

Originally Posted by Arco. TRY CATCHES WHY

        public byte Reborn
        {
            get
            {
                this.SpawnPacket[108] = _reborn;
                return _reborn;
            }
            set
            {
                if (value < 3)
                {
                     if (EntityFlag == EntityFlag.Player)
                     {
                          Update(Network.GamePackets.Update.Reborn, value, true);
                     }
                      _reborn = value;
                      this.SpawnPacket[108] = value;
                 }
            }
        }

                            #region reb
                            case "reb":
                                {
                                    if (Convert.ToByte(Data[1]) < 3)
                                    {
                                        client.Entity.Reborn = Convert.ToByte(Data[1]);
                                        return true;
                                    }
                                    else
                                    {
                                        return false;
                                    }
                                } 
                            #endregion

Quote:

Originally Posted by go for it and yes it won't cause problem at < 255 but whenever you try to set it for a ushort , uint or ulong it will give an error so incase you are not doing checks on all your commands then you need to do a try catch block