[Non-Mini Release] Rewriting Client Notification Handler

Quote:

Originally Posted by #HB Hmmm works fine for me. Your problem is here anyways: Code: if (chat = g_notificationhandler.GetKillNotify(uqdata->ObjNameStrID)) { swprintf_s(buffer, sizeof(buffer), g_textmanager->GetStringTextByCode(chat)->c_str(), KillerName.c_str()); g_interface->ShowBlueNotify(buffer); sysmsg->Write(UNIQUE_KILL_SYSTEM_COLOR, buffer); } You have to be exceeding the buffer size or messing up arguments, ex: [Only registered and activated users can see links. Click Here To Register...]

Quote:

Originally Posted by Goosxc My game stuck after i load monster the unique also after i killed the unique i got the same error @norsegodtyr

Quote:

if (chat = g_notificationhandler.GetKillNotify(uqdata->ObjNameStrID)) { swprintf_s(buffer, sizeof(buffer), g_textmanager->GetStringTextByCode(chat)->c_str(), KillerName.c_str()); g_interface->ShowBlueNotify(buffer); sysmsg->Write(UNIQUE_KILL_SYSTEM_COLOR, buffer); }

Quote:

Originally Posted by NorseGodTyr swprintf_s to swprintf

Quote:

Originally Posted by irockalone any help?

Quote:

Originally Posted by *Deadly Is it possible to use some other color like the Pink, Green and Blue notifications on the middle of the screen?

Quote:

Originally Posted by *Deadly when I tried to change the hex color of ShowBlueNotify or Pink to something else and build, it started crashing my client the unique appears.

Quote:

Originally Posted by #HB Which means your buffer is messed up or it exceeds limit, so its no good to modify it to swprintf. swprintf_s is limited by the dest buffer size that you specify so if you exceed it, you should be getting that error. While swprintf just fills the dest buffer with the same size of the source, so it doesn't really care if it exceeds the dest buffer size, AKA if source size is greater than dest size, you'll modify bytes that don't really belong to your dest buffer, which is not safe AT ALL. That's probably why swprintf is not considered safe. So, you can try increasing the buffer size.

Quote:

Originally Posted by #HB You must've modified something else that isn't really related to it.

void CGInterface::ShowBlueNotify(std::wstring msg)
{
	reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, &msg);
}

void CGInterface::ShowBlueNotify(std::wstring* msg)
{
	reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, msg);
}

Quote:

Originally Posted by #HB Which means your buffer is messed up or it exceeds limit, so its no good to modify it to swprintf. swprintf_s is limited by the dest buffer size that you specify so if you exceed it, you should be getting that error. While swprintf just fills the dest buffer with the same size of the source, so it doesn't really care if it exceeds the dest buffer size, AKA if source size is greater than dest size, you'll modify bytes that don't really belong to your dest buffer, which is not safe AT ALL. That's probably why swprintf is not considered safe. So, you can try increasing the buffer size. You seem to miss includes somehow or VC packages. Should be possible, but its not related to this topic. Have a look at resinfo files as well, the color could be there as well. You must've modified something else that isn't really related to it.

Quote:

Originally Posted by *Deadly i modified those hex colors Code: void CGInterface::ShowBlueNotify(std::wstring msg) { reinterpret_cast<void(__thiscall *)(CGInterface*, std::wstring*)>(0x0077B580)(this, &msg); }

Quote:

Originally Posted by irockalone what VC should i use? and can you share link for download?

Quote:

Originally Posted by #HB NOTE: Structures found in the files are for VC80 libs, back when strings were 28 bytes. You'll face errors, if you work with any later compiler.

Quote:

Originally Posted by #HB Uhm... These are not colors, these are addresses. Anyways this is out of topic, so please keep this outta here.

Quote:

Originally Posted by irockalone its been 2 hour while i m looking for VC80 SP but there's nothing exists like MS stopped supporting this lol i would be thankful if you shared a link for this.

• Download Visual Studio 2005
• [Only registered and activated users can see links. Click Here To Register...]

Quote:

Originally Posted by #HB VC80 is pretty old yeah, but sadly we have to stick with it, you have 2 options: Download Visual Studio 2005 [Only registered and activated users can see links. Click Here To Register...] No matter what option you choose, you still need to keep up with Joymax allocator, so flo's reconstructed JoymaxAllocator in [Only registered and activated users can see links. Click Here To Register...] would be great to ensure the safety of your std lib.

Quote:

Originally Posted by #HB Uhm... These are not colors, these are addresses. Anyways this is out of topic, so please keep this outta here.

Quote:

Originally Posted by nevet.S Can it work for taiwan v1.258 files?