[Release] Server Buffs based on Online Player Count

Quote:

Originally Posted by Naltalah

Edit: The consensus of the feedback so far is, that this code is very performance inefficient. If I have the time, I will rewrite the code and reupdate.

I coded this for a friend and thought why not share it with everyone.

Disclaimer: I'm still kind of new to coding, so if you have any suggestions on how to improve the code, let me know <3

I won't be adding a guide on how to create the items that are used as the a buff, there are enough guides on that out there.

ProjectCmn.cpp

Spoiler

before

PHP Code:

BOOL CProject::LoadJobItem(LPCTSTR lpszFilename)

add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS BOOL CProject::LoadOnlineCountFile(LPCTSTR lpszFilename) {     CScript script;     if (script.Load(lpszFilename) == FALSE)         return FALSE;     script.GetToken();     int nOnlineCount;     DWORD dwBuffId;     while (script.tok != FINISHED)     {         dwBuffId = atoi(script.Token);         nOnlineCount = script.GetNumber();         script.GetToken();         m_aOnlineCountBuffs.insert(make_pair(nOnlineCount, dwBuffId));     }     return TRUE; } #endif // __SYS_ONLINECOUNT_BUFFS

Project.cpp

Spoiler

after:

PHP Code:

CTitleManager::Instance()->LoadTitle("honorList.txt");

add

PHP Code:

#if defined(__WORLDSERVER) && defined(__SYS_ONLINECOUNT_BUFFS)     LoadOnlineCountFile("onlinebuff.inc"); #endif

Project.h

Spoiler

after

PHP Code:

void LoadSkill();

add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS #ifdef __WORLDSERVER     BOOL    LoadOnlineCountFile(LPCSTR lpszFilename);     map<int, DWORD>    m_aOnlineCountBuffs; #endif // __WORLDSERVER #endif // __SYS_ONLINECOUNT_BUFFS

User.h

Spoiler

after:

PHP Code:

    void    SendNewRandomOption( unsigned char id, DWORD dwSerialNumber, __int64 n64NewRandomOption );

add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS     const int        GetClosestCount();     vector<int>        GetValidCounts();     void            RemoveOnlineBuffs();     void            ApplyOnlineBuff(); #endif

User.cpp

Spoiler

in CUser::Process()

after

PHP Code:

    if( IsLive() )     {

add

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS         this->ApplyOnlineBuff(); #endif // __SYS_ONLINECOUNT_BUFFS

at the end of the file add this:

PHP Code:

#ifdef __SYS_ONLINECOUNT_BUFFS const int CUser::GetClosestCount() {     int nNum = 0;     for (auto it : prj.m_aOnlineCountBuffs)     {         if (g_UserMng.GetCount() >= it.first)             nNum = it.first;     }     return nNum; } vector<int> CUser::GetValidCounts() {     vector<int> nValidBuffs;     for (auto it : prj.m_aOnlineCountBuffs)     {         if (g_UserMng.GetCount() >= it.first)             nValidBuffs.push_back(it.second);     }     return nValidBuffs; } void CUser::RemoveOnlineBuffs() {     vector<int> nValidBuffs = GetValidCounts();     for (auto it : prj.m_aOnlineCountBuffs)     {         if (__SYS_ONLINECOUNT_BUFFS_MODE == 1)         {             auto vec_it = std::find(nValidBuffs.begin(),nValidBuffs.end(),it.second);             if (HasBuff(BUFF_ITEM, it.second) && vec_it == nValidBuffs.end())                 this->RemoveBuff(BUFF_ITEM, it.second);         }         else         {             if (this->HasBuff(BUFF_ITEM, it.second) && GetClosestCount() != it.first)                 this->RemoveBuff(BUFF_ITEM, it.second);         }     } } void CUser::ApplyOnlineBuff() {     this->RemoveOnlineBuffs();     if (__SYS_ONLINECOUNT_BUFFS_MODE == 1)     {         vector<int> nValidBuffs = GetValidCounts();         for (auto it : nValidBuffs)         {             ItemProp* pProp = prj.GetItemProp(it);             if (pProp && !HasBuff(BUFF_ITEM, it))                 DoApplySkill(this, pProp, NULL);         }              }     else {         int nCount = GetClosestCount();         if (prj.m_aOnlineCountBuffs.find(nCount) == prj.m_aOnlineCountBuffs.end())             return;         ItemProp* pProp = prj.GetItemProp(prj.m_aOnlineCountBuffs.at(nCount));         if (pProp && !HasBuff(BUFF_ITEM, pProp->dwID))             DoApplySkill(this, pProp, NULL);     } } #endif // __SYS_ONLINECOUNT_BUFFS

VersionCommon.h (WorldServer)

add this:

PHP Code:

#define        __SYS_ONLINECOUNT_BUFFS #ifdef __SYS_ONLINECOUNT_BUFFS #define        __SYS_ONLINECOUNT_BUFFS_MODE    1    // 0 = Only highest buff will be active, 1 = All buffs will be active #endif // __SYS_ONLINECOUNT_BUFFS

Resource

You will need to create a new file called onlinebuff.inc.

It has to look like this:

PHP Code:

// dwBuffID                     Online Count II_ONLINEBUFF_LEVEL1            10 II_ONLINEBUFF_LEVEL2            20

First comes the ID of the buff, after that the amount of users that have to be online to apply this buff.

Please note that this does not work for multiple channels.

I also added these instruction as an attachment if you want to save it for later.

i do have get error in user.cpp

Spoiler

please help.