[EPIC-Release]Top Class Effects!

Nice release and ty for contributing, Glad your getting arround and doing some things for your self airborne

blade, i can honestly say, i'm proud your finally learning. good job.

Quote:

Originally Posted by Prot0type blade, i can honestly say, i'm proud your finally learning. good job.

@Blade,
Exactly the same here.
I hope you will keep it up, if I had more time right now, I would have contacted you this morning, but I'm ill, and have lots of homework, sorry.
Keep up, Blade. Everybody is proud of you I guess!

~Bas

Source Patch: 5165

CREDITS TO -Shunsui- for giving me an example of 1 NPC so that I could make all of them.

I WOULD APPRECIATE IF SOMEONE PUT ALL THESE NPCS AND MADE IT INTO ONE. THANKS <-- Done. Korvacs posted it below.

This code is several NPC codes put together (It's more than 1 NPC though) and if you talk to them it makes you Top ____ look Below:



Code below, add it in PacketHandling/NPCDialog.cs, enjoy:






Now in OldCODB add:

Quote:

Originally Posted by ayna5 Source Patch: 5165 CREDITS TO -Shunsui- for giving me an example of 1 NPC so that I could make all of them. I WOULD APPRECIATE IF SOMEONE PUT ALL THESE NPCS AND MADE IT INTO ONE. THANKS <-- Done. Korvacs posted it below. This code is several NPC codes put together (It's more than 1 NPC though) and if you talk to them it makes you Top ____ look Below: Code below, add it in PacketHandling/NPCDialog.cs, enjoy: Code: #region Top Trojan case 2727: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the Top Trojan Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopTrojan); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region Top Ninja case 2728: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the TopNinja Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopNinja); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopGuildLeader case 2729: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you liek the TopGuildLeader halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopGuildLeader); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region WeeklyPKChampion case 2730: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the WeeklyPKChampion Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.WeeklyPKChampion); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region MonthlyPKChampion case 2731: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the MonthlyPkChampion Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.MonthlyPKChampion); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopDeputyLeader case 2732: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you liek the TopDeputyLeader Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopDeputyLeader); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopWarrior case 2733: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the Top Warrior Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopWarrior); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopArcher case 2734: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the TopArcher Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopArcher); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopWaterTaoist case 2735: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the Top WaterTaoist Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopWaterTaoist); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopFireTaoist case 2736: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the TopFireTaoist Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopFireTaoist); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion #region TopArcher case 2737: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Would you like the TopArcher Halo?")); GC.AddSend(Packets.NPCLink("Yeh, Meng", 1)); GC.AddSend(Packets.NPCLink("Nah.", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.MyChar.StatEff.Add(StatusEffectEn.TopArcher); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } break; } #endregion Now in OldCODB add:

Your point..????

I had a little play around with this to create a single npc to give the honor halos only to find out that it had already been done by Korvacs hehe, what I attempted was so that it gives only a ninja the TopNinja halo but I have so far failed with it :( This is part of the whole code but why is it not searching to see if I am what I say I am? I mean it tells me I am not "TopWarrior" but would still give me the halo even if I am ninja?

if (Control == 6)
{
if (GC.MyChar.Job >= 50 && GC.MyChar.Job <= 55)
{

}
else
{
GC.AddSend(Packets.NPCSay("You are not a Ninja, so get lost, will you?"));
GC.AddSend(Packets.NPCLink("Sorry.", 255));
GC.AddSend(Packets.NPCSetFace(N.Avatar));
GC.AddSend(Packets.NPCFinish());
}
GC.MyChar.StatEff.Add(StatusEffectEn.TopNinja);
GC.Message(2005, GC.MyChar.Name + "Has won the Top Ninja Halo");

}

Becareful with your if statements:

Quote:

Originally Posted by Korvacs Code: if (Control == 6) { if (GC.MyChar.Job >= 50 && GC.MyChar.Job <= 55) { GC.MyChar.StatEff.Add(StatusEffectEn.TopNinja); GC.Message(2005, GC.MyChar.Name + "Has won the Top Ninja Halo"); } else { GC.AddSend(Packets.NPCSay("You are not a Ninja, so get lost, will you?")); GC.AddSend(Packets.NPCLink("Sorry.", 255)); GC.AddSend(Packets.NPCSetFace(N.Avatar)); GC.AddSend(Packets.NPCFinish()); } } Becareful with your if statements: Code: //When creating an if statement, it is important to understand that when the statement is true, it performs the actions within your brackets int Job = 50; if (Job == 50) { //This statement is true, so the code which is placed here is called. } //When the statement is false the code within the brackets is not called. Job = 100; if (Job == 50) { //This statement is false, so the code which is placed here is not called. } //If you want you can add an else statement which will be called when an if statement is false Job = 100; if (Job == 50) { //This statement is false, so the code which is placed here is not called. } else { //The code which is placed here will be called since the if statement is false. } //You can also have a third option for handling multiple statements Job = 100; if (Job == 50) { //This statement is false, so the code which is placed here is not called. } else if (Job == 100) { //This statement is true, so the code here will be called. } else { //Since the second statement is true, this information is not called. } //The advantage of this is that the if you have multiple statements, and only one of them can be correct, your code will quickly skip the statements which are not correct, //and then after handling the one and only true statement will come out of the entire if statement without performing further checks, it is considerably faster than multiple //if statements: if (Job == 50) { } if (Job == 100) { } if (Job == 150) { }

True, and a lot of people don't know when to use Else if, or at least they don't use it when they should.

Quote:

Originally Posted by Smythe94 True, and a lot of people don't know when to use Else if, or at least they don't use it when they should.

Isn't it pretty obvious when you need to use it?
I mean it's used like this:
if certain conditions are met do the following so like this if(something here){stuff to do when conditions met}
Then use else when the conditions are not met so like this if(something here){stuff to do when conditions met}else{something else here to be activated when the conditions are not met}
At least that's how I learned to do it =S

Yes sir it is.

Quote:

Originally Posted by Kiyono Isn't it pretty obvious when you need to use it? I mean it's used like this: if certain conditions are met do the following so like this if(something here){stuff to do when conditions met} Then use else when the conditions are not met so like this if(something here){stuff to do when conditions met}else{something else here to be activated when the conditions are not met} At least that's how I learned to do it =S

I know it is, but yet a lot of people use just if when they should use else if.

ty dude

Quote:

Originally Posted by Gorjangorjan ty dude

No problem

Quote:

Originally Posted by Korvacs Code: case 2727: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Which type of Halo do you want?")); GC.AddSend(Packets.NPCLink("Guild", 1)); GC.AddSend(Packets.NPCLink("Class", 2)); GC.AddSend(Packets.NPCLink("Pk", 3)); GC.AddSend(Packets.NPCLink("None", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.AddSend(Packets.NPCSay("Which Halo do you want?")); GC.AddSend(Packets.NPCLink("GuildLeader", 10)); GC.AddSend(Packets.NPCLink("DeputyLeader", 11)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 2) { GC.AddSend(Packets.NPCSay("Which Halo do you want?")); GC.AddSend(Packets.NPCLink("Warrior", 20)); GC.AddSend(Packets.NPCLink("Archer", 21)); GC.AddSend(Packets.NPCLink("WaterTaoist", 22)); GC.AddSend(Packets.NPCLink("FireTaoist", 23)); GC.AddSend(Packets.NPCLink("Trojan", 24)); GC.AddSend(Packets.NPCLink("Ninja", 25)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 3) { GC.AddSend(Packets.NPCSay("Which Halo do you want?")); GC.AddSend(Packets.NPCLink("Weekly", 30)); GC.AddSend(Packets.NPCLink("Monthly", 31)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 10) { GC.MyChar.StatEff.Add(StatusEffectEn.TopGuildLeader); GC.Message(2005, GC.MyChar.Name + "Has won the Top Guild Leader Halo"); } else if (Control == 11) { GC.MyChar.StatEff.Add(StatusEffectEn.TopDeputyLeader); GC.Message(2005, GC.MyChar.Name + "Has won the Top Deputy Leader Halo"); } else if (Control == 20) { GC.MyChar.StatEff.Add(StatusEffectEn.TopWarrior); GC.Message(2005, GC.MyChar.Name + "Has won the Top Warrior Halo"); } else if (Control == 21) { GC.MyChar.StatEff.Add(StatusEffectEn.TopArcher); GC.Message(2005, GC.MyChar.Name + "Has won the Top Archer Halo"); } else if (Control == 22) { GC.MyChar.StatEff.Add(StatusEffectEn.TopWaterTaoist); GC.Message(2005, GC.MyChar.Name + "Has won the Top Water Taoist Halo"); } else if (Control == 23) { GC.MyChar.StatEff.Add(StatusEffectEn.TopFireTaoist); GC.Message(2005, GC.MyChar.Name + "Has won the Top Fire Taoist Halo"); } else if (Control == 24) { GC.MyChar.StatEff.Add(StatusEffectEn.TopTrojan); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } else if (Control == 25) { GC.MyChar.StatEff.Add(StatusEffectEn.TopNinja); GC.Message(2005, GC.MyChar.Name + "Has won the Top Ninja Halo"); } else if (Control == 30) { GC.MyChar.StatEff.Add(StatusEffectEn.WeeklyPKChampion); GC.Message(2005, GC.MyChar.Name + "Has won the Weekly Pk Champion Halo"); } else if (Control == 31) { GC.MyChar.StatEff.Add(StatusEffectEn.MonthlyPKChampion); GC.Message(2005, GC.MyChar.Name + "Has won the Monthly Pk Champion Halo"); } } Thanks are appreciated.

you forgot to add the statement break at the end.
for those who don't like to type here's it with break.
99% of the credits go to Korvacs.

Quote:

#region Top Halo case 2727: { if (Control == 0) { GC.AddSend(Packets.NPCSay("Which type of Halo do you want?")); GC.AddSend(Packets.NPCLink("Guild", 1)); GC.AddSend(Packets.NPCLink("Class", 2)); GC.AddSend(Packets.NPCLink("Pk", 3)); GC.AddSend(Packets.NPCLink("None", 255)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 1) { GC.AddSend(Packets.NPCSay("Which Halo do you want?")); GC.AddSend(Packets.NPCLink("GuildLeader", 10)); GC.AddSend(Packets.NPCLink("DeputyLeader", 11)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 2) { GC.AddSend(Packets.NPCSay("Which Halo do you want?")); GC.AddSend(Packets.NPCLink("Warrior", 20)); GC.AddSend(Packets.NPCLink("Archer", 21)); GC.AddSend(Packets.NPCLink("WaterTaoist", 22)); GC.AddSend(Packets.NPCLink("FireTaoist", 23)); GC.AddSend(Packets.NPCLink("Trojan", 24)); GC.AddSend(Packets.NPCLink("Ninja", 25)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 3) { GC.AddSend(Packets.NPCSay("Which Halo do you want?")); GC.AddSend(Packets.NPCLink("Weekly", 30)); GC.AddSend(Packets.NPCLink("Monthly", 31)); GC.AddSend(Packets.NPCSetFace(30)); GC.AddSend(Packets.NPCFinish()); } else if (Control == 10) { GC.MyChar.StatEff.Add(StatusEffectEn.TopGuildLeade r); GC.Message(2005, GC.MyChar.Name + "Has won the Top Guild Leader Halo"); } else if (Control == 11) { GC.MyChar.StatEff.Add(StatusEffectEn.TopDeputyLead er); GC.Message(2005, GC.MyChar.Name + "Has won the Top Deputy Leader Halo"); } else if (Control == 20) { GC.MyChar.StatEff.Add(StatusEffectEn.TopWarrior); GC.Message(2005, GC.MyChar.Name + "Has won the Top Warrior Halo"); } else if (Control == 21) { GC.MyChar.StatEff.Add(StatusEffectEn.TopArcher); GC.Message(2005, GC.MyChar.Name + "Has won the Top Archer Halo"); } else if (Control == 22) { GC.MyChar.StatEff.Add(StatusEffectEn.TopWaterTaois t); GC.Message(2005, GC.MyChar.Name + "Has won the Top Water Taoist Halo"); } else if (Control == 23) { GC.MyChar.StatEff.Add(StatusEffectEn.TopFireTaoist ); GC.Message(2005, GC.MyChar.Name + "Has won the Top Fire Taoist Halo"); } else if (Control == 24) { GC.MyChar.StatEff.Add(StatusEffectEn.TopTrojan); GC.Message(2005, GC.MyChar.Name + "Has won the Top Trojan Halo"); } else if (Control == 25) { GC.MyChar.StatEff.Add(StatusEffectEn.TopNinja); GC.Message(2005, GC.MyChar.Name + "Has won the Top Ninja Halo"); } else if (Control == 30) { GC.MyChar.StatEff.Add(StatusEffectEn.WeeklyPKChamp ion); GC.Message(2005, GC.MyChar.Name + "Has won the Weekly Pk Champion Halo"); } else if (Control == 31) { GC.MyChar.StatEff.Add(StatusEffectEn.MonthlyPKCham pion); GC.Message(2005, GC.MyChar.Name + "Has won the Monthly Pk Champion Halo"); } break; } #endregion

Quote:

Originally Posted by Korvacs Thanks are appreciated.

Quote:

Originally Posted by airborne. enjoy:

Thanks.